67460e8c9a
Also change to div64_u64 in one place to avoid loss of precision (was dividing a 32 bit number by a 64 bit number, but casting this to 64 bit divided by 32 bit) Those divide functions certainly have esoteric naming! Fixes warnings with asm-generic/div64.h do_div such as: In file included from drivers/iio/common/ssp_sensors/ssp_iio.c:20:0: drivers/iio/common/ssp_sensors/ssp_iio_sensor.h: In function 'ssp_convert_to_freq': >> drivers/iio/common/ssp_sensors/ssp_iio_sensor.h:56:16: warning: comparison of distinct pointer types lacks a cast [enabled by default] drivers/iio/common/ssp_sensors/ssp_iio_sensor.h:56:2: warning: right shift count >= width of type [enabled by default] >> drivers/iio/common/ssp_sensors/ssp_iio_sensor.h:56:2: warning: passing argument 1 of '__div64_32' from incompatible pointer type [enabled by default] include/asm-generic/div64.h:35:17: note: expected 'uint64_t *' but argument is of type 'int *' drivers/iio/common/ssp_sensors/ssp_iio.c: In function 'ssp_common_process_data': include/linux/iio/buffer.h:142:32: warning: 'calculated_time' may be used uninitialized in this function [-Wuninitialized] drivers/iio/common/ssp_sensors/ssp_iio.c:83:10: note: 'calculated_time' was declared here Fixed by using straight coded version as per the description in the div64.h header, thus ensuring no issue with 32 bit integers. Reported-by: kbuild test robot <fengguang.wu@intel.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
72 lines
1.7 KiB
C
72 lines
1.7 KiB
C
#ifndef __SSP_IIO_SENSOR_H__
|
|
#define __SSP_IIO_SENSOR_H__
|
|
|
|
#define SSP_CHANNEL_AG(_type, _mod, _index) \
|
|
{ \
|
|
.type = _type,\
|
|
.modified = 1,\
|
|
.channel2 = _mod,\
|
|
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SAMP_FREQ),\
|
|
.scan_index = _index,\
|
|
.scan_type = {\
|
|
.sign = 's',\
|
|
.realbits = 16,\
|
|
.storagebits = 16,\
|
|
.shift = 0,\
|
|
.endianness = IIO_LE,\
|
|
},\
|
|
}
|
|
|
|
/* It is defined here as it is a mixed timestamp */
|
|
#define SSP_CHAN_TIMESTAMP(_si) { \
|
|
.type = IIO_TIMESTAMP, \
|
|
.channel = -1, \
|
|
.scan_index = _si, \
|
|
.scan_type = { \
|
|
.sign = 's', \
|
|
.realbits = 64, \
|
|
.storagebits = 64, \
|
|
}, \
|
|
}
|
|
|
|
#define SSP_MS_PER_S 1000
|
|
#define SSP_INVERTED_SCALING_FACTOR 1000000U
|
|
|
|
#define SSP_FACTOR_WITH_MS \
|
|
(SSP_INVERTED_SCALING_FACTOR * SSP_MS_PER_S)
|
|
|
|
int ssp_common_buffer_postenable(struct iio_dev *indio_dev);
|
|
|
|
int ssp_common_buffer_postdisable(struct iio_dev *indio_dev);
|
|
|
|
int ssp_common_process_data(struct iio_dev *indio_dev, void *buf,
|
|
unsigned int len, int64_t timestamp);
|
|
|
|
/* Converts time in ms to frequency */
|
|
static inline void ssp_convert_to_freq(u32 time, int *integer_part,
|
|
int *fractional)
|
|
{
|
|
if (time == 0) {
|
|
*fractional = 0;
|
|
*integer_part = 0;
|
|
return;
|
|
}
|
|
|
|
*integer_part = SSP_FACTOR_WITH_MS / time;
|
|
*fractional = *integer_part % SSP_INVERTED_SCALING_FACTOR;
|
|
*integer_part = *integer_part / SSP_INVERTED_SCALING_FACTOR;
|
|
}
|
|
|
|
/* Converts frequency to time in ms */
|
|
static inline int ssp_convert_to_time(int integer_part, int fractional)
|
|
{
|
|
u64 value;
|
|
|
|
value = (u64)integer_part * SSP_INVERTED_SCALING_FACTOR + fractional;
|
|
if (value == 0)
|
|
return 0;
|
|
|
|
return div64_u64((u64)SSP_FACTOR_WITH_MS, value);
|
|
}
|
|
#endif /* __SSP_IIO_SENSOR_H__ */
|