Stephen Boyd f479506e51 macb: Don't unregister clks unconditionally ... [ Upstream commit d89091a493 ] The only clk init function in this driver that register a clk is fu540_c000_clk_init(), and thus we need to unregister the clk when this driver is removed on that platform. Other init functions, for example macb_clk_init(), don't register clks and therefore we shouldn't unregister the clks when this driver is removed. Convert this registration path to devm so it gets auto-unregistered when this driver is removed and drop the clk_unregister() calls in driver remove (and error paths) so that we don't erroneously remove a clk from the system that isn't registered by this driver. Otherwise we get strange crashes with a use-after-free when the devm_clk_get() call in macb_clk_init() calls clk_put() on a clk pointer that has become invalid because it is freed in clk_unregister(). Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Yash Shah <yash.shah@sifive.com> Reported-by: Guenter Roeck <linux@roeck-us.net> Fixes: c218ad5590 ("macb: Add support for SiFive FU540-C000") Signed-off-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-01-12 12:21:50 +01:00
..
Kconfig	net: macb: Kconfig: Rename Atmel to Cadence	2019-06-26 14:09:33 -07:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
macb.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
macb_main.c	macb: Don't unregister clks unconditionally	2020-01-12 12:21:50 +01:00
macb_pci.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 341	2019-06-05 17:37:07 +02:00
macb_ptp.c	net: macb: Fix SUBNS increment and increase resolution	2019-06-29 11:09:18 -07:00