![]() As warned by cppcheck: [drivers/media/dvb-frontends/cx24123.c:434]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/media/pci/bt8xx/bttv-input.c:87]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [drivers/media/pci/bt8xx/bttv-input.c:98]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour ... [drivers/media/v4l2-core/v4l2-ioctl.c:1391]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour There are lots of places where we're doing 1 << 31. That's bad, as, depending on the architecture, this has an undefined behavior. The BIT() macro is already prepared to handle this, so, let's just switch all "1 << number" macros by BIT(number) at the header files with has 1 << 31. Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> # exynos4-is and s3c-camif Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # omap3isp, vsp1, xilinx, wl128x and ipu3 Reviewed-by: Benoit Parrot <bparrot@ti.com> # am437x and ti-vpe Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
||
---|---|---|
.. | ||
ccdc_hw_device.h | ||
dm355_ccdc.c | ||
dm355_ccdc_regs.h | ||
dm644x_ccdc.c | ||
dm644x_ccdc_regs.h | ||
isif.c | ||
isif_regs.h | ||
Kconfig | ||
Makefile | ||
vpbe.c | ||
vpbe_display.c | ||
vpbe_osd.c | ||
vpbe_osd_regs.h | ||
vpbe_venc.c | ||
vpbe_venc_regs.h | ||
vpfe_capture.c | ||
vpif.c | ||
vpif.h | ||
vpif_capture.c | ||
vpif_capture.h | ||
vpif_display.c | ||
vpif_display.h | ||
vpss.c |