Ming Lei 7d4901a90d blk-mq: avoid to map CPU into stale hw queue ... blk_mq_pci_map_queues() may not map one CPU into any hw queue, but its previous map isn't cleared yet, and may point to one stale hw queue index. This patch fixes the following issue by clearing the mapping table before setting it up in blk_mq_pci_map_queues(). This patches fixes this following issue reported by Zhang Yi: [ 101.202734] BUG: unable to handle kernel NULL pointer dereference at 0000000094d3013f [ 101.211487] IP: blk_mq_map_swqueue+0xbc/0x200 [ 101.216346] PGD 0 P4D 0 [ 101.219171] Oops: 0000 [#1] SMP [ 101.222674] Modules linked in: sunrpc ipmi_ssif vfat fat intel_rapl sb_edac x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel intel_cstate intel_uncore mxm_wmi intel_rapl_perf iTCO_wdt ipmi_si ipmi_devintf pcspkr iTCO_vendor_support sg dcdbas ipmi_msghandler wmi mei_me lpc_ich shpchp mei acpi_power_meter dm_multipath ip_tables xfs libcrc32c sd_mod mgag200 i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops ttm drm ahci libahci crc32c_intel libata tg3 nvme nvme_core megaraid_sas ptp i2c_core pps_core dm_mirror dm_region_hash dm_log dm_mod [ 101.284881] CPU: 0 PID: 504 Comm: kworker/u25:5 Not tainted 4.15.0-rc2 #1 [ 101.292455] Hardware name: Dell Inc. PowerEdge R730xd/072T6D, BIOS 2.5.5 08/16/2017 [ 101.301001] Workqueue: nvme-wq nvme_reset_work [nvme] [ 101.306636] task: 00000000f2c53190 task.stack: 000000002da874f9 [ 101.313241] RIP: 0010:blk_mq_map_swqueue+0xbc/0x200 [ 101.318681] RSP: 0018:ffffc9000234fd70 EFLAGS: 00010282 [ 101.324511] RAX: ffff88047ffc9480 RBX: ffff88047e130850 RCX: 0000000000000000 [ 101.332471] RDX: ffffe8ffffd40580 RSI: ffff88047e509b40 RDI: ffff88046f37a008 [ 101.340432] RBP: 000000000000000b R08: ffff88046f37a008 R09: 0000000011f94280 [ 101.348392] R10: ffff88047ffd4d00 R11: 0000000000000000 R12: ffff88046f37a008 [ 101.356353] R13: ffff88047e130f38 R14: 000000000000000b R15: ffff88046f37a558 [ 101.364314] FS: 0000000000000000(0000) GS:ffff880277c00000(0000) knlGS:0000000000000000 [ 101.373342] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 101.379753] CR2: 0000000000000098 CR3: 000000047f409004 CR4: 00000000001606f0 [ 101.387714] Call Trace: [ 101.390445] blk_mq_update_nr_hw_queues+0xbf/0x130 [ 101.395791] nvme_reset_work+0x6f4/0xc06 [nvme] [ 101.400848] ? pick_next_task_fair+0x290/0x5f0 [ 101.405807] ? __switch_to+0x1f5/0x430 [ 101.409988] ? put_prev_entity+0x2f/0xd0 [ 101.414365] process_one_work+0x141/0x340 [ 101.418836] worker_thread+0x47/0x3e0 [ 101.422921] kthread+0xf5/0x130 [ 101.426424] ? rescuer_thread+0x380/0x380 [ 101.430896] ? kthread_associate_blkcg+0x90/0x90 [ 101.436048] ret_from_fork+0x1f/0x30 [ 101.440034] Code: 48 83 3c ca 00 0f 84 2b 01 00 00 48 63 cd 48 8b 93 10 01 00 00 8b 0c 88 48 8b 83 20 01 00 00 4a 03 14 f5 60 04 af 81 48 8b 0c c8 <48> 8b 81 98 00 00 00 f0 4c 0f ab 30 8b 81 f8 00 00 00 89 42 44 [ 101.461116] RIP: blk_mq_map_swqueue+0xbc/0x200 RSP: ffffc9000234fd70 [ 101.468205] CR2: 0000000000000098 [ 101.471907] ---[ end trace 5fe710f98228a3ca ]--- [ 101.482489] Kernel panic - not syncing: Fatal exception [ 101.488505] Kernel Offset: disabled [ 101.497752] ---[ end Kernel panic - not syncing: Fatal exception Reviewed-by: Christoph Hellwig <hch@lst.de> Suggested-by: Christoph Hellwig <hch@lst.de> Reported-by: Yi Zhang <yi.zhang@redhat.com> Tested-by: Yi Zhang <yi.zhang@redhat.com> Signed-off-by: Ming Lei <ming.lei@redhat.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2018-01-06 09:25:36 -07:00
..
partitions	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Kconfig.iosched	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
badblocks.c	badblocks: fix wrong return value in badblocks_set if badblocks are disabled	2017-11-03 11:29:50 -07:00
bfq-cgroup.c	block, bfq: move debug blkio stats behind CONFIG_DEBUG_BLK_CGROUP	2017-11-14 20:13:33 -07:00
bfq-iosched.c	block, bfq: remove batches of confusing ifdefs	2018-01-05 09:32:59 -07:00
bfq-iosched.h	block, bfq: let a queue be merged only shortly after starting I/O	2018-01-05 09:26:09 -07:00
bfq-wf2q.c	block, bfq: let a queue be merged only shortly after starting I/O	2018-01-05 09:26:09 -07:00
bio-integrity.c	block: remove unnecessary NULL checks in bioset_integrity_free()	2017-10-06 13:03:12 -06:00
bio.c	block: move bio_alloc_pages() to bcache	2018-01-06 09:18:00 -07:00
blk-cgroup.c	blkcg: add sanity check for blkcg policy operations	2017-11-04 12:31:15 -06:00
blk-core.c	blk-mq: quiesce queue before freeing queue	2018-01-06 09:25:36 -07:00
blk-exec.c	block: introduce new block status code type	2017-06-09 09:27:32 -06:00
blk-flush.c	blk-mq: don't allocate driver tag upfront for flush rq	2017-11-04 12:40:13 -06:00
blk-integrity.c	block: switch bios to blk_status_t	2017-06-09 09:27:32 -06:00
blk-ioc.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-lib.c	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
blk-map.c	Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-11-17 12:08:18 -08:00
blk-merge.c	block: blk-merge: remove unnecessary check	2018-01-06 09:18:00 -07:00
blk-mq-cpumap.c	blk-mq: map queues to all present CPUs	2017-07-24 10:01:31 -06:00
blk-mq-debugfs.c	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
blk-mq-debugfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-mq-pci.c	blk-mq-pci: add a fallback when pci_irq_get_affinity returns NULL	2017-08-18 08:08:14 -06:00
blk-mq-rdma.c	block: Add rdma affinity based queue mapping helper	2017-08-08 14:58:03 -04:00
blk-mq-sched.c	blk-mq: remove confusing comment of blk_mq_sched_dispatch_requests	2018-01-05 08:36:33 -07:00
blk-mq-sched.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-mq-sysfs.c	blk-mq: untangle debugfs and sysfs	2017-05-04 08:24:13 -06:00
blk-mq-tag.c	blk-mq: improve heavily contended tag case	2017-12-22 11:09:37 -07:00
blk-mq-tag.h	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
blk-mq-virtio.c	blk-mq: provide a default queue mapping for virtio device	2017-02-27 20:54:05 +02:00
blk-mq.c	blk-mq: avoid to map CPU into stale hw queue	2018-01-06 09:25:36 -07:00
blk-mq.h	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
blk-settings.c	block: remove __bio_kmap_atomic	2017-11-10 19:53:25 -07:00
blk-softirq.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-stat.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
blk-stat.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-sysfs.c	blk-sysfs: remove NULL pointer checking in queue_wb_lat_store	2017-11-23 22:00:17 -07:00
blk-tag.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-throttle.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
blk-timeout.c	block: Fix a race between blk_cleanup_queue() and timeout handling	2017-10-30 13:28:10 -06:00
blk-wbt.c	blk-wbt: fix comments typo	2017-11-23 22:00:20 -07:00
blk-wbt.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
blk-zoned.c	block: introduce zoned block devices zone write locking	2018-01-05 09:22:17 -07:00
blk.h	Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block	2017-11-14 15:32:19 -08:00
bounce.c	block: bounce: don't access bio->bi_io_vec in copy_to_high_bio_irq	2018-01-06 09:18:00 -07:00
bsg-lib.c	bsg-lib: fix use-after-free under memory-pressure	2017-10-04 08:35:04 -06:00
bsg.c	block: pass full fmode_t to blk_verify_command	2017-11-10 19:53:25 -07:00
cfq-iosched.c	block/cfq: cache rightmost rb_node	2017-09-08 18:26:49 -07:00
cmdline-parser.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
compat_ioctl.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
deadline-iosched.c	deadline-iosched: Introduce zone locking support	2018-01-05 09:22:17 -07:00
elevator.c	blk-mq: quiesce queue during switching io sched and updating nr_requests	2018-01-06 09:25:36 -07:00
genhd.c	block: genhd.c: fix message typo	2017-11-19 11:02:19 -07:00
ioctl.c	block: move CAP_SYS_ADMIN check in blkdev_roset()	2017-10-25 12:25:00 -06:00
ioprio.c	block: Add fallthrough markers to switch statements	2017-06-21 11:46:07 -06:00
kyber-iosched.c	block: kyber: check if there are requests in ctx in kyber_has_work()	2017-11-01 08:20:02 -06:00
mq-deadline.c	mq-deadline: make it clear that __dd_dispatch_request() works on all hw queues	2018-01-06 09:23:11 -07:00
noop-iosched.c	block: move existing elevator ops to union	2017-01-17 10:03:33 -07:00
opal_proto.h	block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled	2017-09-11 09:45:52 -06:00
partition-generic.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
scsi_ioctl.c	block: pass full fmode_t to blk_verify_command	2017-11-10 19:53:25 -07:00
sed-opal.c	block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled	2017-09-11 09:45:52 -06:00
t10-pi.c	t10-pi: Move opencoded contants to common header	2017-07-03 16:56:25 -06:00