1
0
Fork 0
alistair23-linux/drivers/net/ethernet/renesas
Geert Uytterhoeven 0ff55fc4d6 sh_eth: Fix power down vs. is_opened flag ordering
commit f6a2e94b3f upstream.

sh_eth_close() does a synchronous power down of the device before
marking it closed.  Revert the order, to make sure the device is never
marked opened while suspended.

While at it, use pm_runtime_put() instead of pm_runtime_put_sync(), as
there is no reason to do a synchronous power down.

Fixes: 7fa2955ff7 ("sh_eth: Fix sleeping function called from invalid context")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20210118150812.796791-1-geert+renesas@glider.be
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-01-27 11:47:52 +01:00
..
Kconfig ethernet: renesas: convert to SPDX identifiers 2018-09-10 10:11:53 -07:00
Makefile ethernet: renesas: convert to SPDX identifiers 2018-09-10 10:11:53 -07:00
ravb.h ravb: implement MTU change while device is up 2019-11-14 18:05:25 -08:00
ravb_main.c ravb: Fix bit fields checking in ravb_hwtstamp_get() 2020-11-01 12:01:04 +01:00
ravb_ptp.c ptp: Introduce strict checking of external time stamp options. 2019-11-15 12:48:32 -08:00
sh_eth.c sh_eth: Fix power down vs. is_opened flag ordering 2021-01-27 11:47:52 +01:00
sh_eth.h sh_eth: RX checksum offload support 2019-02-04 13:31:00 -08:00