8cdb46da06
Since (69b34fb netfilter: xt_LOG: add net namespace support
for xt_LOG), we hit this:
[ 4224.708977] BUG: unable to handle kernel NULL pointer dereference at 0000000000000388
[ 4224.709074] IP: [<ffffffff8147f699>] ipt_log_packet+0x29/0x270
when callling log functions from conntrack both in and out
are NULL i.e. the net pointer is invalid.
Adding struct net *net in call to nf_logfn() will secure that
there always is a vaild net ptr.
Reported as netfilter's bugzilla bug 818:
https://bugzilla.netfilter.org/show_bug.cgi?id=818
Reported-by: Ronald <ronald645@gmail.com>
Signed-off-by: Hans Schillstrom <hans@schillstrom.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
74 lines
1.9 KiB
C
74 lines
1.9 KiB
C
/*
|
|
* Copyright (c) 2006 Patrick McHardy <kaber@trash.net>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/skbuff.h>
|
|
|
|
#include <linux/netfilter/x_tables.h>
|
|
#include <linux/netfilter/xt_NFLOG.h>
|
|
#include <net/netfilter/nf_log.h>
|
|
#include <net/netfilter/nfnetlink_log.h>
|
|
|
|
MODULE_AUTHOR("Patrick McHardy <kaber@trash.net>");
|
|
MODULE_DESCRIPTION("Xtables: packet logging to netlink using NFLOG");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("ipt_NFLOG");
|
|
MODULE_ALIAS("ip6t_NFLOG");
|
|
|
|
static unsigned int
|
|
nflog_tg(struct sk_buff *skb, const struct xt_action_param *par)
|
|
{
|
|
const struct xt_nflog_info *info = par->targinfo;
|
|
struct nf_loginfo li;
|
|
struct net *net = dev_net(par->in ? par->in : par->out);
|
|
|
|
li.type = NF_LOG_TYPE_ULOG;
|
|
li.u.ulog.copy_len = info->len;
|
|
li.u.ulog.group = info->group;
|
|
li.u.ulog.qthreshold = info->threshold;
|
|
|
|
nfulnl_log_packet(net, par->family, par->hooknum, skb, par->in,
|
|
par->out, &li, info->prefix);
|
|
return XT_CONTINUE;
|
|
}
|
|
|
|
static int nflog_tg_check(const struct xt_tgchk_param *par)
|
|
{
|
|
const struct xt_nflog_info *info = par->targinfo;
|
|
|
|
if (info->flags & ~XT_NFLOG_MASK)
|
|
return -EINVAL;
|
|
if (info->prefix[sizeof(info->prefix) - 1] != '\0')
|
|
return -EINVAL;
|
|
return 0;
|
|
}
|
|
|
|
static struct xt_target nflog_tg_reg __read_mostly = {
|
|
.name = "NFLOG",
|
|
.revision = 0,
|
|
.family = NFPROTO_UNSPEC,
|
|
.checkentry = nflog_tg_check,
|
|
.target = nflog_tg,
|
|
.targetsize = sizeof(struct xt_nflog_info),
|
|
.me = THIS_MODULE,
|
|
};
|
|
|
|
static int __init nflog_tg_init(void)
|
|
{
|
|
return xt_register_target(&nflog_tg_reg);
|
|
}
|
|
|
|
static void __exit nflog_tg_exit(void)
|
|
{
|
|
xt_unregister_target(&nflog_tg_reg);
|
|
}
|
|
|
|
module_init(nflog_tg_init);
|
|
module_exit(nflog_tg_exit);
|