![Robert Richter](/assets/img/avatar_default.png)
The default input file for perf report is not handled the same way as perf record does it for its output file. This leads to unexpected behavior of perf report, etc. E.g.: # perf record -a -e cpu-cycles sleep 2 | perf report | cat failed to open perf.data: No such file or directory (try 'perf record' first) While perf record writes to a fifo, perf report expects perf.data to be read. This patch changes this to accept fifos as input file. Applies to the following commands: perf annotate perf buildid-list perf evlist perf kmem perf lock perf report perf sched perf script perf timechart Also fixes char const* -> const char* type declaration for filename strings. v2: * Prevent potential null pointer access to input_name in builtin-report.c. Needed due to removal of patch "perf report: Setup browser if stdout is a pipe" Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1323248577-11268-5-git-send-email-robert.richter@amd.com Signed-off-by: Robert Richter <robert.richter@amd.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
55 lines
1.1 KiB
C
55 lines
1.1 KiB
C
/*
|
|
* Builtin evlist command: Show the list of event selectors present
|
|
* in a perf.data file.
|
|
*/
|
|
#include "builtin.h"
|
|
|
|
#include "util/util.h"
|
|
|
|
#include <linux/list.h>
|
|
|
|
#include "perf.h"
|
|
#include "util/evlist.h"
|
|
#include "util/evsel.h"
|
|
#include "util/parse-events.h"
|
|
#include "util/parse-options.h"
|
|
#include "util/session.h"
|
|
|
|
static const char *input_name;
|
|
|
|
static int __cmd_evlist(void)
|
|
{
|
|
struct perf_session *session;
|
|
struct perf_evsel *pos;
|
|
|
|
session = perf_session__new(input_name, O_RDONLY, 0, false, NULL);
|
|
if (session == NULL)
|
|
return -ENOMEM;
|
|
|
|
list_for_each_entry(pos, &session->evlist->entries, node)
|
|
printf("%s\n", event_name(pos));
|
|
|
|
perf_session__delete(session);
|
|
return 0;
|
|
}
|
|
|
|
static const char * const evlist_usage[] = {
|
|
"perf evlist [<options>]",
|
|
NULL
|
|
};
|
|
|
|
static const struct option options[] = {
|
|
OPT_STRING('i', "input", &input_name, "file",
|
|
"input file name"),
|
|
OPT_END()
|
|
};
|
|
|
|
int cmd_evlist(int argc, const char **argv, const char *prefix __used)
|
|
{
|
|
argc = parse_options(argc, argv, options, evlist_usage, 0);
|
|
if (argc)
|
|
usage_with_options(evlist_usage, options);
|
|
|
|
return __cmd_evlist();
|
|
}
|