1
0
Fork 0
alistair23-linux/drivers/net/dsa/b53
Tom Rix dafae06888 net: dsa: b53: check for timeout
[ Upstream commit 774d977abf ]

clang static analysis reports this problem

b53_common.c:1583:13: warning: The left expression of the compound
  assignment is an uninitialized value. The computed value will
  also be garbage
        ent.port &= ~BIT(port);
        ~~~~~~~~ ^

ent is set by a successful call to b53_arl_read().  Unsuccessful
calls are caught by an switch statement handling specific returns.
b32_arl_read() calls b53_arl_op_wait() which fails with the
unhandled -ETIMEDOUT.

So add -ETIMEDOUT to the switch statement.  Because
b53_arl_op_wait() already prints out a message, do not add another
one.

Fixes: 1da6df85c6 ("net: dsa: b53: Implement ARL add/del/dump operations")
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-26 10:41:06 +02:00
..
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile net: dsa: b53: Add SerDes support 2018-09-06 07:48:34 -07:00
b53_common.c net: dsa: b53: check for timeout 2020-08-26 10:41:06 +02:00
b53_mdio.c net: dsa: b53: Add BCM5389 support 2018-06-01 11:15:42 -04:00
b53_mmap.c net: dsa: b53: Fix sparse warnings in b53_mmap.c 2018-04-04 11:15:27 -04:00
b53_priv.h net: dsa: b53: Add support for port_egress_floods callback 2019-09-16 09:06:12 +02:00
b53_regs.h net: dsa: b53: b53_arl_rw_op() needs to select IVL or SVL 2020-04-29 16:33:11 +02:00
b53_serdes.c net: dsa: b53: Don't assign autonegotiation enabled 2018-09-21 19:57:03 -07:00
b53_serdes.h net: dsa: b53: Use the correct style for SPDX License Identifier 2019-09-22 15:24:51 -07:00
b53_spi.c net: dsa: b53: remove .owner and .bus fields for driver 2016-08-14 21:24:25 -07:00
b53_srab.c net: dsa: b53: use devm_platform_ioremap_resource() to simplify code 2019-08-01 13:10:34 -04:00