1
0
Fork 0
alistair23-linux/drivers/net/ethernet
Rasmus Villemoes 887078de2a ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram
Table 8-53 in the QUICC Engine Reference manual shows definitions of
fields up to a size of 192 bytes, not just 128. But in table 8-111,
one does find the text

  Base Address of the Global Transmitter Parameter RAM Page. [...]
  The user needs to allocate 128 bytes for this page. The address must
  be aligned to the page size.

I've checked both rev. 7 (11/2015) and rev. 9 (05/2018) of the manual;
they both have this inconsistency (and the table numbers are the
same).

Adding a bit of debug printing, on my board the struct
ucc_geth_tx_global_pram is allocated at offset 0x880, while
the (opaque) ucc_geth_thread_data_tx gets allocated immediately
afterwards, at 0x900. So whatever the engine writes into the thread
data overlaps with the tail of the global tx pram (and devmem says
that something does get written during a simple ping).

I haven't observed any failure that could be attributed to this, but
it seems to be the kind of thing that would be extremely hard to
debug. So extend the struct definition so that we do allocate 192
bytes.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-12-21 17:24:19 -08:00
..
3com networking changes for the 5.10 merge window 2020-10-15 18:42:13 -07:00
8390 ne2k: Fix Typo in RW-Bugfix 2020-10-31 16:17:02 -07:00
adaptec
aeroflex
agere ethernet: select CONFIG_CRC32 as needed 2020-12-04 14:42:21 -08:00
alacritech
allwinner net: allwinner: Fix some resources leak in the error handling path of the probe and in the remove function 2020-12-16 11:37:31 -08:00
alteon
altera
amazon net: ena: introduce ndo_xdp_xmit() function for XDP_REDIRECT 2020-12-09 15:26:40 -08:00
amd net: remove am79c961a driver 2020-10-30 21:57:03 +01:00
apm
apple
aquantia Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-11-27 18:25:27 -08:00
arc
atheros net: atheros: simplify the return expression of atl2_phy_setup_autoneg_adv() 2020-12-08 16:22:54 -08:00
aurora
broadcom net: systemport: set dev->max_mtu to UMAC_MAX_MTU_SIZE 2020-12-21 15:39:47 -08:00
brocade net: bna: remove trailing semicolon in macro definition 2020-12-04 17:41:49 -08:00
cadence Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-12-11 22:29:38 -08:00
calxeda drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
cavium Networking updates for 5.11 2020-12-15 13:22:29 -08:00
chelsio selinux/stable-5.11 PR 20201214 2020-12-16 11:01:04 -08:00
cirrus
cisco net: cisco: enic: simplify the return vnic_cq_alloc() 2020-12-09 17:05:37 -08:00
cortina drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
davicom drivers: net: davicom Add COMPILE_TEST support 2020-11-02 15:52:22 -08:00
dec drivers: net: tulip: Fix set but not used with W=1 2020-11-02 15:50:04 -08:00
dlink
emulex net: emulex: benet: simplify the return expression of be_if_create() 2020-12-09 17:05:36 -08:00
ezchip
faraday Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-12-11 22:29:38 -08:00
freescale ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram 2020-12-21 17:24:19 -08:00
fujitsu
google gve: Add support for raw addressing in the tx path 2020-12-08 16:06:28 -08:00
hisilicon net: hns3: fix expression that is currently always true 2020-12-14 19:42:49 -08:00
huawei net: hinic: simplify the return hinic_configure_max_qnum() 2020-12-09 17:05:37 -08:00
i825xx
ibm use __netdev_notify_peers in ibmvnic 2020-12-16 11:43:26 -08:00
intel iavf: fix double-release of rtnl_lock 2020-12-17 14:12:55 -08:00
marvell net: mvpp2: prs: fix PPPoE with ipv6 packet parse 2020-12-19 10:14:28 -08:00
mediatek net: mtk_eth: simplify the mediatek code return expression 2020-12-14 17:51:26 -08:00
mellanox mlxsw: spectrum_router: Use eXtended mezzanine to offload IPv4 router 2020-12-14 19:09:55 -08:00
micrel net: micrel: convert comma to semicolon 2020-12-09 16:23:08 -08:00
microchip lan743x: fix rx_napi_poll/interrupt ping-pong 2020-12-16 09:00:09 -08:00
moxa
mscc net: mscc: ocelot: Fix a resource leak in the error handling path of the probe function 2020-12-16 11:11:24 -08:00
myricom
natsemi net: natsemi: Replace in_interrupt() usage. 2020-09-29 14:02:54 -07:00
neterion net: vxget: clean up sparse warnings 2020-12-14 19:18:11 -08:00
netronome nfp: move indirect block cleanup to flower app stop callback 2020-12-17 10:57:57 -08:00
ni net: nixge: fix spelling mistake in Kconfig: "Instuments" -> "Instruments" 2020-12-17 10:54:31 -08:00
nvidia forcedeth: fix excluded_middle.cocci warnings 2020-11-03 17:47:04 -08:00
nxp ethernet: select CONFIG_CRC32 as needed 2020-12-04 14:42:21 -08:00
oki-semi net: pch_gbe: Use 'dma_free_coherent()' to undo 'dma_alloc_coherent()' 2020-11-23 17:01:48 -08:00
packetengines drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
pasemi net: pasemi: fix error return code in pasemi_mac_open() 2020-12-02 18:03:58 -08:00
pensando drivers: net: ionic: simplify the return expression of ionic_set_rxfh() 2020-12-08 16:22:54 -08:00
qlogic qlcnic: Fix error code in probe 2020-12-17 10:53:33 -08:00
qualcomm net: qualcomm: rmnet: Update rmnet device MTU based on real device 2020-12-10 13:30:26 -08:00
rdc
realtek r8169: make NUM_RX_DESC a signed int 2020-12-05 16:29:21 -08:00
renesas ravb: Fix bit fields checking in ravb_hwtstamp_get() 2020-10-27 17:14:33 -07:00
rocker ethernet: select CONFIG_CRC32 as needed 2020-12-04 14:42:21 -08:00
samsung drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
seeq
sfc xsk: Propagate napi_id to XDP socket Rx path 2020-12-01 00:09:25 +01:00
sgi
silan
sis drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
smsc drivers: net: smsc: Add COMPILE_TEST support 2020-11-12 14:49:40 -08:00
socionext Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next 2020-12-04 07:48:12 -08:00
stmicro Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-12-11 22:29:38 -08:00
sun networking changes for the 5.10 merge window 2020-10-15 18:42:13 -07:00
synopsys
tehuti drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
ti Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-12-11 22:29:38 -08:00
toshiba powerpc/ps3: make system bus's remove and shutdown callbacks return void 2020-12-04 01:01:22 +11:00
tundra
via Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-10-05 18:40:01 -07:00
wiznet
xilinx Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2020-12-11 22:29:38 -08:00
xircom
xscale
Kconfig
Makefile
dnet.c
dnet.h
ec_bhf.c
ethoc.c drivers/net/ethernet: clean up mis-targeted comments 2020-09-25 16:29:00 -07:00
fealnx.c
jme.c
jme.h
korina.c net: korina: fix return value 2020-12-16 15:01:07 -08:00
lantiq_etop.c
lantiq_xrx200.c