4c42d97981
Functions like devm_kzalloc, kmalloc_array, devm_ioremap,
usb_alloc_urb, alloc_netdev return NULL as a return value on failure.
Generally, When NULL represents failure, !x is commonly used.
This patch cleans up the tests on the results of these functions, thereby
using !x instead of x == NULL or NULL == x. This is done via following
coccinelle script:
@prob_7@
identifier x;
statement S;
@@
(
x = devm_kzalloc(...);
|
x = usb_alloc_urb(...);
|
x = kmalloc_array(...);
|
x = devm_ioremap(...);
|
x = alloc_netdev(...);
)
...
- if(NULL == x)
+ if(!x)
S
Further we have used isomorphism characteristics of coccinelle to
indicate x == NULL and NULL == x are equivalent. This is done via
following iso script.
Expression
@ is_null @ expression X; @@
X == NULL <=> NULL == X
Signed-off-by: Somya Anand <somyaanand214@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
99 lines
2.2 KiB
C
99 lines
2.2 KiB
C
/*
|
|
* nvec_paz00: OEM specific driver for Compal PAZ00 based devices
|
|
*
|
|
* Copyright (C) 2011 The AC100 Kernel Team <ac100@lists.launchpad.net>
|
|
*
|
|
* Authors: Ilya Petrov <ilya.muromec@gmail.com>
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file "COPYING" in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/err.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/leds.h>
|
|
#include <linux/platform_device.h>
|
|
#include "nvec.h"
|
|
|
|
#define to_nvec_led(led_cdev) \
|
|
container_of(led_cdev, struct nvec_led, cdev)
|
|
|
|
#define NVEC_LED_REQ {'\x0d', '\x10', '\x45', '\x10', '\x00'}
|
|
|
|
#define NVEC_LED_MAX 8
|
|
|
|
struct nvec_led {
|
|
struct led_classdev cdev;
|
|
struct nvec_chip *nvec;
|
|
};
|
|
|
|
static void nvec_led_brightness_set(struct led_classdev *led_cdev,
|
|
enum led_brightness value)
|
|
{
|
|
struct nvec_led *led = to_nvec_led(led_cdev);
|
|
unsigned char buf[] = NVEC_LED_REQ;
|
|
|
|
buf[4] = value;
|
|
|
|
nvec_write_async(led->nvec, buf, sizeof(buf));
|
|
|
|
led->cdev.brightness = value;
|
|
|
|
}
|
|
|
|
static int nvec_paz00_probe(struct platform_device *pdev)
|
|
{
|
|
struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);
|
|
struct nvec_led *led;
|
|
int ret = 0;
|
|
|
|
led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
|
|
if (!led)
|
|
return -ENOMEM;
|
|
|
|
led->cdev.max_brightness = NVEC_LED_MAX;
|
|
|
|
led->cdev.brightness_set = nvec_led_brightness_set;
|
|
led->cdev.name = "paz00-led";
|
|
led->cdev.flags |= LED_CORE_SUSPENDRESUME;
|
|
led->nvec = nvec;
|
|
|
|
platform_set_drvdata(pdev, led);
|
|
|
|
ret = led_classdev_register(&pdev->dev, &led->cdev);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
/* to expose the default value to userspace */
|
|
led->cdev.brightness = 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int nvec_paz00_remove(struct platform_device *pdev)
|
|
{
|
|
struct nvec_led *led = platform_get_drvdata(pdev);
|
|
|
|
led_classdev_unregister(&led->cdev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver nvec_paz00_driver = {
|
|
.probe = nvec_paz00_probe,
|
|
.remove = nvec_paz00_remove,
|
|
.driver = {
|
|
.name = "nvec-paz00",
|
|
},
|
|
};
|
|
|
|
module_platform_driver(nvec_paz00_driver);
|
|
|
|
MODULE_AUTHOR("Ilya Petrov <ilya.muromec@gmail.com>");
|
|
MODULE_DESCRIPTION("Tegra NVEC PAZ00 driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:nvec-paz00");
|