b4ac5afc6b
Having provided for_each_engine_id() for cases where the third (id)
argument is useful, we can now replace all the remaining instances with
a simpler version that takes only two parameters. In many cases, this
also allows the elimination of the local variable used in the iterator
(usually 'i').
v2:
s/dev_priv/(dev_priv__)/ in body of for_each_engine_masked() [Chris Wilson]
Signed-off-by: Dave Gordon <david.s.gordon@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1458757194-17783-2-git-send-email-david.s.gordon@intel.com
71 lines
2.2 KiB
C
71 lines
2.2 KiB
C
/*
|
|
* Copyright © 2008 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
* Keith Packard <keithp@keithp.com>
|
|
*
|
|
*/
|
|
|
|
#include <drm/drmP.h>
|
|
#include <drm/i915_drm.h>
|
|
#include "i915_drv.h"
|
|
|
|
#if WATCH_LISTS
|
|
int
|
|
i915_verify_lists(struct drm_device *dev)
|
|
{
|
|
static int warned;
|
|
struct drm_i915_private *dev_priv = to_i915(dev);
|
|
struct drm_i915_gem_object *obj;
|
|
struct intel_engine_cs *engine;
|
|
int err = 0;
|
|
|
|
if (warned)
|
|
return 0;
|
|
|
|
for_each_engine(engine, dev_priv) {
|
|
list_for_each_entry(obj, &engine->active_list,
|
|
engine_list[engine->id]) {
|
|
if (obj->base.dev != dev ||
|
|
!atomic_read(&obj->base.refcount.refcount)) {
|
|
DRM_ERROR("%s: freed active obj %p\n",
|
|
engine->name, obj);
|
|
err++;
|
|
break;
|
|
} else if (!obj->active ||
|
|
obj->last_read_req[engine->id] == NULL) {
|
|
DRM_ERROR("%s: invalid active obj %p\n",
|
|
engine->name, obj);
|
|
err++;
|
|
} else if (obj->base.write_domain) {
|
|
DRM_ERROR("%s: invalid write obj %p (w %x)\n",
|
|
engine->name,
|
|
obj, obj->base.write_domain);
|
|
err++;
|
|
}
|
|
}
|
|
}
|
|
|
|
return warned = err;
|
|
}
|
|
#endif /* WATCH_LIST */
|