1
0
Fork 0
alistair23-linux/arch/openrisc/mm
Jonas Bonn 8668480eb7 openrisc: update DTLB-miss handler last
The self-modifying code that updates the TLB handler at start-up has
a subtle ordering requirement:  the DTLB handler must be the last thing
changed.

What I was seeing was the following:

i)   The DTLB handler was updated
ii)  The following printk caused a TLB miss and the look-up resulted
     in the page containing itlb_vector (0xc0000a00) being bounced from
     the TLB.
iii) The subsequent access to itlb_vector caused a TLB miss and reload
     of the page containing itlb_vector from the page tables.
iv)  But this reload of the page in iii) was being done by the "new"
     DTLB-miss handler which resulted (correctly) in the page flags being
     set to read-only; the subsequent write-access to itlb_vector thus
     resulted in a page (access) fault.

This is easily remedied if we ensure that the boot-time DTLB-miss handler
continues running until the very last bit of self-modifying code has been
executed.  This patch should ensure that the very last thing updated is the
DTLB-handler itself.

Signed-off-by: Jonas Bonn <jonas@southpole.se>
Acked-by: Julius Baxter <juliusbaxter@gmail.com>
Tested-by: Sebastian Macke <sebastian@macke.de>
2013-02-17 08:46:10 +01:00
..
Makefile OpenRISC: Build infrastructure 2011-07-22 18:46:30 +02:00
fault.c readahead: fault retry breaks mmap file read random detection 2012-10-09 16:22:47 +09:00
init.c openrisc: update DTLB-miss handler last 2013-02-17 08:46:10 +01:00
ioremap.c OpenRISC: Memory management 2011-07-22 18:46:28 +02:00
tlb.c Disintegrate asm/system.h for OpenRISC 2012-03-28 18:30:03 +01:00