![Paul Gortmaker](/assets/img/avatar_default.png)
The __cpuinit type of throwaway sections might have made sense
some time ago when RAM was more constrained, but now the savings
do not offset the cost and complications. For example, the fix in
commit 5e427ec2d0
("x86: Fix bit corruption at CPU resume time")
is a good example of the nasty type of bugs that can be created
with improper use of the various __init prefixes.
After a discussion on LKML[1] it was decided that cpuinit should go
the way of devinit and be phased out. Once all the users are gone,
we can then finally remove the macros themselves from linux/init.h.
Note that some harmless section mismatch warnings may result, since
notify_cpu_starting() and cpu_up() are arch independent (kernel/cpu.c)
and are flagged as __cpuinit -- so if we remove the __cpuinit from
the arch specific callers, we will also get section mismatch warnings.
As an intermediate step, we intend to turn the linux/init.h cpuinit
related content into no-ops as early as possible, since that will get
rid of these warnings. In any case, they are temporary and harmless.
This removes all the ARM uses of the __cpuinit macros from C code,
and all __CPUINIT from assembly code. It also had two ".previous"
section statements that were paired off against __CPUINIT
(aka .section ".cpuinit.text") that also get removed here.
[1] https://lkml.org/lkml/2013/5/20/589
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Will Deacon <will.deacon@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
41 lines
1.2 KiB
C
41 lines
1.2 KiB
C
/*
|
|
* This file contains common function prototypes to avoid externs
|
|
* in the c files.
|
|
*
|
|
* Copyright (C) 2011 Xilinx
|
|
*
|
|
* This software is licensed under the terms of the GNU General Public
|
|
* License version 2, as published by the Free Software Foundation, and
|
|
* may be copied, distributed, and modified under those terms.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#ifndef __MACH_ZYNQ_COMMON_H__
|
|
#define __MACH_ZYNQ_COMMON_H__
|
|
|
|
extern int zynq_slcr_init(void);
|
|
extern void zynq_slcr_system_reset(void);
|
|
extern void zynq_slcr_cpu_stop(int cpu);
|
|
extern void zynq_slcr_cpu_start(int cpu);
|
|
|
|
#ifdef CONFIG_SMP
|
|
extern void secondary_startup(void);
|
|
extern char zynq_secondary_trampoline;
|
|
extern char zynq_secondary_trampoline_jump;
|
|
extern char zynq_secondary_trampoline_end;
|
|
extern int zynq_cpun_start(u32 address, int cpu);
|
|
extern struct smp_operations zynq_smp_ops __initdata;
|
|
#endif
|
|
|
|
extern void __iomem *zynq_slcr_base;
|
|
extern void __iomem *zynq_scu_base;
|
|
|
|
/* Hotplug */
|
|
extern void zynq_platform_cpu_die(unsigned int cpu);
|
|
|
|
#endif
|