alistair23-linux/fs/fat
OGAWA Hirofumi 9183482f5d fat: Fix ATTR_RO in the case of (~umask & S_WUGO) == 0
If inode->i_mode doesn't have S_WUGO, current code assumes it means
ATTR_RO.  However, if (~[ufd]mask & S_WUGO) == 0, inode->i_mode can't
hold S_WUGO. Therefore the updated directory entry will always have
ATTR_RO.

This adds fat_mode_can_hold_ro() to check it. And if inode->i_mode
can't hold, uses -i_attrs to hold ATTR_RO instead.

With this, we don't set ATTR_RO unless users change it via ioctl() if
(~[ufd]mask & S_WUGO) == 0.

And on FAT_IOCTL_GET_ATTRIBUTES path, this adds ->i_mutex to it for
not returning the partially updated attributes by FAT_IOCTL_SET_ATTRIBUTES
to userland.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-11-06 15:41:21 -08:00
..
cache.c fat: split include/msdos_fs.h 2008-11-06 15:41:20 -08:00
dir.c fat: cleanup fat_parse_long() error handling 2008-11-06 15:41:20 -08:00
fat.h fat: Fix ATTR_RO in the case of (~umask & S_WUGO) == 0 2008-11-06 15:41:21 -08:00
fatent.c fat: Fix fat_ent_update_ptr() for FAT12 2008-11-06 15:41:20 -08:00
file.c fat: Fix ATTR_RO in the case of (~umask & S_WUGO) == 0 2008-11-06 15:41:21 -08:00
inode.c fat: Cleanup FAT attribute stuff 2008-11-06 15:41:21 -08:00
Makefile fat: move fs/vfat/* and fs/msdos/* to fs/fat 2008-11-06 15:41:20 -08:00
misc.c fat: Fix and cleanup timestamp conversion 2008-11-06 15:41:20 -08:00
namei_msdos.c fat: Cleanup msdos_lookup() 2008-11-06 15:41:21 -08:00
namei_vfat.c fat: Kill d_invalidate() in vfat_lookup() 2008-11-06 15:41:21 -08:00