1a91a36aba
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20200226223125.GA20630@embeddedor
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
177 lines
5.4 KiB
C
177 lines
5.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* include/linux/mmc/sdio_func.h
|
|
*
|
|
* Copyright 2007-2008 Pierre Ossman
|
|
*/
|
|
|
|
#ifndef LINUX_MMC_SDIO_FUNC_H
|
|
#define LINUX_MMC_SDIO_FUNC_H
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/mod_devicetable.h>
|
|
|
|
#include <linux/mmc/pm.h>
|
|
|
|
struct mmc_card;
|
|
struct sdio_func;
|
|
|
|
typedef void (sdio_irq_handler_t)(struct sdio_func *);
|
|
|
|
/*
|
|
* SDIO function CIS tuple (unknown to the core)
|
|
*/
|
|
struct sdio_func_tuple {
|
|
struct sdio_func_tuple *next;
|
|
unsigned char code;
|
|
unsigned char size;
|
|
unsigned char data[];
|
|
};
|
|
|
|
/*
|
|
* SDIO function devices
|
|
*/
|
|
struct sdio_func {
|
|
struct mmc_card *card; /* the card this device belongs to */
|
|
struct device dev; /* the device */
|
|
sdio_irq_handler_t *irq_handler; /* IRQ callback */
|
|
unsigned int num; /* function number */
|
|
|
|
unsigned char class; /* standard interface class */
|
|
unsigned short vendor; /* vendor id */
|
|
unsigned short device; /* device id */
|
|
|
|
unsigned max_blksize; /* maximum block size */
|
|
unsigned cur_blksize; /* current block size */
|
|
|
|
unsigned enable_timeout; /* max enable timeout in msec */
|
|
|
|
unsigned int state; /* function state */
|
|
#define SDIO_STATE_PRESENT (1<<0) /* present in sysfs */
|
|
|
|
u8 *tmpbuf; /* DMA:able scratch buffer */
|
|
|
|
unsigned num_info; /* number of info strings */
|
|
const char **info; /* info strings */
|
|
|
|
struct sdio_func_tuple *tuples;
|
|
};
|
|
|
|
#define sdio_func_present(f) ((f)->state & SDIO_STATE_PRESENT)
|
|
|
|
#define sdio_func_set_present(f) ((f)->state |= SDIO_STATE_PRESENT)
|
|
|
|
#define sdio_func_id(f) (dev_name(&(f)->dev))
|
|
|
|
#define sdio_get_drvdata(f) dev_get_drvdata(&(f)->dev)
|
|
#define sdio_set_drvdata(f,d) dev_set_drvdata(&(f)->dev, d)
|
|
#define dev_to_sdio_func(d) container_of(d, struct sdio_func, dev)
|
|
|
|
/*
|
|
* SDIO function device driver
|
|
*/
|
|
struct sdio_driver {
|
|
char *name;
|
|
const struct sdio_device_id *id_table;
|
|
|
|
int (*probe)(struct sdio_func *, const struct sdio_device_id *);
|
|
void (*remove)(struct sdio_func *);
|
|
|
|
struct device_driver drv;
|
|
};
|
|
|
|
/**
|
|
* SDIO_DEVICE - macro used to describe a specific SDIO device
|
|
* @vend: the 16 bit manufacturer code
|
|
* @dev: the 16 bit function id
|
|
*
|
|
* This macro is used to create a struct sdio_device_id that matches a
|
|
* specific device. The class field will be set to SDIO_ANY_ID.
|
|
*/
|
|
#define SDIO_DEVICE(vend,dev) \
|
|
.class = SDIO_ANY_ID, \
|
|
.vendor = (vend), .device = (dev)
|
|
|
|
/**
|
|
* SDIO_DEVICE_CLASS - macro used to describe a specific SDIO device class
|
|
* @dev_class: the 8 bit standard interface code
|
|
*
|
|
* This macro is used to create a struct sdio_device_id that matches a
|
|
* specific standard SDIO function type. The vendor and device fields will
|
|
* be set to SDIO_ANY_ID.
|
|
*/
|
|
#define SDIO_DEVICE_CLASS(dev_class) \
|
|
.class = (dev_class), \
|
|
.vendor = SDIO_ANY_ID, .device = SDIO_ANY_ID
|
|
|
|
extern int sdio_register_driver(struct sdio_driver *);
|
|
extern void sdio_unregister_driver(struct sdio_driver *);
|
|
|
|
/**
|
|
* module_sdio_driver() - Helper macro for registering a SDIO driver
|
|
* @__sdio_driver: sdio_driver struct
|
|
*
|
|
* Helper macro for SDIO drivers which do not do anything special in module
|
|
* init/exit. This eliminates a lot of boilerplate. Each module may only
|
|
* use this macro once, and calling it replaces module_init() and module_exit()
|
|
*/
|
|
#define module_sdio_driver(__sdio_driver) \
|
|
module_driver(__sdio_driver, sdio_register_driver, \
|
|
sdio_unregister_driver)
|
|
|
|
/*
|
|
* SDIO I/O operations
|
|
*/
|
|
extern void sdio_claim_host(struct sdio_func *func);
|
|
extern void sdio_release_host(struct sdio_func *func);
|
|
|
|
extern int sdio_enable_func(struct sdio_func *func);
|
|
extern int sdio_disable_func(struct sdio_func *func);
|
|
|
|
extern int sdio_set_block_size(struct sdio_func *func, unsigned blksz);
|
|
|
|
extern int sdio_claim_irq(struct sdio_func *func, sdio_irq_handler_t *handler);
|
|
extern int sdio_release_irq(struct sdio_func *func);
|
|
|
|
extern unsigned int sdio_align_size(struct sdio_func *func, unsigned int sz);
|
|
|
|
extern u8 sdio_readb(struct sdio_func *func, unsigned int addr, int *err_ret);
|
|
extern u16 sdio_readw(struct sdio_func *func, unsigned int addr, int *err_ret);
|
|
extern u32 sdio_readl(struct sdio_func *func, unsigned int addr, int *err_ret);
|
|
|
|
extern int sdio_memcpy_fromio(struct sdio_func *func, void *dst,
|
|
unsigned int addr, int count);
|
|
extern int sdio_readsb(struct sdio_func *func, void *dst,
|
|
unsigned int addr, int count);
|
|
|
|
extern void sdio_writeb(struct sdio_func *func, u8 b,
|
|
unsigned int addr, int *err_ret);
|
|
extern void sdio_writew(struct sdio_func *func, u16 b,
|
|
unsigned int addr, int *err_ret);
|
|
extern void sdio_writel(struct sdio_func *func, u32 b,
|
|
unsigned int addr, int *err_ret);
|
|
|
|
extern u8 sdio_writeb_readb(struct sdio_func *func, u8 write_byte,
|
|
unsigned int addr, int *err_ret);
|
|
|
|
extern int sdio_memcpy_toio(struct sdio_func *func, unsigned int addr,
|
|
void *src, int count);
|
|
extern int sdio_writesb(struct sdio_func *func, unsigned int addr,
|
|
void *src, int count);
|
|
|
|
extern unsigned char sdio_f0_readb(struct sdio_func *func,
|
|
unsigned int addr, int *err_ret);
|
|
extern void sdio_f0_writeb(struct sdio_func *func, unsigned char b,
|
|
unsigned int addr, int *err_ret);
|
|
|
|
extern mmc_pm_flag_t sdio_get_host_pm_caps(struct sdio_func *func);
|
|
extern int sdio_set_host_pm_flags(struct sdio_func *func, mmc_pm_flag_t flags);
|
|
|
|
extern void sdio_retune_crc_disable(struct sdio_func *func);
|
|
extern void sdio_retune_crc_enable(struct sdio_func *func);
|
|
|
|
extern void sdio_retune_hold_now(struct sdio_func *func);
|
|
extern void sdio_retune_release(struct sdio_func *func);
|
|
|
|
#endif /* LINUX_MMC_SDIO_FUNC_H */
|