![Marek Szyprowski](/assets/img/avatar_default.png)
When IOMMU support was enabled, dma-buf import in Exynos DRM was broken since commitf43c35966a
("drm/exynos: use real device for DMA-mapping operations") due to using wrong struct device in drm_gem_prime_import() function. This patch fixes following kernel BUG caused by incorrect buffer mapping to DMA address space: exynos-sysmmu 14650000.sysmmu: 14450000.mixer: PAGE FAULT occurred at 0xb2e00000 ------------[ cut here ]------------ kernel BUG at drivers/iommu/exynos-iommu.c:449! Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.0-rc4-next-20171016-00033-g990d723669fd #3165 Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) task: c0e0b7c0 task.stack: c0e00000 PC is at exynos_sysmmu_irq+0x1d0/0x24c LR is at exynos_sysmmu_irq+0x154/0x24c ------------[ cut here ]------------ Reported-by: Marian Mihailescu <mihailescu2m@gmail.com> Fixes:f43c35966a
("drm/exynos: use real device for DMA-mapping operations") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> Signed-off-by: Inki Dae <inki.dae@samsung.com>
133 lines
4.6 KiB
C
133 lines
4.6 KiB
C
/* exynos_drm_gem.h
|
|
*
|
|
* Copyright (c) 2011 Samsung Electronics Co., Ltd.
|
|
* Authoer: Inki Dae <inki.dae@samsung.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#ifndef _EXYNOS_DRM_GEM_H_
|
|
#define _EXYNOS_DRM_GEM_H_
|
|
|
|
#include <drm/drm_gem.h>
|
|
|
|
#define to_exynos_gem(x) container_of(x, struct exynos_drm_gem, base)
|
|
|
|
#define IS_NONCONTIG_BUFFER(f) (f & EXYNOS_BO_NONCONTIG)
|
|
|
|
/*
|
|
* exynos drm buffer structure.
|
|
*
|
|
* @base: a gem object.
|
|
* - a new handle to this gem object would be created
|
|
* by drm_gem_handle_create().
|
|
* @buffer: a pointer to exynos_drm_gem_buffer object.
|
|
* - contain the information to memory region allocated
|
|
* by user request or at framebuffer creation.
|
|
* continuous memory region allocated by user request
|
|
* or at framebuffer creation.
|
|
* @flags: indicate memory type to allocated buffer and cache attruibute.
|
|
* @size: size requested from user, in bytes and this size is aligned
|
|
* in page unit.
|
|
* @cookie: cookie returned by dma_alloc_attrs
|
|
* @kvaddr: kernel virtual address to allocated memory region.
|
|
* @dma_addr: bus address(accessed by dma) to allocated memory region.
|
|
* - this address could be physical address without IOMMU and
|
|
* device address with IOMMU.
|
|
* @pages: Array of backing pages.
|
|
* @sgt: Imported sg_table.
|
|
*
|
|
* P.S. this object would be transferred to user as kms_bo.handle so
|
|
* user can access the buffer through kms_bo.handle.
|
|
*/
|
|
struct exynos_drm_gem {
|
|
struct drm_gem_object base;
|
|
unsigned int flags;
|
|
unsigned long size;
|
|
void *cookie;
|
|
void __iomem *kvaddr;
|
|
dma_addr_t dma_addr;
|
|
unsigned long dma_attrs;
|
|
struct page **pages;
|
|
struct sg_table *sgt;
|
|
};
|
|
|
|
/* destroy a buffer with gem object */
|
|
void exynos_drm_gem_destroy(struct exynos_drm_gem *exynos_gem);
|
|
|
|
/* create a new buffer with gem object */
|
|
struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
|
|
unsigned int flags,
|
|
unsigned long size);
|
|
|
|
/*
|
|
* request gem object creation and buffer allocation as the size
|
|
* that it is calculated with framebuffer information such as width,
|
|
* height and bpp.
|
|
*/
|
|
int exynos_drm_gem_create_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv);
|
|
|
|
/* get fake-offset of gem object that can be used with mmap. */
|
|
int exynos_drm_gem_map_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv);
|
|
|
|
/*
|
|
* get dma address from gem handle and this function could be used for
|
|
* other drivers such as 2d/3d acceleration drivers.
|
|
* with this function call, gem object reference count would be increased.
|
|
*/
|
|
dma_addr_t *exynos_drm_gem_get_dma_addr(struct drm_device *dev,
|
|
unsigned int gem_handle,
|
|
struct drm_file *filp);
|
|
|
|
/*
|
|
* put dma address from gem handle and this function could be used for
|
|
* other drivers such as 2d/3d acceleration drivers.
|
|
* with this function call, gem object reference count would be decreased.
|
|
*/
|
|
void exynos_drm_gem_put_dma_addr(struct drm_device *dev,
|
|
unsigned int gem_handle,
|
|
struct drm_file *filp);
|
|
|
|
/* get buffer information to memory region allocated by gem. */
|
|
int exynos_drm_gem_get_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file_priv);
|
|
|
|
/* get buffer size to gem handle. */
|
|
unsigned long exynos_drm_gem_get_size(struct drm_device *dev,
|
|
unsigned int gem_handle,
|
|
struct drm_file *file_priv);
|
|
|
|
/* free gem object. */
|
|
void exynos_drm_gem_free_object(struct drm_gem_object *obj);
|
|
|
|
/* create memory region for drm framebuffer. */
|
|
int exynos_drm_gem_dumb_create(struct drm_file *file_priv,
|
|
struct drm_device *dev,
|
|
struct drm_mode_create_dumb *args);
|
|
|
|
/* page fault handler and mmap fault address(virtual) to physical memory. */
|
|
int exynos_drm_gem_fault(struct vm_fault *vmf);
|
|
|
|
/* set vm_flags and we can change the vm attribute to other one at here. */
|
|
int exynos_drm_gem_mmap(struct file *filp, struct vm_area_struct *vma);
|
|
|
|
/* low-level interface prime helpers */
|
|
struct drm_gem_object *exynos_drm_gem_prime_import(struct drm_device *dev,
|
|
struct dma_buf *dma_buf);
|
|
struct sg_table *exynos_drm_gem_prime_get_sg_table(struct drm_gem_object *obj);
|
|
struct drm_gem_object *
|
|
exynos_drm_gem_prime_import_sg_table(struct drm_device *dev,
|
|
struct dma_buf_attachment *attach,
|
|
struct sg_table *sgt);
|
|
void *exynos_drm_gem_prime_vmap(struct drm_gem_object *obj);
|
|
void exynos_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr);
|
|
int exynos_drm_gem_prime_mmap(struct drm_gem_object *obj,
|
|
struct vm_area_struct *vma);
|
|
|
|
#endif
|