e19b42a1a0
Before this patch we had cases that either sent notifications when there were in fact no changes (e.g. non-existent vlan delete) or didn't send notifications when there were changes (e.g. vlan add range with an error in the middle, port flags change + vlan update error). This patch sends down a boolean to the functions setlink/dellink use and if there is even a single configuration change (port flag, vlan add/del, port state) then we always send a notification. This is all done to keep backwards compatibility with the opportunistic vlan delete, where one could specify a vlan range that has missing vlans inside and still everything in that range will be cleared, this is mostly used to clear the whole vlan config with a single call, i.e. range 1-4094. Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Acked-by: Stephen Hemminger <stephen@networkplumber.org> Signed-off-by: David S. Miller <davem@davemloft.net>
85 lines
2.3 KiB
C
85 lines
2.3 KiB
C
/*
|
|
* Bridge per vlan tunnels
|
|
*
|
|
* Authors:
|
|
* Roopa Prabhu <roopa@cumulusnetworks.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version
|
|
* 2 of the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#ifndef _BR_PRIVATE_TUNNEL_H
|
|
#define _BR_PRIVATE_TUNNEL_H
|
|
|
|
struct vtunnel_info {
|
|
u32 tunid;
|
|
u16 vid;
|
|
u16 flags;
|
|
};
|
|
|
|
/* br_netlink_tunnel.c */
|
|
int br_parse_vlan_tunnel_info(struct nlattr *attr,
|
|
struct vtunnel_info *tinfo);
|
|
int br_process_vlan_tunnel_info(struct net_bridge *br,
|
|
struct net_bridge_port *p,
|
|
int cmd,
|
|
struct vtunnel_info *tinfo_curr,
|
|
struct vtunnel_info *tinfo_last,
|
|
bool *changed);
|
|
int br_get_vlan_tunnel_info_size(struct net_bridge_vlan_group *vg);
|
|
int br_fill_vlan_tunnel_info(struct sk_buff *skb,
|
|
struct net_bridge_vlan_group *vg);
|
|
|
|
#ifdef CONFIG_BRIDGE_VLAN_FILTERING
|
|
/* br_vlan_tunnel.c */
|
|
int vlan_tunnel_init(struct net_bridge_vlan_group *vg);
|
|
void vlan_tunnel_deinit(struct net_bridge_vlan_group *vg);
|
|
int nbp_vlan_tunnel_info_delete(struct net_bridge_port *port, u16 vid);
|
|
int nbp_vlan_tunnel_info_add(struct net_bridge_port *port, u16 vid, u32 tun_id);
|
|
void nbp_vlan_tunnel_info_flush(struct net_bridge_port *port);
|
|
void vlan_tunnel_info_del(struct net_bridge_vlan_group *vg,
|
|
struct net_bridge_vlan *vlan);
|
|
int br_handle_ingress_vlan_tunnel(struct sk_buff *skb,
|
|
struct net_bridge_port *p,
|
|
struct net_bridge_vlan_group *vg);
|
|
int br_handle_egress_vlan_tunnel(struct sk_buff *skb,
|
|
struct net_bridge_vlan *vlan);
|
|
#else
|
|
static inline int vlan_tunnel_init(struct net_bridge_vlan_group *vg)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int nbp_vlan_tunnel_info_delete(struct net_bridge_port *port,
|
|
u16 vid)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int nbp_vlan_tunnel_info_add(struct net_bridge_port *port,
|
|
u16 vid, u32 tun_id)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void nbp_vlan_tunnel_info_flush(struct net_bridge_port *port)
|
|
{
|
|
}
|
|
|
|
static inline void vlan_tunnel_info_del(struct net_bridge_vlan_group *vg,
|
|
struct net_bridge_vlan *vlan)
|
|
{
|
|
}
|
|
|
|
static inline int br_handle_ingress_vlan_tunnel(struct sk_buff *skb,
|
|
struct net_bridge_port *p,
|
|
struct net_bridge_vlan_group *vg)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
#endif
|