1
0
Fork 0
alistair23-linux/drivers/gpu/drm/rockchip
Daniel Vetter 648a4ce7ca drm/rockchip: Don't grab dev->struct_mutex for in mmap offset ioctl
Since David Herrmann's mmap vma manager rework we don't need to grab
dev->struct_mutex any more to prevent races when looking up the mmap
offset. Drop it and instead don't forget to use the unref_unlocked
variant (since the drm core still cares).

Aside: I stumbled over the mmap handler which directly does a
dma_mmap_attrs. But totally fails to grab a reference on the
underlying object and hence looks like it happily just leaks the ptes
since there's no guarantee the mmap isn't still around when
gem_free_object is called. Which the kerneldoc of dma_mmap_attrs
explicitly forbids.

v2: Fixup compile fail 0-day spotted.

Cc: Mark Yao <mark.yao@rock-chips.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
2015-08-11 12:04:06 +02:00
..
Kconfig drm: rockchip: add reset controller dependency 2015-01-31 10:11:48 +10:00
Makefile drm: bridge/dw_hdmi: add rockchip rk3288 support 2015-01-07 18:32:00 +01:00
dw_hdmi-rockchip.c drm: rockchip/dw_hdmi-rockchip: improve for HDMI electrical test 2015-04-01 10:54:13 +01:00
rockchip_drm_drv.c Merge branch 'drm-rockchip-2015-07-13' of https://github.com/markyzq/kernel-drm-rockchip into drm-fixes 2015-07-17 10:25:02 +10:00
rockchip_drm_drv.h drm: rockchip: Add basic drm driver 2014-12-02 17:29:03 +08:00
rockchip_drm_fb.c drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present 2015-07-13 13:50:52 +08:00
rockchip_drm_fb.h drm: rockchip: Add basic drm driver 2014-12-02 17:29:03 +08:00
rockchip_drm_fbdev.c drm/rockchip: Use new drm_fb_helper functions 2015-08-06 14:12:56 +02:00
rockchip_drm_fbdev.h drm: rockchip: Add basic drm driver 2014-12-02 17:29:03 +08:00
rockchip_drm_gem.c drm/rockchip: Don't grab dev->struct_mutex for in mmap offset ioctl 2015-08-11 12:04:06 +02:00
rockchip_drm_gem.h drm/rockchip: Only alloc a kmap for fbdev gem object 2015-03-16 10:07:12 +08:00
rockchip_drm_vop.c Merge branch 'drm-rockchip-2015-07-13' of https://github.com/markyzq/kernel-drm-rockchip into drm-fixes 2015-07-17 10:25:02 +10:00
rockchip_drm_vop.h drm: rockchip: Add basic drm driver 2014-12-02 17:29:03 +08:00