37a3a98ef6
The recent change of vga_switcheroo allowed the runtime PM for
HD-audio on AMD GPUs, but this also resulted in a regression. When
the HD-audio controller driver gets runtime-suspended, HD-audio link
is turned off, and the hotplug notification is ignored. This leads to
the inconsistent audio state (the connection isn't notified and ELD is
ignored).
The best fix would be to implement the proper ELD notification via the
audio component, but it's still not ready. As a quick workaround,
this patch adds the check of runtime_idle and allows the runtime
suspend only when the vga_switcheroo is bound with discrete GPU.
That is, a system with a single GPU and APU would be again without
runtime PM to keep the HD-audio link for the hotplug notification and
ELD read out.
Also, the codec->auto_runtime_pm flag is set only for the discrete GPU
at the time GPU gets bound via vga_switcheroo (i.e. only dGPU is
forcibly runtime-PM enabled), so that APU can still get the ELD
notification.
For identifying which GPU is bound, a new vga_switcheroo client
callback, gpu_bound, is implemented. The vga_switcheroo simply calls
this when GPU is bound, and tells whether it's dGPU or APU.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200945
Fixes: 07f4f97d7b ("vga_switcheroo: Use device link for HDA controller")
Reported-by: Jian-Hong Pan <jian-hong@endlessm.com>
Tested-by: Jian-Hong Pan <jian-hong@endlessm.com>
Acked-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
48 lines
1.4 KiB
C
48 lines
1.4 KiB
C
/*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the Free
|
|
* Software Foundation; either version 2 of the License, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program; if not, write to the Free Software Foundation, Inc., 59
|
|
* Temple Place - Suite 330, Boston, MA 02111-1307, USA.
|
|
*/
|
|
#ifndef __SOUND_HDA_INTEL_H
|
|
#define __SOUND_HDA_INTEL_H
|
|
|
|
#include "hda_controller.h"
|
|
|
|
struct hda_intel {
|
|
struct azx chip;
|
|
|
|
/* for pending irqs */
|
|
struct work_struct irq_pending_work;
|
|
|
|
/* sync probing */
|
|
struct completion probe_wait;
|
|
struct work_struct probe_work;
|
|
|
|
/* card list (for power_save trigger) */
|
|
struct list_head list;
|
|
|
|
/* extra flags */
|
|
unsigned int irq_pending_warned:1;
|
|
unsigned int probe_continued:1;
|
|
|
|
/* vga_switcheroo setup */
|
|
unsigned int use_vga_switcheroo:1;
|
|
unsigned int need_eld_notify_link:1;
|
|
unsigned int vga_switcheroo_registered:1;
|
|
unsigned int init_failed:1; /* delayed init failed */
|
|
|
|
bool need_i915_power:1; /* the hda controller needs i915 power */
|
|
};
|
|
|
|
#endif
|