alistair23-linux/sound
Kai Vehmanen 99ced2ecfe ASoC: hdac_hda: Fix error in driver removal after failed probe
[ Upstream commit 552b1a85da ]

In case system has multiple HDA codecs, and codec probe fails for
at least one but not all codecs, driver will end up cancelling
a non-initialized timer context upon driver removal.

Call trace of typical case:

[   60.593646] WARNING: CPU: 1 PID: 1147 at kernel/workqueue.c:3032
__flush_work+0x18b/0x1a0
[...]
[   60.593670]  __cancel_work_timer+0x11f/0x1a0
[   60.593673]  hdac_hda_dev_remove+0x25/0x30 [snd_soc_hdac_hda]
[   60.593674]  device_release_driver_internal+0xe0/0x1c0
[   60.593675]  bus_remove_device+0xd6/0x140
[   60.593677]  device_del+0x175/0x3e0
[   60.593679]  ? widget_tree_free.isra.7+0x90/0xb0 [snd_hda_core]
[   60.593680]  snd_hdac_device_unregister+0x34/0x50 [snd_hda_core]
[   60.593682]  snd_hdac_ext_bus_device_remove+0x2a/0x60 [snd_hda_ext_core]
[   60.593684]  hda_dsp_remove+0x26/0x100 [snd_sof_intel_hda_common]
[   60.593686]  snd_sof_device_remove+0x84/0xa0 [snd_sof]
[   60.593687]  sof_pci_remove+0x10/0x30 [snd_sof_pci]
[   60.593689]  pci_device_remove+0x36/0xb0

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200110235751.3404-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-02-05 21:22:45 +00:00
..
ac97
aoa
arm
atmel
core ALSA: seq: Fix racy access for queue timer in proc read 2020-01-23 08:22:31 +01:00
drivers
firewire ALSA: firewire-tascam: fix corruption due to spin lock without restoration in SoftIRQ context 2020-01-23 08:22:31 +01:00
hda ALSA: hda: Fix regression by strip mask fix 2019-12-21 11:05:23 +01:00
i2c
isa ALSA: cs4236: fix error return comparison of an unsigned integer 2020-01-09 10:20:00 +01:00
mips
oss
parisc
pci ALSA: hda/realtek - Move some alc236 pintbls to fallback table 2020-02-01 09:34:50 +00:00
pcmcia
ppc
sh
soc ASoC: hdac_hda: Fix error in driver removal after failed probe 2020-02-05 21:22:45 +00:00
sparc
spi
synth
usb ALSA: usb-audio: fix sync-ep altsetting sanity check 2020-01-23 08:22:31 +01:00
x86
xen
ac97_bus.c
Kconfig
last.c
Makefile
sound_core.c sound: fix a memory leak bug 2019-08-08 08:18:32 +02:00