1
0
Fork 0
alistair23-linux/drivers/staging/media/msi3101
Hans Verkuil e37559b22c [media] vb2: stop_streaming should return void
The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.

The int return gave drivers the idea that this operation could actually
fail, but that's really not the case.

The pwc amd sdr-msi3101 drivers both had this construction:

        if (mutex_lock_interruptible(&s->v4l2_lock))
                return -ERESTARTSYS;

This has been updated to just call mutex_lock(). The stop_streaming op
expects this to really stop streaming and I very much doubt this will
work reliably if stop_streaming just returns without really stopping the
DMA.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Pawel Osciak <pawel@osciak.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
2014-04-23 10:12:51 -03:00
..
Kconfig [media] msi3101: use msi001 tuner driver 2014-03-13 10:26:51 -03:00
Makefile [media] msi001: Mirics MSi001 silicon tuner driver 2014-03-13 10:26:50 -03:00
msi001.c [media] msi001: fix possible integer overflow 2014-04-06 11:07:45 -03:00
sdr-msi3101.c [media] vb2: stop_streaming should return void 2014-04-23 10:12:51 -03:00