1
0
Fork 0
alistair23-linux/sound/firewire
Dan Carpenter 090ac65f8c ALSA: firewire: Clean up a locking issue in copy_resp_to_buf()
commit 02a9c6ee41 upstream.

The spin_lock/unlock_irq() functions cannot be nested.  The problem is
that presumably we would want the IRQs to be re-enabled on the second
call the spin_unlock_irq() but instead it will be enabled at the first
call so IRQs will be enabled earlier than expected.

In this situation the copy_resp_to_buf() function is only called from
one function and it is called with IRQs disabled.  We can just use
the regular spin_lock/unlock() functions.

Fixes: 555e8a8f7f ("ALSA: fireworks: Add command/response functionality into hwdep interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20201113101241.GB168908@mwanda
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-11-24 13:29:20 +01:00
..
bebob ALSA: bebob: potential info leak in hwdep_read() 2020-10-29 09:57:25 +01:00
dice ALSA: dice: fix fallback from protocol extension into limited functionality 2020-01-23 08:22:30 +01:00
digi00x ALSA: firewire-digi00x: exclude Avid Adrenaline from detection 2020-09-09 19:12:32 +02:00
fireface ALSA: fireface: fix configuration error for nominal sampling transfer frequency 2020-06-17 16:40:27 +02:00
fireworks ALSA: firewire: Clean up a locking issue in copy_resp_to_buf() 2020-11-24 13:29:20 +01:00
motu ALSA: firewire-motu: Correct a typo in the clock proc string 2020-01-09 10:20:01 +01:00
oxfw ALSA: oxfw: fix return value in error path of isochronous resources reservation 2019-12-17 19:56:27 +01:00
tascam ALSA; firewire-tascam: exclude Tascam FE-8 from detection 2020-09-09 19:12:33 +02:00
Kconfig treewide: Add SPDX license identifier - Makefile/Kconfig 2019-05-21 10:50:46 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
amdtp-am824.c ALSA: firewire-lib: fix invalid assignment to union data for directional parameter 2020-06-24 17:50:25 +02:00
amdtp-am824.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
amdtp-stream-trace.h ALSA: firewire-lib: fix 'function sizeof not defined' error of tracepoints format 2020-05-20 08:20:19 +02:00
amdtp-stream.c ALSA: firewire-lib: remove WARN_ON() at destruction of AMDTP domain 2019-09-07 08:39:23 +02:00
amdtp-stream.h ALSA: firewire-lib: localize kernel APIs to start/stop each AMDTP stream 2019-08-05 19:57:29 +02:00
cmp.c ASoC: Updates for v5.3 2019-07-08 14:45:34 +02:00
cmp.h ALSA: firewire-lib: split allocation of isochronous resources from establishment of connection 2019-06-17 08:18:36 +02:00
fcp.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
fcp.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
isight.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
iso-resources.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
iso-resources.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
lib.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 345 2019-06-05 17:37:08 +02:00
lib.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
packets-buffer.c ALSA: firewire: fix a memory leak bug 2019-08-08 11:12:26 +02:00
packets-buffer.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00