![Tejun Heo](/assets/img/avatar_default.png)
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
169 lines
4.3 KiB
C
169 lines
4.3 KiB
C
/*
|
|
* drivers/i2c/busses/i2c-ixp2000.c
|
|
*
|
|
* I2C adapter for IXP2000 systems using GPIOs for I2C bus
|
|
*
|
|
* Author: Deepak Saxena <dsaxena@plexity.net>
|
|
* Based on IXDP2400 code by: Naeem M. Afzal <naeem.m.afzal@intel.com>
|
|
* Made generic by: Jeff Daly <jeffrey.daly@intel.com>
|
|
*
|
|
* Copyright (c) 2003-2004 MontaVista Software Inc.
|
|
*
|
|
* This file is licensed under the terms of the GNU General Public
|
|
* License version 2. This program is licensed "as is" without any
|
|
* warranty of any kind, whether express or implied.
|
|
*
|
|
* From Jeff Daly:
|
|
*
|
|
* I2C adapter driver for Intel IXDP2xxx platforms. This should work for any
|
|
* IXP2000 platform if it uses the HW GPIO in the same manner. Basically,
|
|
* SDA and SCL GPIOs have external pullups. Setting the respective GPIO to
|
|
* an input will make the signal a '1' via the pullup. Setting them to
|
|
* outputs will pull them down.
|
|
*
|
|
* The GPIOs are open drain signals and are used as configuration strap inputs
|
|
* during power-up so there's generally a buffer on the board that needs to be
|
|
* 'enabled' to drive the GPIOs.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/module.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/i2c-algo-bit.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include <mach/hardware.h> /* Pick up IXP2000-specific bits */
|
|
#include <mach/gpio.h>
|
|
|
|
static inline int ixp2000_scl_pin(void *data)
|
|
{
|
|
return ((struct ixp2000_i2c_pins*)data)->scl_pin;
|
|
}
|
|
|
|
static inline int ixp2000_sda_pin(void *data)
|
|
{
|
|
return ((struct ixp2000_i2c_pins*)data)->sda_pin;
|
|
}
|
|
|
|
|
|
static void ixp2000_bit_setscl(void *data, int val)
|
|
{
|
|
int i = 5000;
|
|
|
|
if (val) {
|
|
gpio_line_config(ixp2000_scl_pin(data), GPIO_IN);
|
|
while(!gpio_line_get(ixp2000_scl_pin(data)) && i--);
|
|
} else {
|
|
gpio_line_config(ixp2000_scl_pin(data), GPIO_OUT);
|
|
}
|
|
}
|
|
|
|
static void ixp2000_bit_setsda(void *data, int val)
|
|
{
|
|
if (val) {
|
|
gpio_line_config(ixp2000_sda_pin(data), GPIO_IN);
|
|
} else {
|
|
gpio_line_config(ixp2000_sda_pin(data), GPIO_OUT);
|
|
}
|
|
}
|
|
|
|
static int ixp2000_bit_getscl(void *data)
|
|
{
|
|
return gpio_line_get(ixp2000_scl_pin(data));
|
|
}
|
|
|
|
static int ixp2000_bit_getsda(void *data)
|
|
{
|
|
return gpio_line_get(ixp2000_sda_pin(data));
|
|
}
|
|
|
|
struct ixp2000_i2c_data {
|
|
struct ixp2000_i2c_pins *gpio_pins;
|
|
struct i2c_adapter adapter;
|
|
struct i2c_algo_bit_data algo_data;
|
|
};
|
|
|
|
static int ixp2000_i2c_remove(struct platform_device *plat_dev)
|
|
{
|
|
struct ixp2000_i2c_data *drv_data = platform_get_drvdata(plat_dev);
|
|
|
|
platform_set_drvdata(plat_dev, NULL);
|
|
|
|
i2c_del_adapter(&drv_data->adapter);
|
|
|
|
kfree(drv_data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int ixp2000_i2c_probe(struct platform_device *plat_dev)
|
|
{
|
|
int err;
|
|
struct ixp2000_i2c_pins *gpio = plat_dev->dev.platform_data;
|
|
struct ixp2000_i2c_data *drv_data =
|
|
kzalloc(sizeof(struct ixp2000_i2c_data), GFP_KERNEL);
|
|
|
|
if (!drv_data)
|
|
return -ENOMEM;
|
|
drv_data->gpio_pins = gpio;
|
|
|
|
drv_data->algo_data.data = gpio;
|
|
drv_data->algo_data.setsda = ixp2000_bit_setsda;
|
|
drv_data->algo_data.setscl = ixp2000_bit_setscl;
|
|
drv_data->algo_data.getsda = ixp2000_bit_getsda;
|
|
drv_data->algo_data.getscl = ixp2000_bit_getscl;
|
|
drv_data->algo_data.udelay = 6;
|
|
drv_data->algo_data.timeout = HZ;
|
|
|
|
strlcpy(drv_data->adapter.name, plat_dev->dev.driver->name,
|
|
sizeof(drv_data->adapter.name));
|
|
drv_data->adapter.algo_data = &drv_data->algo_data,
|
|
|
|
drv_data->adapter.dev.parent = &plat_dev->dev;
|
|
|
|
gpio_line_config(gpio->sda_pin, GPIO_IN);
|
|
gpio_line_config(gpio->scl_pin, GPIO_IN);
|
|
gpio_line_set(gpio->scl_pin, 0);
|
|
gpio_line_set(gpio->sda_pin, 0);
|
|
|
|
if ((err = i2c_bit_add_bus(&drv_data->adapter)) != 0) {
|
|
dev_err(&plat_dev->dev, "Could not install, error %d\n", err);
|
|
kfree(drv_data);
|
|
return err;
|
|
}
|
|
|
|
platform_set_drvdata(plat_dev, drv_data);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver ixp2000_i2c_driver = {
|
|
.probe = ixp2000_i2c_probe,
|
|
.remove = ixp2000_i2c_remove,
|
|
.driver = {
|
|
.name = "IXP2000-I2C",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
};
|
|
|
|
static int __init ixp2000_i2c_init(void)
|
|
{
|
|
return platform_driver_register(&ixp2000_i2c_driver);
|
|
}
|
|
|
|
static void __exit ixp2000_i2c_exit(void)
|
|
{
|
|
platform_driver_unregister(&ixp2000_i2c_driver);
|
|
}
|
|
|
|
module_init(ixp2000_i2c_init);
|
|
module_exit(ixp2000_i2c_exit);
|
|
|
|
MODULE_AUTHOR ("Deepak Saxena <dsaxena@plexity.net>");
|
|
MODULE_DESCRIPTION("IXP2000 GPIO-based I2C bus driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:IXP2000-I2C");
|
|
|