![Tomasz Figa](/assets/img/avatar_default.png)
Due to recent consolidation of Exynos suspend and cpuidle code, some
parts of suspend and resume sequences are executed two times, once from
exynos_pm_syscore_ops and then from exynos_cpu_pm_notifier() and thus it
breaks suspend, at least on Exynos4-based boards. In addition, simple
core power down from a cpuidle driver could, in case of CPU 0 could
result in calling functions that are specific to suspend and deeper idle
states.
This patch fixes the issue by moving those operations outside the CPU PM
notifier into suspend and AFTR code paths. This leads to a bit of code
duplication, but allows additional code simplification, so in the end
more code is removed than added.
Fixes: 85f9f90808
("ARM: EXYNOS: Use the cpu_pm notifier for pm")
Cc: Kukjin Kim <kgene.kim@samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Olof Johansson <olof@lixom.net>
Cc: arm@kernel.org
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
[b.zolnierkie: ported patch over current changes]
[b.zolnierkie: fixed exynos_aftr_finisher() return value]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
410 lines
9.2 KiB
C
410 lines
9.2 KiB
C
/*
|
|
* Copyright (c) 2011-2012 Samsung Electronics Co., Ltd.
|
|
* http://www.samsung.com
|
|
*
|
|
* EXYNOS - Power Management support
|
|
*
|
|
* Based on arch/arm/mach-s3c2410/pm.c
|
|
* Copyright (c) 2006 Simtec Electronics
|
|
* Ben Dooks <ben@simtec.co.uk>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/suspend.h>
|
|
#include <linux/syscore_ops.h>
|
|
#include <linux/cpu_pm.h>
|
|
#include <linux/io.h>
|
|
#include <linux/irqchip/arm-gic.h>
|
|
#include <linux/err.h>
|
|
#include <linux/clk.h>
|
|
|
|
#include <asm/cacheflush.h>
|
|
#include <asm/hardware/cache-l2x0.h>
|
|
#include <asm/smp_scu.h>
|
|
#include <asm/suspend.h>
|
|
|
|
#include <plat/pm-common.h>
|
|
#include <plat/regs-srom.h>
|
|
|
|
#include <mach/map.h>
|
|
|
|
#include "common.h"
|
|
#include "regs-pmu.h"
|
|
#include "regs-sys.h"
|
|
|
|
/**
|
|
* struct exynos_wkup_irq - Exynos GIC to PMU IRQ mapping
|
|
* @hwirq: Hardware IRQ signal of the GIC
|
|
* @mask: Mask in PMU wake-up mask register
|
|
*/
|
|
struct exynos_wkup_irq {
|
|
unsigned int hwirq;
|
|
u32 mask;
|
|
};
|
|
|
|
static struct sleep_save exynos5_sys_save[] = {
|
|
SAVE_ITEM(EXYNOS5_SYS_I2C_CFG),
|
|
};
|
|
|
|
static struct sleep_save exynos_core_save[] = {
|
|
/* SROM side */
|
|
SAVE_ITEM(S5P_SROM_BW),
|
|
SAVE_ITEM(S5P_SROM_BC0),
|
|
SAVE_ITEM(S5P_SROM_BC1),
|
|
SAVE_ITEM(S5P_SROM_BC2),
|
|
SAVE_ITEM(S5P_SROM_BC3),
|
|
};
|
|
|
|
/*
|
|
* GIC wake-up support
|
|
*/
|
|
|
|
static u32 exynos_irqwake_intmask = 0xffffffff;
|
|
|
|
static const struct exynos_wkup_irq exynos4_wkup_irq[] = {
|
|
{ 76, BIT(1) }, /* RTC alarm */
|
|
{ 77, BIT(2) }, /* RTC tick */
|
|
{ /* sentinel */ },
|
|
};
|
|
|
|
static const struct exynos_wkup_irq exynos5250_wkup_irq[] = {
|
|
{ 75, BIT(1) }, /* RTC alarm */
|
|
{ 76, BIT(2) }, /* RTC tick */
|
|
{ /* sentinel */ },
|
|
};
|
|
|
|
static int exynos_irq_set_wake(struct irq_data *data, unsigned int state)
|
|
{
|
|
const struct exynos_wkup_irq *wkup_irq;
|
|
|
|
if (soc_is_exynos5250())
|
|
wkup_irq = exynos5250_wkup_irq;
|
|
else
|
|
wkup_irq = exynos4_wkup_irq;
|
|
|
|
while (wkup_irq->mask) {
|
|
if (wkup_irq->hwirq == data->hwirq) {
|
|
if (!state)
|
|
exynos_irqwake_intmask |= wkup_irq->mask;
|
|
else
|
|
exynos_irqwake_intmask &= ~wkup_irq->mask;
|
|
return 0;
|
|
}
|
|
++wkup_irq;
|
|
}
|
|
|
|
return -ENOENT;
|
|
}
|
|
|
|
#define EXYNOS_BOOT_VECTOR_ADDR (samsung_rev() == EXYNOS4210_REV_1_1 ? \
|
|
pmu_base_addr + S5P_INFORM7 : \
|
|
(samsung_rev() == EXYNOS4210_REV_1_0 ? \
|
|
(sysram_base_addr + 0x24) : \
|
|
pmu_base_addr + S5P_INFORM0))
|
|
#define EXYNOS_BOOT_VECTOR_FLAG (samsung_rev() == EXYNOS4210_REV_1_1 ? \
|
|
pmu_base_addr + S5P_INFORM6 : \
|
|
(samsung_rev() == EXYNOS4210_REV_1_0 ? \
|
|
(sysram_base_addr + 0x20) : \
|
|
pmu_base_addr + S5P_INFORM1))
|
|
|
|
#define S5P_CHECK_AFTR 0xFCBA0D10
|
|
#define S5P_CHECK_SLEEP 0x00000BAD
|
|
|
|
/* For Cortex-A9 Diagnostic and Power control register */
|
|
static unsigned int save_arm_register[2];
|
|
|
|
static void exynos_cpu_save_register(void)
|
|
{
|
|
unsigned long tmp;
|
|
|
|
/* Save Power control register */
|
|
asm ("mrc p15, 0, %0, c15, c0, 0"
|
|
: "=r" (tmp) : : "cc");
|
|
|
|
save_arm_register[0] = tmp;
|
|
|
|
/* Save Diagnostic register */
|
|
asm ("mrc p15, 0, %0, c15, c0, 1"
|
|
: "=r" (tmp) : : "cc");
|
|
|
|
save_arm_register[1] = tmp;
|
|
}
|
|
|
|
static void exynos_cpu_restore_register(void)
|
|
{
|
|
unsigned long tmp;
|
|
|
|
/* Restore Power control register */
|
|
tmp = save_arm_register[0];
|
|
|
|
asm volatile ("mcr p15, 0, %0, c15, c0, 0"
|
|
: : "r" (tmp)
|
|
: "cc");
|
|
|
|
/* Restore Diagnostic register */
|
|
tmp = save_arm_register[1];
|
|
|
|
asm volatile ("mcr p15, 0, %0, c15, c0, 1"
|
|
: : "r" (tmp)
|
|
: "cc");
|
|
}
|
|
|
|
static void exynos_pm_central_suspend(void)
|
|
{
|
|
unsigned long tmp;
|
|
|
|
/* Setting Central Sequence Register for power down mode */
|
|
tmp = pmu_raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
|
|
tmp &= ~S5P_CENTRAL_LOWPWR_CFG;
|
|
pmu_raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
|
|
}
|
|
|
|
static int exynos_pm_central_resume(void)
|
|
{
|
|
unsigned long tmp;
|
|
|
|
/*
|
|
* If PMU failed while entering sleep mode, WFI will be
|
|
* ignored by PMU and then exiting cpu_do_idle().
|
|
* S5P_CENTRAL_LOWPWR_CFG bit will not be set automatically
|
|
* in this situation.
|
|
*/
|
|
tmp = pmu_raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
|
|
if (!(tmp & S5P_CENTRAL_LOWPWR_CFG)) {
|
|
tmp |= S5P_CENTRAL_LOWPWR_CFG;
|
|
pmu_raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
|
|
/* clear the wakeup state register */
|
|
pmu_raw_writel(0x0, S5P_WAKEUP_STAT);
|
|
/* No need to perform below restore code */
|
|
return -1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
|
|
static void exynos_set_wakeupmask(long mask)
|
|
{
|
|
pmu_raw_writel(mask, S5P_WAKEUP_MASK);
|
|
}
|
|
|
|
static void exynos_cpu_set_boot_vector(long flags)
|
|
{
|
|
__raw_writel(virt_to_phys(exynos_cpu_resume), EXYNOS_BOOT_VECTOR_ADDR);
|
|
__raw_writel(flags, EXYNOS_BOOT_VECTOR_FLAG);
|
|
}
|
|
|
|
static int exynos_aftr_finisher(unsigned long flags)
|
|
{
|
|
exynos_set_wakeupmask(0x0000ff3e);
|
|
exynos_cpu_set_boot_vector(S5P_CHECK_AFTR);
|
|
/* Set value of power down register for aftr mode */
|
|
exynos_sys_powerdown_conf(SYS_AFTR);
|
|
cpu_do_idle();
|
|
|
|
return 1;
|
|
}
|
|
|
|
void exynos_enter_aftr(void)
|
|
{
|
|
cpu_pm_enter();
|
|
|
|
exynos_pm_central_suspend();
|
|
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
|
|
exynos_cpu_save_register();
|
|
|
|
cpu_suspend(0, exynos_aftr_finisher);
|
|
|
|
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9) {
|
|
scu_enable(S5P_VA_SCU);
|
|
exynos_cpu_restore_register();
|
|
}
|
|
|
|
exynos_pm_central_resume();
|
|
|
|
cpu_pm_exit();
|
|
}
|
|
|
|
static int exynos_cpu_suspend(unsigned long arg)
|
|
{
|
|
#ifdef CONFIG_CACHE_L2X0
|
|
outer_flush_all();
|
|
#endif
|
|
|
|
if (soc_is_exynos5250())
|
|
flush_cache_all();
|
|
|
|
/* issue the standby signal into the pm unit. */
|
|
cpu_do_idle();
|
|
|
|
pr_info("Failed to suspend the system\n");
|
|
return 1; /* Aborting suspend */
|
|
}
|
|
|
|
static void exynos_pm_prepare(void)
|
|
{
|
|
unsigned int tmp;
|
|
|
|
/* Set wake-up mask registers */
|
|
pmu_raw_writel(exynos_get_eint_wake_mask(), S5P_EINT_WAKEUP_MASK);
|
|
pmu_raw_writel(exynos_irqwake_intmask & ~(1 << 31), S5P_WAKEUP_MASK);
|
|
|
|
s3c_pm_do_save(exynos_core_save, ARRAY_SIZE(exynos_core_save));
|
|
|
|
if (soc_is_exynos5250()) {
|
|
s3c_pm_do_save(exynos5_sys_save, ARRAY_SIZE(exynos5_sys_save));
|
|
/* Disable USE_RETENTION of JPEG_MEM_OPTION */
|
|
tmp = pmu_raw_readl(EXYNOS5_JPEG_MEM_OPTION);
|
|
tmp &= ~EXYNOS5_OPTION_USE_RETENTION;
|
|
pmu_raw_writel(tmp, EXYNOS5_JPEG_MEM_OPTION);
|
|
}
|
|
|
|
/* Set value of power down register for sleep mode */
|
|
|
|
exynos_sys_powerdown_conf(SYS_SLEEP);
|
|
pmu_raw_writel(S5P_CHECK_SLEEP, S5P_INFORM1);
|
|
|
|
/* ensure at least INFORM0 has the resume address */
|
|
|
|
pmu_raw_writel(virt_to_phys(exynos_cpu_resume), S5P_INFORM0);
|
|
}
|
|
|
|
static int exynos_pm_suspend(void)
|
|
{
|
|
unsigned long tmp;
|
|
|
|
exynos_pm_central_suspend();
|
|
|
|
/* Setting SEQ_OPTION register */
|
|
|
|
tmp = (S5P_USE_STANDBY_WFI0 | S5P_USE_STANDBY_WFE0);
|
|
pmu_raw_writel(tmp, S5P_CENTRAL_SEQ_OPTION);
|
|
|
|
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
|
|
exynos_cpu_save_register();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void exynos_pm_resume(void)
|
|
{
|
|
if (exynos_pm_central_resume())
|
|
goto early_wakeup;
|
|
|
|
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
|
|
exynos_cpu_restore_register();
|
|
|
|
/* For release retention */
|
|
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_MAUDIO_OPTION);
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_GPIO_OPTION);
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_UART_OPTION);
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_MMCA_OPTION);
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_MMCB_OPTION);
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_EBIA_OPTION);
|
|
pmu_raw_writel((1 << 28), S5P_PAD_RET_EBIB_OPTION);
|
|
|
|
if (soc_is_exynos5250())
|
|
s3c_pm_do_restore(exynos5_sys_save,
|
|
ARRAY_SIZE(exynos5_sys_save));
|
|
|
|
s3c_pm_do_restore_core(exynos_core_save, ARRAY_SIZE(exynos_core_save));
|
|
|
|
if (read_cpuid_part() == ARM_CPU_PART_CORTEX_A9)
|
|
scu_enable(S5P_VA_SCU);
|
|
|
|
early_wakeup:
|
|
|
|
/* Clear SLEEP mode set in INFORM1 */
|
|
pmu_raw_writel(0x0, S5P_INFORM1);
|
|
|
|
return;
|
|
}
|
|
|
|
static struct syscore_ops exynos_pm_syscore_ops = {
|
|
.suspend = exynos_pm_suspend,
|
|
.resume = exynos_pm_resume,
|
|
};
|
|
|
|
/*
|
|
* Suspend Ops
|
|
*/
|
|
|
|
static int exynos_suspend_enter(suspend_state_t state)
|
|
{
|
|
int ret;
|
|
|
|
s3c_pm_debug_init();
|
|
|
|
S3C_PMDBG("%s: suspending the system...\n", __func__);
|
|
|
|
S3C_PMDBG("%s: wakeup masks: %08x,%08x\n", __func__,
|
|
exynos_irqwake_intmask, exynos_get_eint_wake_mask());
|
|
|
|
if (exynos_irqwake_intmask == -1U
|
|
&& exynos_get_eint_wake_mask() == -1U) {
|
|
pr_err("%s: No wake-up sources!\n", __func__);
|
|
pr_err("%s: Aborting sleep\n", __func__);
|
|
return -EINVAL;
|
|
}
|
|
|
|
s3c_pm_save_uarts();
|
|
exynos_pm_prepare();
|
|
flush_cache_all();
|
|
s3c_pm_check_store();
|
|
|
|
ret = cpu_suspend(0, exynos_cpu_suspend);
|
|
if (ret)
|
|
return ret;
|
|
|
|
s3c_pm_restore_uarts();
|
|
|
|
S3C_PMDBG("%s: wakeup stat: %08x\n", __func__,
|
|
pmu_raw_readl(S5P_WAKEUP_STAT));
|
|
|
|
s3c_pm_check_restore();
|
|
|
|
S3C_PMDBG("%s: resuming the system...\n", __func__);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int exynos_suspend_prepare(void)
|
|
{
|
|
s3c_pm_check_prepare();
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void exynos_suspend_finish(void)
|
|
{
|
|
s3c_pm_check_cleanup();
|
|
}
|
|
|
|
static const struct platform_suspend_ops exynos_suspend_ops = {
|
|
.enter = exynos_suspend_enter,
|
|
.prepare = exynos_suspend_prepare,
|
|
.finish = exynos_suspend_finish,
|
|
.valid = suspend_valid_only_mem,
|
|
};
|
|
|
|
void __init exynos_pm_init(void)
|
|
{
|
|
u32 tmp;
|
|
|
|
/* Platform-specific GIC callback */
|
|
gic_arch_extn.irq_set_wake = exynos_irq_set_wake;
|
|
|
|
/* All wakeup disable */
|
|
tmp = pmu_raw_readl(S5P_WAKEUP_MASK);
|
|
tmp |= ((0xFF << 8) | (0x1F << 1));
|
|
pmu_raw_writel(tmp, S5P_WAKEUP_MASK);
|
|
|
|
register_syscore_ops(&exynos_pm_syscore_ops);
|
|
suspend_set_ops(&exynos_suspend_ops);
|
|
}
|