![Ryusuke Konishi](/assets/img/avatar_default.png)
This resolves the following failure of nilfs2 cleaner daemon: nilfs_cleanerd[20670]: cannot clean segments: No such file or directory nilfs_cleanerd[20670]: shutdown When creating thousands of snapshots, the cleaner daemon had rarely died as above due to an error returned from the kernel code. After applying the recent patch which fixed memory allocation problems in ioctl (Message-Id: <20081215.155840.105124170.ryusuke@osrg.net>), the problem gets more frequent. It turned out to be a bug of nilfs_ioctl_wrap_copy function and one of its callback routines to read out information of snapshots; if the nilfs_ioctl_wrap_copy function divided a large read request into multiple requests, the second and later requests have failed since a restart position on snapshot meta data was not properly set forward. It's a deficiency of the callback interface that cannot pass the restart position among multiple requests. This patch fixes the issue by allowing nilfs_ioctl_wrap_copy and snapshot read functions to exchange a position argument. Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
46 lines
1.6 KiB
C
46 lines
1.6 KiB
C
/*
|
|
* cpfile.h - NILFS checkpoint file.
|
|
*
|
|
* Copyright (C) 2006-2008 Nippon Telegraph and Telephone Corporation.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*
|
|
* Written by Koji Sato <koji@osrg.net>.
|
|
*/
|
|
|
|
#ifndef _NILFS_CPFILE_H
|
|
#define _NILFS_CPFILE_H
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/buffer_head.h>
|
|
#include <linux/nilfs2_fs.h>
|
|
|
|
#define NILFS_CPFILE_GFP NILFS_MDT_GFP
|
|
|
|
|
|
int nilfs_cpfile_get_checkpoint(struct inode *, __u64, int,
|
|
struct nilfs_checkpoint **,
|
|
struct buffer_head **);
|
|
void nilfs_cpfile_put_checkpoint(struct inode *, __u64, struct buffer_head *);
|
|
int nilfs_cpfile_delete_checkpoints(struct inode *, __u64, __u64);
|
|
int nilfs_cpfile_delete_checkpoint(struct inode *, __u64);
|
|
int nilfs_cpfile_change_cpmode(struct inode *, __u64, int);
|
|
int nilfs_cpfile_is_snapshot(struct inode *, __u64);
|
|
int nilfs_cpfile_get_stat(struct inode *, struct nilfs_cpstat *);
|
|
ssize_t nilfs_cpfile_get_cpinfo(struct inode *, __u64 *, int,
|
|
struct nilfs_cpinfo *, size_t);
|
|
|
|
#endif /* _NILFS_CPFILE_H */
|