Johannes Berg 89d73a97af mac80211: free sta in sta_info_insert_finish() on errors ... commit 7bc40aedf2 upstream. If sta_info_insert_finish() fails, we currently keep the station around and free it only in the caller, but there's only one such caller and it always frees it immediately. As syzbot found, another consequence of this split is that we can put things that sleep only into __cleanup_single_sta() and not in sta_info_free(), but this is the only place that requires such of sta_info_free() now. Change this to free the station in sta_info_insert_finish(), in which case we can still sleep. This will also let us unify the cleanup code later. Cc: stable@vger.kernel.org Fixes: dcd479e10a ("mac80211: always wind down STA state") Reported-by: syzbot+32c6c38c4812d22f2f0b@syzkaller.appspotmail.com Reported-by: syzbot+4c81fe92e372d26c4246@syzkaller.appspotmail.com Reported-by: syzbot+6a7fe9faf0d1d61bc24a@syzkaller.appspotmail.com Reported-by: syzbot+abed06851c5ffe010921@syzkaller.appspotmail.com Reported-by: syzbot+b7aeb9318541a1c709f1@syzkaller.appspotmail.com Reported-by: syzbot+d5a9416c6cafe53b5dd0@syzkaller.appspotmail.com Link: https://lore.kernel.org/r/20201112112201.ee6b397b9453.I9c31d667a0ea2151441cc64ed6613d36c18a48e0@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2020-11-24 13:29:23 +01:00
..
Kconfig	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2019-07-08 20:57:08 -07:00
Makefile	mac80211: minstrel: merge with minstrel_ht, always enable VHT support	2018-10-11 16:01:01 +02:00
aead_api.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aead_api.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aes_ccm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aes_cmac.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aes_cmac.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aes_gcm.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aes_gmac.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
aes_gmac.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
agg-rx.c	mac80211: add missing null return check from call to ieee80211_get_sband	2019-07-31 10:51:17 +02:00
agg-tx.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
cfg.c	mac80211: handle lack of sband->bitrates in rates	2020-10-29 09:58:04 +01:00
chan.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
debug.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
debugfs.c	mac80211: AMPDU handling for rekeys with Extended Key ID	2019-07-26 13:29:10 +02:00
debugfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
debugfs_key.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-22 08:59:24 -04:00
debugfs_key.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
debugfs_netdev.c	mac80211: fix txq null pointer dereference	2019-10-01 17:56:19 +02:00
debugfs_netdev.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
debugfs_sta.c	mac80211: drop data frames without key on encrypted links	2020-04-01 11:02:01 +02:00
debugfs_sta.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
driver-ops.c	mac80211: don't warn about CW params when not using them	2019-07-20 21:40:32 +02:00
driver-ops.h	mac80211: pass the vif to cancel_remain_on_channel	2019-07-26 13:08:28 +02:00
ethtool.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 432	2019-06-05 17:37:16 +02:00
fils_aead.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
fils_aead.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
he.c	mac80211: fix possible NULL pointerderef in obss pd code	2019-08-21 10:58:32 +02:00
ht.c	mac80211: add support for the ADDBA extension element	2019-07-29 16:40:22 +02:00
ibss.c	mac80211: IBSS: send deauth when expiring inactive STAs	2019-09-11 09:33:29 +02:00
ieee80211_i.h	mac80211: IBSS: send deauth when expiring inactive STAs	2019-09-11 09:33:29 +02:00
iface.c	mac80211: allow drivers to set max MTU	2019-09-11 09:33:29 +02:00
key.c	mac80211: drop data frames without key on encrypted links	2020-04-01 11:02:01 +02:00
key.h	mac80211: clear crypto tx tailroom counter upon keys enable	2019-09-11 09:33:28 +02:00
led.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
led.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
main.c	mac80211: populate debugfs only after cfg80211 init	2020-04-29 16:33:18 +02:00
mesh.c	mac80211: fix channel switch trigger from unknown mesh peer	2020-05-02 08:48:58 +02:00
mesh.h	mac80211: implement HE support for mesh	2019-07-26 16:14:12 +02:00
mesh_hwmp.c	mac80211: mesh: fix discovery timer re-arming issue / crash	2020-06-03 08:21:30 +02:00
mesh_pathtbl.c	mac80211: mesh: Free pending skb when destroying a mpath	2020-08-05 09:59:48 +02:00
mesh_plink.c	mac80211: implement HE support for mesh	2019-07-26 16:14:12 +02:00
mesh_ps.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
mesh_sync.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
michael.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
michael.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
mlme.c	mac80211: add ieee80211_is_any_nullfunc()	2020-05-10 10:31:32 +02:00
ocb.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
offchannel.c	mac80211: pass the vif to cancel_remain_on_channel	2019-07-26 13:08:28 +02:00
pm.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
rate.c	mac80211: populate debugfs only after cfg80211 init	2020-04-29 16:33:18 +02:00
rate.h	mac80211: populate debugfs only after cfg80211 init	2020-04-29 16:33:18 +02:00
rc80211_minstrel.c	mac80211: minstrel: fix tx status processing corner case	2020-11-24 13:29:23 +01:00
rc80211_minstrel.h	mac80211: minstrel: remove deferred sampling code	2020-11-24 13:29:23 +01:00
rc80211_minstrel_debugfs.c	mac80211: rc80211_minstrel: remove variance / stddev calculation	2018-10-11 16:01:05 +02:00
rc80211_minstrel_ht.c	mac80211: populate debugfs only after cfg80211 init	2020-04-29 16:33:18 +02:00
rc80211_minstrel_ht.h	mac80211: minstrel_ht: improve rate probing for devices with static fallback	2019-08-21 11:10:13 +02:00
rc80211_minstrel_ht_debugfs.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
rx.c	mac80211: Fix radiotap header channel flag for 6GHz band	2020-10-07 08:01:26 +02:00
scan.c	mac80211: fix scan when operating on DFS channels in ETSI domains	2019-10-07 22:10:50 +02:00
spectmgmt.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sta_info.c	mac80211: free sta in sta_info_insert_finish() on errors	2020-11-24 13:29:23 +01:00
sta_info.h	mac80211: drop data frames without key on encrypted links	2020-04-01 11:02:01 +02:00
status.c	mac80211: add ieee80211_is_any_nullfunc()	2020-05-10 10:31:32 +02:00
tdls.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-06-17 15:55:34 -07:00
tkip.c	mac80211: Fix TKIP replay protection immediately after key setup	2020-02-05 21:22:46 +00:00
tkip.h	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2019-07-08 20:57:08 -07:00
trace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace.h	mac80211: pass the vif to cancel_remain_on_channel	2019-07-26 13:08:28 +02:00
trace_msg.h	mac80211: Increase MAX_MSG_LEN	2019-03-29 11:20:36 +01:00
tx.c	mac80211: fix use of skb payload instead of header	2020-11-18 19:20:23 +01:00
util.c	mac80211: fix wrong 160/80+80 MHz setting	2020-03-05 16:43:41 +01:00
vht.c	mac80211: do not allow bigger VHT MPDUs than the hardware supports	2020-10-07 08:01:27 +02:00
wep.c	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2019-07-08 20:57:08 -07:00
wep.h	Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6	2019-07-08 20:57:08 -07:00
wme.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
wme.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
wpa.c	mac80211: add IEEE80211_KEY_FLAG_GENERATE_MMIE to ieee80211_key_flags	2019-07-26 16:14:12 +02:00
wpa.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00