1
0
Fork 0
alistair23-linux/arch/cris
Julia Lawall 6d9f4c5cfb arch/cris: add a missing iounmap
An extra error handling label is needed for the case where the ioremap has
succeeded.

The problem was detected using the following semantic match
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T,T1,T2;
identifier E;
statement S;
expression x1,x2;
constant C;
int ret;
@@

  T E;
  ...
* E = ioremap(...);
  if (E == NULL) S
  ... when != iounmap(E)
      when != if (E != NULL) { ... iounmap(E); ...}
      when != x1 = (T1)E
  if (...) {
    ... when != iounmap(E)
        when != if (E != NULL) { ... iounmap(E); ...}
        when != x2 = (T2)E
(
*   return;
|
*   return C;
|
*   return ret;
)
  }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Mikael Starvik <starvik@axis.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-05 09:44:24 -08:00
..
arch-v10 CRIS: avoid using arch links in Kconfig 2008-02-05 09:44:24 -08:00
arch-v32 arch/cris: add a missing iounmap 2008-02-05 09:44:24 -08:00
kernel cris build fixes: fix crisksyms.c 2007-11-14 18:45:46 -08:00
mm spelling fixes: arch/cris/ 2007-10-20 01:08:50 +02:00
Kconfig CRIS: avoid using arch links in Kconfig 2008-02-05 09:44:24 -08:00
Kconfig.debug [PATCH] arch/cris/Kconfig.debug: use lib/Kconfig.debug 2005-09-05 00:06:19 -07:00
Makefile kbuild: enable 'make AFLAGS=...' to add additional options to AS 2007-10-15 21:59:31 +02:00
defconfig CRIS: remove MTD_AMSTD and MTD_OBSOLETE_CHIPS take two 2007-11-14 18:45:46 -08:00