1
0
Fork 0
alistair23-linux/drivers/net/wireless/ath/wcn36xx
Arnd Bergmann 355cf31912 wcn36xx: use dynamic allocation for large variables
clang triggers a warning about oversized stack frames that gcc does not
notice because of slightly different inlining decisions:

ath/wcn36xx/smd.c:1409:5: error: stack frame size of 1040 bytes in function 'wcn36xx_smd_config_bss' [-Werror,-Wframe-larger-than=]
ath/wcn36xx/smd.c:640:5: error: stack frame size of 1032 bytes in function 'wcn36xx_smd_start_hw_scan' [-Werror,-Wframe-larger-than=]

Basically the wcn36xx_hal_start_scan_offload_req_msg,
wcn36xx_hal_config_bss_req_msg_v1, and wcn36xx_hal_config_bss_req_msg
structures are too large to be put on the kernel stack, but small
enough that gcc does not warn about them.

Use kzalloc() to allocate them all. There are similar structures in other
parts of this driver, but they are all smaller, with the next largest
stack frame at 480 bytes for wcn36xx_smd_send_beacon.

Fixes: 8e84c25821 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2019-09-04 09:22:26 +03:00
..
Kconfig ath: fix SPDX tags 2019-06-26 18:11:06 +03:00
Makefile ath: fix SPDX tags 2019-06-26 18:11:06 +03:00
debug.c wireless: Use octal not symbolic permissions 2018-03-27 11:01:13 +03:00
debug.h
dxe.c cross-tree: phase out dma_zalloc_coherent() 2019-01-08 07:58:37 -05:00
dxe.h wcn36xx: Remove useless skb spinlock 2018-04-10 17:39:50 +03:00
hal.h wcn36xx: Add support for Factory Test Mode (FTM) 2018-05-25 13:17:28 +03:00
main.c wcn36xx: drop unnecessary initialization of variables 2018-07-02 17:26:57 +03:00
pmc.c wcn36xx: Fix dynamic power saving 2018-01-04 18:41:48 +02:00
pmc.h
smd.c wcn36xx: use dynamic allocation for large variables 2019-09-04 09:22:26 +03:00
smd.h wcn36xx: Add support for Factory Test Mode (FTM) 2018-05-25 13:17:28 +03:00
testmode.c netlink: make validation more configurable for future strictness 2019-04-27 17:07:21 -04:00
testmode.h wcn36xx: Add support for Factory Test Mode (FTM) 2018-05-25 13:17:28 +03:00
testmode_i.h wcn36xx: Add support for Factory Test Mode (FTM) 2018-05-25 13:17:28 +03:00
txrx.c wcn36xx: don't keep reference to skb if transmission failed 2018-04-10 17:34:14 +03:00
txrx.h wcn36xx: let device generate qos seq numbers 2015-01-23 19:11:58 +02:00
wcn36xx.h wcn36xx: Track associated stations 2018-06-29 14:59:07 +03:00