1
0
Fork 0
alistair23-linux/scripts/package
Masahiro Yamada 262dad68e1 kbuild: pkg: make out-of-tree rpm/deb-pkg build immediately fail
We do not support out-of-tree building of rpm-pkg / deb-pkg.  If O=
is given, the build should be terminated, but the "false" command is
not effective since it is not the last command in the cmd_src_tar.
Then, rpm-pkg / deb-pkg tries to continue building, and fails for a
different reason.

Set -e option so that the "false" terminates the building immediately.

I also put the error messages to stderr, and made it stand out more.

For example, "make O=foo rpm-pkg" will fail as follows:

  /bin/bash ../scripts/package/mkspec >./kernel.spec
    TAR     kernel-4.15.0_rc2+.tar.gz

    ERROR:
    Building source tarball is not possible outside the
    kernel source tree. Don't set KBUILD_OUTPUT, or use the
    binrpm-pkg or bindeb-pkg target instead.

  ../scripts/package/Makefile:53: recipe for target 'rpm-pkg' failed

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: Jim Davis <jim.epost@gmail.com>
2017-12-13 00:07:00 +09:00
..
Makefile kbuild: pkg: make out-of-tree rpm/deb-pkg build immediately fail 2017-12-13 00:07:00 +09:00
builddeb builddeb: Pass the kernel:debarch substvar to dpkg-genchanges 2017-11-14 23:19:05 +09:00
buildtar License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
mkspec kbuild: rpm-pkg: replace $RPM_BUILD_ROOT with %{buildroot} 2017-11-14 23:19:01 +09:00
snapcraft.template scripts/package: snap-pkg target 2017-12-13 00:00:18 +09:00