6ec4476ac8
I realize that we fairly recently raised it to 4.8, but the fact is, 4.9
is a much better minimum version to target.
We have a number of workarounds for actual bugs in pre-4.9 gcc versions
(including things like internal compiler errors on ARM), but we also
have some syntactic workarounds for lacking features.
In particular, raising the minimum to 4.9 means that we can now just
assume _Generic() exists, which is likely the much better replacement
for a lot of very convoluted built-time magic with conditionals on
sizeof and/or __builtin_choose_expr() with same_type() etc.
Using _Generic also means that you will need to have a very recent
version of 'sparse', but thats easy to build yourself, and much less of
a hassle than some old gcc version can be.
The latest (in a long string) of reasons for minimum compiler version
upgrades was commit 5435f73d5c ("efi/x86: Fix build with gcc 4").
Ard points out that RHEL 7 uses gcc-4.8, but the people who stay back on
old RHEL versions persumably also don't build their own kernels anyway.
And maybe they should cross-built or just have a little side affair with
a newer compiler?
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
47 lines
1.4 KiB
C
47 lines
1.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __LINUX_BITS_H
|
|
#define __LINUX_BITS_H
|
|
|
|
#include <linux/const.h>
|
|
#include <vdso/bits.h>
|
|
#include <asm/bitsperlong.h>
|
|
|
|
#define BIT_ULL(nr) (ULL(1) << (nr))
|
|
#define BIT_MASK(nr) (UL(1) << ((nr) % BITS_PER_LONG))
|
|
#define BIT_WORD(nr) ((nr) / BITS_PER_LONG)
|
|
#define BIT_ULL_MASK(nr) (ULL(1) << ((nr) % BITS_PER_LONG_LONG))
|
|
#define BIT_ULL_WORD(nr) ((nr) / BITS_PER_LONG_LONG)
|
|
#define BITS_PER_BYTE 8
|
|
|
|
/*
|
|
* Create a contiguous bitmask starting at bit position @l and ending at
|
|
* position @h. For example
|
|
* GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
|
|
*/
|
|
#if !defined(__ASSEMBLY__)
|
|
#include <linux/build_bug.h>
|
|
#define GENMASK_INPUT_CHECK(h, l) \
|
|
(BUILD_BUG_ON_ZERO(__builtin_choose_expr( \
|
|
__builtin_constant_p((l) > (h)), (l) > (h), 0)))
|
|
#else
|
|
/*
|
|
* BUILD_BUG_ON_ZERO is not available in h files included from asm files,
|
|
* disable the input check if that is the case.
|
|
*/
|
|
#define GENMASK_INPUT_CHECK(h, l) 0
|
|
#endif
|
|
|
|
#define __GENMASK(h, l) \
|
|
(((~UL(0)) - (UL(1) << (l)) + 1) & \
|
|
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
|
|
#define GENMASK(h, l) \
|
|
(GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
|
|
|
|
#define __GENMASK_ULL(h, l) \
|
|
(((~ULL(0)) - (ULL(1) << (l)) + 1) & \
|
|
(~ULL(0) >> (BITS_PER_LONG_LONG - 1 - (h))))
|
|
#define GENMASK_ULL(h, l) \
|
|
(GENMASK_INPUT_CHECK(h, l) + __GENMASK_ULL(h, l))
|
|
|
|
#endif /* __LINUX_BITS_H */
|