Stanislav Yakovlev aac495a800 net/wireless: ipw2100: Fix WARN_ON occurring in wiphy_register called by ipw2100_pci_init_one ... The problem was found by Larry Finger: http://marc.info/?l=linux-wireless&m=133702401700614&w=2 The problem is identical to the one for ipw2200 which is already fixed: http://marc.info/?l=linux-wireless&m=133457257407196&w=2 [ 17.766431] ------------[ cut here ]------------ [ 17.766467] WARNING: at net/wireless/core.c:562 wiphy_register+0x34c/0x3c0 [cfg80211]() [ 17.766471] Hardware name: Latitude D600 [ 17.766474] Modules linked in: ipw2100(+) libipw pcmcia cfg80211 ppdev parport_pc yenta_socket sr_mod pcmcia_rsrc parport iTCO_wdt cdrom sg rfkill pcmcia_ core lib80211 tg3 video button battery ac iTCO_vendor_support joydev shpchp pcspkr pciehp pci_hotplug autofs4 radeon ttm drm_kms_helper uhci_hcd ehci_hcd rtc _cmos thermal drm hwmon i2c_algo_bit i2c_core processor usbcore usb_common ata_generic ata_piix ahci libahci libata [ 17.766525] Pid: 474, comm: modprobe Not tainted 3.4.0-rc7-wl+ #6 [ 17.766528] Call Trace: [ 17.766541] [<c066ad08>] ? printk+0x28/0x2a [ 17.766552] [<c0230edd>] warn_slowpath_common+0x6d/0xa0 [ 17.766563] [<e0b253bc>] ? wiphy_register+0x34c/0x3c0 [cfg80211] [ 17.766573] [<e0b253bc>] ? wiphy_register+0x34c/0x3c0 [cfg80211] [ 17.766578] [<c0230f2d>] warn_slowpath_null+0x1d/0x20 [ 17.766588] [<e0b253bc>] wiphy_register+0x34c/0x3c0 [cfg80211] [ 17.766605] [<e0b5b0d6>] ipw2100_wdev_init+0x196/0x1c0 [ipw2100] [ 17.766616] [<e0b5d962>] ipw2100_pci_init_one+0x2b2/0x694 [ipw2100] [ 17.766632] [<c047ce52>] local_pci_probe+0x42/0xb0 [ 17.766637] [<c047e2b0>] pci_device_probe+0x60/0x90 [ 17.766645] [<c0376de2>] ? sysfs_create_link+0x12/0x20 [ 17.766654] [<c050f1f6>] really_probe+0x56/0x2e0 [ 17.766659] [<c037636d>] ? create_dir+0x5d/0xa0 [ 17.766667] [<c0518c6b>] ? pm_runtime_barrier+0x3b/0xa0 [ 17.766672] [<c050f5e4>] driver_probe_device+0x44/0xa0 [ 17.766677] [<c047e227>] ? pci_match_device+0x97/0xa0 [ 17.766681] [<c050f6c9>] __driver_attach+0x89/0x90 [ 17.766686] [<c050f640>] ? driver_probe_device+0xa0/0xa0 [ 17.766691] [<c050da2a>] bus_for_each_dev+0x3a/0x70 [ 17.766695] [<c050ee6c>] driver_attach+0x1c/0x30 [ 17.766699] [<c050f640>] ? driver_probe_device+0xa0/0xa0 [ 17.766704] [<c050ea77>] bus_add_driver+0x187/0x280 [ 17.766710] [<c045b9cd>] ? kset_find_obj+0x2d/0x60 [ 17.766715] [<c047e2e0>] ? pci_device_probe+0x90/0x90 [ 17.766719] [<c047e2e0>] ? pci_device_probe+0x90/0x90 [ 17.766724] [<c050fb85>] driver_register+0x65/0x110 [ 17.766729] [<c047e09d>] __pci_register_driver+0x3d/0xa0 [ 17.766738] [<e09f705c>] ipw2100_init+0x5c/0x1000 [ipw2100] [ 17.766743] [<c020110f>] do_one_initcall+0x2f/0x170 [ 17.766749] [<e09f7000>] ? 0xe09f6fff [ 17.766757] [<c0287ce8>] sys_init_module+0xa8/0x210 [ 17.766766] [<c067a075>] syscall_call+0x7/0xb [ 17.766769] ---[ end trace 559898c6bb0d1c75 ]--- [ 17.767093] ipw2100: probe of 0000:02:03.0 failed with error -5 This warning appears only if we apply Ben Hutchings' fix http://marc.info/?l=linux-wireless&m=132720204412667&w=2 for the bug reported by Cesare Leonardi http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656813 with cfg80211 warning during device registration ("cfg80211: failed to add phy80211 symlink to netdev!"). We separate device bring up and registration with network stack to avoid the problem. Signed-off-by: Stanislav Yakovlev <stas.yakovlev@gmail.com> Tested-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>		2012-06-08 13:43:57 -04:00
..
accessibility
acpi	x86, realmode: Unbreak the ia64 build of drivers/acpi/sleep.c	2012-05-30 10:12:48 -07:00
amba	arm-soc: driver specific updates	2012-05-26 12:22:27 -07:00
ata	arm-soc: clock driver changes	2012-05-26 12:42:29 -07:00
atm	solos-pci: Fix DMA support	2012-05-24 16:22:53 -04:00
auxdisplay
base	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2012-06-01 10:34:35 -07:00
bcma	bcma: add ext PA workaround for BCM4331 and BCM43431	2012-06-04 15:26:40 -04:00
block	mtip32xx: Changes to sysfs entries	2012-05-31 08:46:50 +02:00
bluetooth	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2012-05-24 11:54:29 -07:00
cdrom
char	Merge branch 'drm-core-next' of git://people.freedesktop.org/~airlied/linux	2012-05-24 12:42:54 -07:00
clk	arm-soc: soc specific changes, part 2	2012-05-26 13:05:55 -07:00
clocksource
connector
cpufreq
cpuidle
crypto	arm-soc: clock driver changes	2012-05-26 12:42:29 -07:00
dca
devfreq	Power management updates for 3.5	2012-05-23 14:07:06 -07:00
dio
dma	arm-soc: device tree conversions, part 2	2012-05-26 12:57:47 -07:00
edac	Merge branch 'x86/trampoline' into x86/urgent	2012-05-30 12:11:32 -07:00
eisa
extcon	Driver core pull for 3.5-rc1	2012-05-22 16:02:13 -07:00
firewire	IEEE 1394 (FireWire) subsystem updates post v3.4:	2012-05-24 12:57:47 -07:00
firmware
gpio	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2012-05-29 18:27:19 -07:00
gpu	Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux	2012-06-01 15:40:29 -07:00
hid	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2012-05-22 19:22:50 -07:00
hsi
hv	Driver core pull for 3.5-rc1	2012-05-22 16:02:13 -07:00
hwmon	hwmon/sch56xx: Depend on watchdog for watchdog core functions	2012-05-30 07:56:20 +02:00
hwspinlock
i2c	i2c: Split I2C_M_NOSTART support out of I2C_FUNC_PROTOCOL_MANGLING	2012-05-30 10:55:34 +02:00
ide
idle
ieee802154
iio
infiniband	InfiniBand/RDMA changes for the 3.5 merge window:	2012-05-21 17:54:55 -07:00
input	i2c: Split I2C_M_NOSTART support out of I2C_FUNC_PROTOCOL_MANGLING	2012-05-30 10:55:34 +02:00
iommu	IOMMU Updates for Linux 3.5	2012-05-30 08:49:28 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2012-05-24 11:54:29 -07:00
leds	leds: add LM3533 LED driver	2012-05-29 16:22:32 -07:00
lguest
macintosh
md	Improve multipath's retrying mechanism in some defined circumstances	2012-06-02 17:39:40 -07:00
media	arm-soc: clock driver changes	2012-05-26 12:42:29 -07:00
memory
memstick
message	Merge branch 'akpm' (Andrew's patch-bomb)	2012-05-31 18:10:18 -07:00
mfd	ARM: ux500: Provide regulator support for SMSC911x via Device Tree	2012-06-01 02:04:46 +02:00
misc	MFD changes for 3.5	2012-05-29 11:53:11 -07:00
mmc	arm-soc: device tree conversions, part 2	2012-05-26 12:57:47 -07:00
mtd	- More robust parsing especially of xattr data in JFFS2	2012-06-01 16:55:42 -07:00
net	net/wireless: ipw2100: Fix WARN_ON occurring in wiphy_register called by ipw2100_pci_init_one	2012-06-08 13:43:57 -04:00
nfc	NFC: potential integer overflow problem in check_crc()	2012-05-25 11:16:16 -04:00
nubus
of	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2012-05-29 18:27:19 -07:00
oprofile
parisc	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2012-05-22 19:22:50 -07:00
parport	Driver core pull for 3.5-rc1	2012-05-22 16:02:13 -07:00
pci	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2012-05-29 18:27:19 -07:00
pcmcia
pinctrl	pinctrl-nomadik: Allow Device Tree driver probing	2012-06-01 02:03:25 +02:00
platform	apple-gmux: Fix up the suspend/resume patch	2012-06-01 15:18:52 -04:00
pnp
power	A bunch of fixes for v3.5, nothing extraordinary.	2012-05-31 12:10:15 -07:00
pps
ps3
ptp	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2012-05-22 19:22:50 -07:00
rapidio	rapidio/tsi721: add DMA engine support	2012-05-31 17:49:31 -07:00
regulator	MFD changes for 3.5	2012-05-29 11:53:11 -07:00
remoteproc	IOMMU Updates for Linux 3.5	2012-05-30 08:49:28 -07:00
rpmsg
rtc	drivers/rtc/rtc-s3c.c: fix compiler warning	2012-05-29 16:22:34 -07:00
s390	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux	2012-05-31 10:51:10 -07:00
sbus
scsi	SCSI misc on 20120531	2012-05-31 12:02:41 -07:00
sfi
sh	sh: intc: Kill off special reservation interface.	2012-05-22 19:07:55 +09:00
sn
spi	arm-soc: soc specific changes, part 2	2012-05-26 13:05:55 -07:00
ssb
staging	mm/fs: route MADV_REMOVE to FALLOC_FL_PUNCH_HOLE	2012-05-29 16:22:22 -07:00
target	Merge branch 'sbp-target-merge' of git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending	2012-05-23 16:52:27 -07:00
tc
thermal
tty	tty: Revert the tty locking series, it needs more work	2012-06-02 15:21:43 -07:00
uio
usb	arm-soc: clock driver changes	2012-05-26 12:42:29 -07:00
uwb
vhost
video	fbdev updates for 3.5	2012-06-01 16:57:51 -07:00
virt
virtio	virtio-mmio: Devices parameter parsing	2012-05-22 12:16:15 +09:30
vlynq
vme
w1	arm-soc: clock driver changes	2012-05-26 12:42:29 -07:00
watchdog	watchdog: iTCO_wdt.c: fix printk format warnings	2012-05-30 08:16:48 +02:00
xen	Merge branch 'x86-trampoline-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2012-05-29 20:14:53 -07:00
zorro
Kconfig	Staging tree pull request for 3.5-rc1	2012-05-22 16:34:21 -07:00
Makefile	arm-soc: driver specific updates	2012-05-26 12:22:27 -07:00