![Grygorii Strashko](/assets/img/avatar_default.png)
Kernel fails to boot 50% of times (form build to build) with
RT-patchset applied due to the following race - on late boot
stages deferred_probe_work_func->omap_hsmmc_probe races with omap_device_late_ini.
The same issue has been reported now on linux-next (4.3) by Keerthy [1]
late_initcall
- deferred_probe_initcal() tries to re-probe all pending driver's probe.
- later on, some driver is probing in this case It's cpsw.c
(but could be any other drivers)
cpsw_init
- platform_driver_register
- really_probe
- driver_bound
- driver_deferred_probe_trigger
and boot proceed.
So, at this moment we have deferred_probe_work_func scheduled.
late_initcall_sync
- omap_device_late_init
- omap_device_idle
CPU1 CPU2
- deferred_probe_work_func
- really_probe
- omap_hsmmc_probe
- pm_runtime_get_sync
late_initcall_sync
- omap_device_late_init
if (od->_driver_status != BUS_NOTIFY_BOUND_DRIVER) {
if (od->_state == OMAP_DEVICE_STATE_ENABLED) {
- omap_device_idle [ops - IP is disabled]
- [fail]
- pm_runtime_put_sync
- omap_hsmmc_runtime_suspend [ooops!]
== log ==
omap_hsmmc 480b4000.mmc: unable to get vmmc regulator -517
davinci_mdio 48485000.mdio: davinci mdio revision 1.6
davinci_mdio 48485000.mdio: detected phy mask fffffff3
libphy: 48485000.mdio: probed
davinci_mdio 48485000.mdio: phy[2]: device 48485000.mdio:02, driver unknown
davinci_mdio 48485000.mdio: phy[3]: device 48485000.mdio:03, driver unknown
omap_hsmmc 480b4000.mmc: unable to get vmmc regulator -517
cpsw 48484000.ethernet: Detected MACID = b4:99:4c:c7:d2:48
cpsw 48484000.ethernet: cpsw: Detected MACID = b4:99:4c:c7:d2:49
hctosys: unable to open rtc device (rtc0)
omap_hsmmc 480b4000.mmc: omap_device_late_idle: enabled but no driver. Idling
ldousb: disabling
Unhandled fault: imprecise external abort (0x1406) at 0x00000000
[00000000] *pgd=00000000
Internal error: : 1406 [#1] PREEMPT SMP ARM
Modules linked in:
CPU: 1 PID: 58 Comm: kworker/u4:1 Not tainted 4.1.2-rt1-00467-g6da3c0a-dirty #5
Hardware name: Generic DRA74X (Flattened Device Tree)
Workqueue: deferwq deferred_probe_work_func
task: ee6ddb00 ti: edd3c000 task.ti: edd3c000
PC is at omap_hsmmc_runtime_suspend+0x1c/0x12c
LR is at _od_runtime_suspend+0xc/0x24
pc : [<c0471998>] lr : [<c0029590>] psr: a0000013
sp : edd3dda0 ip : ee6ddb00 fp : c07be540
r10: 00000000 r9 : c07be540 r8 : 00000008
r7 : 00000000 r6 : ee646c10 r5 : ee646c10 r4 : edd79380
r3 : fa0b4100 r2 : 00000000 r1 : 00000000 r0 : ee646c10
Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
Control: 10c5387d Table: 8000406a
DAC: 00000015
Process kworker/u4:1 (pid: 58, stack limit = 0xedd3c218)
Stack: (0xedd3dda0 to 0xedd3e000)
dda0: ee646c70 ee646c10 c0029584 00000000 00000008 c0029590 ee646c70 ee646c10
ddc0: c0029584 c03adfb8 ee646c10 00000004 0000000c c03adff0 ee646c10 00000004
dde0: 0000000c c03ae4ec 00000000 edd3c000 ee646c10 00000004 ee646c70 00000004
de00: fa0b4000 c03aec20 ee6ddb00 ee646c10 00000004 ee646c70 ee646c10 fffffdfb
de20: edd79380 00000000 fa0b4000 c03aee90 fffffdfb edd79000 ee646c00 c0474290
de40: 00000000 edda24c0 edd79380 edc81f00 00000000 00000200 00000001 c06dd488
de60: edda3960 ee646c10 ee646c10 c0824cc4 fffffdfb c0880c94 00000002 edc92600
de80: c0836378 c03a7f84 ee646c10 c0824cc4 00000000 c0880c80 c0880c94 c03a6568
dea0: 00000000 ee646c10 c03a66ac ee4f8000 00000000 00000001 edc92600 c03a4b40
dec0: ee404c94 edc83c4c ee646c10 ee646c10 ee646c44 c03a63c4 ee646c10 ee646c10
dee0: c0814448 c03a5aa8 ee646c10 c0814220 edd3c000 c03a5ec0 c0814250 ee6be400
df00: edd3c000 c004e5bc ee6ddb01 00000078 ee6ddb00 ee4f8000 ee6be418 edd3c000
df20: ee4f8028 00000088 c0836045 ee4f8000 ee6be400 c004e928 ee4f8028 00000000
df40: c004e8ec 00000000 ee6bf1c0 ee6be400 c004e8ec 00000000 00000000 00000000
df60: 00000000 c0053450 2e56fa97 00000000 afdffbd7 ee6be400 00000000 00000000
df80: edd3df80 edd3df80 00000000 00000000 edd3df90 edd3df90 edd3dfac ee6bf1c0
dfa0: c0053384 00000000 00000000 c000f668 00000000 00000000 00000000 00000000
dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 f1fc9d7e febfbdff
[<c0471998>] (omap_hsmmc_runtime_suspend) from [<c0029590>] (_od_runtime_suspend+0xc/0x24)
[<c0029590>] (_od_runtime_suspend) from [<c03adfb8>] (__rpm_callback+0x24/0x3c)
[<c03adfb8>] (__rpm_callback) from [<c03adff0>] (rpm_callback+0x20/0x80)
[<c03adff0>] (rpm_callback) from [<c03ae4ec>] (rpm_suspend+0xe4/0x618)
[<c03ae4ec>] (rpm_suspend) from [<c03aee90>] (__pm_runtime_idle+0x60/0x80)
[<c03aee90>] (__pm_runtime_idle) from [<c0474290>] (omap_hsmmc_probe+0x6bc/0xa7c)
[<c0474290>] (omap_hsmmc_probe) from [<c03a7f84>] (platform_drv_probe+0x44/0xa4)
[<c03a7f84>] (platform_drv_probe) from [<c03a6568>] (driver_probe_device+0x170/0x2b4)
[<c03a6568>] (driver_probe_device) from [<c03a4b40>] (bus_for_each_drv+0x64/0x98)
[<c03a4b40>] (bus_for_each_drv) from [<c03a63c4>] (device_attach+0x70/0x88)
[<c03a63c4>] (device_attach) from [<c03a5aa8>] (bus_probe_device+0x84/0xac)
[<c03a5aa8>] (bus_probe_device) from [<c03a5ec0>] (deferred_probe_work_func+0x58/0x88)
[<c03a5ec0>] (deferred_probe_work_func) from [<c004e5bc>] (process_one_work+0x134/0x464)
[<c004e5bc>] (process_one_work) from [<c004e928>] (worker_thread+0x3c/0x4fc)
[<c004e928>] (worker_thread) from [<c0053450>] (kthread+0xcc/0xe4)
[<c0053450>] (kthread) from [<c000f668>] (ret_from_fork+0x14/0x2c)
Code: e594302c e593202c e584205c e594302c (e5932128)
---[ end trace 0000000000000002 ]---
The issue happens because omap_device_late_init() do not take into
account that some drivers are present, but their probes were not
finished successfully and where deferred instead. This is the valid
case, and omap_device_late_init() should not idle such devices.
To fix this issue, the value of omap_device->_driver_status field
should be checked not only for BUS_NOTIFY_BOUND_DRIVER (driver is
present and has been bound to device successfully), but also checked
for BUS_NOTIFY_BIND_DRIVER (driver about to be bound) - which means
driver is present and there was try to bind it to device.
[1] http://www.spinics.net/lists/arm-kernel/msg441880.html
Cc: Tero Kristo <t-kristo@ti.com>
Cc: Keerthy <j-keerthy@ti.com>
Tested-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
926 lines
24 KiB
C
926 lines
24 KiB
C
/*
|
|
* omap_device implementation
|
|
*
|
|
* Copyright (C) 2009-2010 Nokia Corporation
|
|
* Paul Walmsley, Kevin Hilman
|
|
*
|
|
* Developed in collaboration with (alphabetical order): Benoit
|
|
* Cousson, Thara Gopinath, Tony Lindgren, Rajendra Nayak, Vikram
|
|
* Pandita, Sakari Poussa, Anand Sawant, Santosh Shilimkar, Richard
|
|
* Woodruff
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This code provides a consistent interface for OMAP device drivers
|
|
* to control power management and interconnect properties of their
|
|
* devices.
|
|
*
|
|
* In the medium- to long-term, this code should be implemented as a
|
|
* proper omap_bus/omap_device in Linux, no more platform_data func
|
|
* pointers
|
|
*
|
|
*
|
|
*/
|
|
#undef DEBUG
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/err.h>
|
|
#include <linux/io.h>
|
|
#include <linux/clk.h>
|
|
#include <linux/clkdev.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/of.h>
|
|
#include <linux/notifier.h>
|
|
|
|
#include "common.h"
|
|
#include "soc.h"
|
|
#include "omap_device.h"
|
|
#include "omap_hwmod.h"
|
|
|
|
/* Private functions */
|
|
|
|
static void _add_clkdev(struct omap_device *od, const char *clk_alias,
|
|
const char *clk_name)
|
|
{
|
|
struct clk *r;
|
|
int rc;
|
|
|
|
if (!clk_alias || !clk_name)
|
|
return;
|
|
|
|
dev_dbg(&od->pdev->dev, "Creating %s -> %s\n", clk_alias, clk_name);
|
|
|
|
r = clk_get_sys(dev_name(&od->pdev->dev), clk_alias);
|
|
if (!IS_ERR(r)) {
|
|
dev_dbg(&od->pdev->dev,
|
|
"alias %s already exists\n", clk_alias);
|
|
clk_put(r);
|
|
return;
|
|
}
|
|
|
|
rc = clk_add_alias(clk_alias, dev_name(&od->pdev->dev), clk_name, NULL);
|
|
if (rc) {
|
|
if (rc == -ENODEV || rc == -ENOMEM)
|
|
dev_err(&od->pdev->dev,
|
|
"clkdev_alloc for %s failed\n", clk_alias);
|
|
else
|
|
dev_err(&od->pdev->dev,
|
|
"clk_get for %s failed\n", clk_name);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* _add_hwmod_clocks_clkdev - Add clkdev entry for hwmod optional clocks
|
|
* and main clock
|
|
* @od: struct omap_device *od
|
|
* @oh: struct omap_hwmod *oh
|
|
*
|
|
* For the main clock and every optional clock present per hwmod per
|
|
* omap_device, this function adds an entry in the clkdev table of the
|
|
* form <dev-id=dev_name, con-id=role> if it does not exist already.
|
|
*
|
|
* The function is called from inside omap_device_build_ss(), after
|
|
* omap_device_register.
|
|
*
|
|
* This allows drivers to get a pointer to its optional clocks based on its role
|
|
* by calling clk_get(<dev*>, <role>).
|
|
* In the case of the main clock, a "fck" alias is used.
|
|
*
|
|
* No return value.
|
|
*/
|
|
static void _add_hwmod_clocks_clkdev(struct omap_device *od,
|
|
struct omap_hwmod *oh)
|
|
{
|
|
int i;
|
|
|
|
_add_clkdev(od, "fck", oh->main_clk);
|
|
|
|
for (i = 0; i < oh->opt_clks_cnt; i++)
|
|
_add_clkdev(od, oh->opt_clks[i].role, oh->opt_clks[i].clk);
|
|
}
|
|
|
|
|
|
/**
|
|
* omap_device_build_from_dt - build an omap_device with multiple hwmods
|
|
* @pdev_name: name of the platform_device driver to use
|
|
* @pdev_id: this platform_device's connection ID
|
|
* @oh: ptr to the single omap_hwmod that backs this omap_device
|
|
* @pdata: platform_data ptr to associate with the platform_device
|
|
* @pdata_len: amount of memory pointed to by @pdata
|
|
*
|
|
* Function for building an omap_device already registered from device-tree
|
|
*
|
|
* Returns 0 or PTR_ERR() on error.
|
|
*/
|
|
static int omap_device_build_from_dt(struct platform_device *pdev)
|
|
{
|
|
struct omap_hwmod **hwmods;
|
|
struct omap_device *od;
|
|
struct omap_hwmod *oh;
|
|
struct device_node *node = pdev->dev.of_node;
|
|
const char *oh_name;
|
|
int oh_cnt, i, ret = 0;
|
|
bool device_active = false;
|
|
|
|
oh_cnt = of_property_count_strings(node, "ti,hwmods");
|
|
if (oh_cnt <= 0) {
|
|
dev_dbg(&pdev->dev, "No 'hwmods' to build omap_device\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
hwmods = kzalloc(sizeof(struct omap_hwmod *) * oh_cnt, GFP_KERNEL);
|
|
if (!hwmods) {
|
|
ret = -ENOMEM;
|
|
goto odbfd_exit;
|
|
}
|
|
|
|
for (i = 0; i < oh_cnt; i++) {
|
|
of_property_read_string_index(node, "ti,hwmods", i, &oh_name);
|
|
oh = omap_hwmod_lookup(oh_name);
|
|
if (!oh) {
|
|
dev_err(&pdev->dev, "Cannot lookup hwmod '%s'\n",
|
|
oh_name);
|
|
ret = -EINVAL;
|
|
goto odbfd_exit1;
|
|
}
|
|
hwmods[i] = oh;
|
|
if (oh->flags & HWMOD_INIT_NO_IDLE)
|
|
device_active = true;
|
|
}
|
|
|
|
od = omap_device_alloc(pdev, hwmods, oh_cnt);
|
|
if (IS_ERR(od)) {
|
|
dev_err(&pdev->dev, "Cannot allocate omap_device for :%s\n",
|
|
oh_name);
|
|
ret = PTR_ERR(od);
|
|
goto odbfd_exit1;
|
|
}
|
|
|
|
/* Fix up missing resource names */
|
|
for (i = 0; i < pdev->num_resources; i++) {
|
|
struct resource *r = &pdev->resource[i];
|
|
|
|
if (r->name == NULL)
|
|
r->name = dev_name(&pdev->dev);
|
|
}
|
|
|
|
pdev->dev.pm_domain = &omap_device_pm_domain;
|
|
|
|
if (device_active) {
|
|
omap_device_enable(pdev);
|
|
pm_runtime_set_active(&pdev->dev);
|
|
}
|
|
|
|
odbfd_exit1:
|
|
kfree(hwmods);
|
|
odbfd_exit:
|
|
/* if data/we are at fault.. load up a fail handler */
|
|
if (ret)
|
|
pdev->dev.pm_domain = &omap_device_fail_pm_domain;
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int _omap_device_notifier_call(struct notifier_block *nb,
|
|
unsigned long event, void *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
struct omap_device *od;
|
|
|
|
switch (event) {
|
|
case BUS_NOTIFY_DEL_DEVICE:
|
|
if (pdev->archdata.od)
|
|
omap_device_delete(pdev->archdata.od);
|
|
break;
|
|
case BUS_NOTIFY_ADD_DEVICE:
|
|
if (pdev->dev.of_node)
|
|
omap_device_build_from_dt(pdev);
|
|
omap_auxdata_legacy_init(dev);
|
|
/* fall through */
|
|
default:
|
|
od = to_omap_device(pdev);
|
|
if (od)
|
|
od->_driver_status = event;
|
|
}
|
|
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
/**
|
|
* _omap_device_enable_hwmods - call omap_hwmod_enable() on all hwmods
|
|
* @od: struct omap_device *od
|
|
*
|
|
* Enable all underlying hwmods. Returns 0.
|
|
*/
|
|
static int _omap_device_enable_hwmods(struct omap_device *od)
|
|
{
|
|
int ret = 0;
|
|
int i;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++)
|
|
ret |= omap_hwmod_enable(od->hwmods[i]);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* _omap_device_idle_hwmods - call omap_hwmod_idle() on all hwmods
|
|
* @od: struct omap_device *od
|
|
*
|
|
* Idle all underlying hwmods. Returns 0.
|
|
*/
|
|
static int _omap_device_idle_hwmods(struct omap_device *od)
|
|
{
|
|
int ret = 0;
|
|
int i;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++)
|
|
ret |= omap_hwmod_idle(od->hwmods[i]);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/* Public functions for use by core code */
|
|
|
|
/**
|
|
* omap_device_get_context_loss_count - get lost context count
|
|
* @od: struct omap_device *
|
|
*
|
|
* Using the primary hwmod, query the context loss count for this
|
|
* device.
|
|
*
|
|
* Callers should consider context for this device lost any time this
|
|
* function returns a value different than the value the caller got
|
|
* the last time it called this function.
|
|
*
|
|
* If any hwmods exist for the omap_device assoiated with @pdev,
|
|
* return the context loss counter for that hwmod, otherwise return
|
|
* zero.
|
|
*/
|
|
int omap_device_get_context_loss_count(struct platform_device *pdev)
|
|
{
|
|
struct omap_device *od;
|
|
u32 ret = 0;
|
|
|
|
od = to_omap_device(pdev);
|
|
|
|
if (od->hwmods_cnt)
|
|
ret = omap_hwmod_get_context_loss_count(od->hwmods[0]);
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* omap_device_count_resources - count number of struct resource entries needed
|
|
* @od: struct omap_device *
|
|
* @flags: Type of resources to include when counting (IRQ/DMA/MEM)
|
|
*
|
|
* Count the number of struct resource entries needed for this
|
|
* omap_device @od. Used by omap_device_build_ss() to determine how
|
|
* much memory to allocate before calling
|
|
* omap_device_fill_resources(). Returns the count.
|
|
*/
|
|
static int omap_device_count_resources(struct omap_device *od,
|
|
unsigned long flags)
|
|
{
|
|
int c = 0;
|
|
int i;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++)
|
|
c += omap_hwmod_count_resources(od->hwmods[i], flags);
|
|
|
|
pr_debug("omap_device: %s: counted %d total resources across %d hwmods\n",
|
|
od->pdev->name, c, od->hwmods_cnt);
|
|
|
|
return c;
|
|
}
|
|
|
|
/**
|
|
* omap_device_fill_resources - fill in array of struct resource
|
|
* @od: struct omap_device *
|
|
* @res: pointer to an array of struct resource to be filled in
|
|
*
|
|
* Populate one or more empty struct resource pointed to by @res with
|
|
* the resource data for this omap_device @od. Used by
|
|
* omap_device_build_ss() after calling omap_device_count_resources().
|
|
* Ideally this function would not be needed at all. If omap_device
|
|
* replaces platform_device, then we can specify our own
|
|
* get_resource()/ get_irq()/etc functions that use the underlying
|
|
* omap_hwmod information. Or if platform_device is extended to use
|
|
* subarchitecture-specific function pointers, the various
|
|
* platform_device functions can simply call omap_device internal
|
|
* functions to get device resources. Hacking around the existing
|
|
* platform_device code wastes memory. Returns 0.
|
|
*/
|
|
static int omap_device_fill_resources(struct omap_device *od,
|
|
struct resource *res)
|
|
{
|
|
int i, r;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++) {
|
|
r = omap_hwmod_fill_resources(od->hwmods[i], res);
|
|
res += r;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* _od_fill_dma_resources - fill in array of struct resource with dma resources
|
|
* @od: struct omap_device *
|
|
* @res: pointer to an array of struct resource to be filled in
|
|
*
|
|
* Populate one or more empty struct resource pointed to by @res with
|
|
* the dma resource data for this omap_device @od. Used by
|
|
* omap_device_alloc() after calling omap_device_count_resources().
|
|
*
|
|
* Ideally this function would not be needed at all. If we have
|
|
* mechanism to get dma resources from DT.
|
|
*
|
|
* Returns 0.
|
|
*/
|
|
static int _od_fill_dma_resources(struct omap_device *od,
|
|
struct resource *res)
|
|
{
|
|
int i, r;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++) {
|
|
r = omap_hwmod_fill_dma_resources(od->hwmods[i], res);
|
|
res += r;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* omap_device_alloc - allocate an omap_device
|
|
* @pdev: platform_device that will be included in this omap_device
|
|
* @oh: ptr to the single omap_hwmod that backs this omap_device
|
|
* @pdata: platform_data ptr to associate with the platform_device
|
|
* @pdata_len: amount of memory pointed to by @pdata
|
|
*
|
|
* Convenience function for allocating an omap_device structure and filling
|
|
* hwmods, and resources.
|
|
*
|
|
* Returns an struct omap_device pointer or ERR_PTR() on error;
|
|
*/
|
|
struct omap_device *omap_device_alloc(struct platform_device *pdev,
|
|
struct omap_hwmod **ohs, int oh_cnt)
|
|
{
|
|
int ret = -ENOMEM;
|
|
struct omap_device *od;
|
|
struct resource *res = NULL;
|
|
int i, res_count;
|
|
struct omap_hwmod **hwmods;
|
|
|
|
od = kzalloc(sizeof(struct omap_device), GFP_KERNEL);
|
|
if (!od) {
|
|
ret = -ENOMEM;
|
|
goto oda_exit1;
|
|
}
|
|
od->hwmods_cnt = oh_cnt;
|
|
|
|
hwmods = kmemdup(ohs, sizeof(struct omap_hwmod *) * oh_cnt, GFP_KERNEL);
|
|
if (!hwmods)
|
|
goto oda_exit2;
|
|
|
|
od->hwmods = hwmods;
|
|
od->pdev = pdev;
|
|
|
|
/*
|
|
* Non-DT Boot:
|
|
* Here, pdev->num_resources = 0, and we should get all the
|
|
* resources from hwmod.
|
|
*
|
|
* DT Boot:
|
|
* OF framework will construct the resource structure (currently
|
|
* does for MEM & IRQ resource) and we should respect/use these
|
|
* resources, killing hwmod dependency.
|
|
* If pdev->num_resources > 0, we assume that MEM & IRQ resources
|
|
* have been allocated by OF layer already (through DTB).
|
|
* As preparation for the future we examine the OF provided resources
|
|
* to see if we have DMA resources provided already. In this case
|
|
* there is no need to update the resources for the device, we use the
|
|
* OF provided ones.
|
|
*
|
|
* TODO: Once DMA resource is available from OF layer, we should
|
|
* kill filling any resources from hwmod.
|
|
*/
|
|
if (!pdev->num_resources) {
|
|
/* Count all resources for the device */
|
|
res_count = omap_device_count_resources(od, IORESOURCE_IRQ |
|
|
IORESOURCE_DMA |
|
|
IORESOURCE_MEM);
|
|
} else {
|
|
/* Take a look if we already have DMA resource via DT */
|
|
for (i = 0; i < pdev->num_resources; i++) {
|
|
struct resource *r = &pdev->resource[i];
|
|
|
|
/* We have it, no need to touch the resources */
|
|
if (r->flags == IORESOURCE_DMA)
|
|
goto have_everything;
|
|
}
|
|
/* Count only DMA resources for the device */
|
|
res_count = omap_device_count_resources(od, IORESOURCE_DMA);
|
|
/* The device has no DMA resource, no need for update */
|
|
if (!res_count)
|
|
goto have_everything;
|
|
|
|
res_count += pdev->num_resources;
|
|
}
|
|
|
|
/* Allocate resources memory to account for new resources */
|
|
res = kzalloc(sizeof(struct resource) * res_count, GFP_KERNEL);
|
|
if (!res)
|
|
goto oda_exit3;
|
|
|
|
if (!pdev->num_resources) {
|
|
dev_dbg(&pdev->dev, "%s: using %d resources from hwmod\n",
|
|
__func__, res_count);
|
|
omap_device_fill_resources(od, res);
|
|
} else {
|
|
dev_dbg(&pdev->dev,
|
|
"%s: appending %d DMA resources from hwmod\n",
|
|
__func__, res_count - pdev->num_resources);
|
|
memcpy(res, pdev->resource,
|
|
sizeof(struct resource) * pdev->num_resources);
|
|
_od_fill_dma_resources(od, &res[pdev->num_resources]);
|
|
}
|
|
|
|
ret = platform_device_add_resources(pdev, res, res_count);
|
|
kfree(res);
|
|
|
|
if (ret)
|
|
goto oda_exit3;
|
|
|
|
have_everything:
|
|
pdev->archdata.od = od;
|
|
|
|
for (i = 0; i < oh_cnt; i++) {
|
|
hwmods[i]->od = od;
|
|
_add_hwmod_clocks_clkdev(od, hwmods[i]);
|
|
}
|
|
|
|
return od;
|
|
|
|
oda_exit3:
|
|
kfree(hwmods);
|
|
oda_exit2:
|
|
kfree(od);
|
|
oda_exit1:
|
|
dev_err(&pdev->dev, "omap_device: build failed (%d)\n", ret);
|
|
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
void omap_device_delete(struct omap_device *od)
|
|
{
|
|
if (!od)
|
|
return;
|
|
|
|
od->pdev->archdata.od = NULL;
|
|
kfree(od->hwmods);
|
|
kfree(od);
|
|
}
|
|
|
|
/**
|
|
* omap_device_build - build and register an omap_device with one omap_hwmod
|
|
* @pdev_name: name of the platform_device driver to use
|
|
* @pdev_id: this platform_device's connection ID
|
|
* @oh: ptr to the single omap_hwmod that backs this omap_device
|
|
* @pdata: platform_data ptr to associate with the platform_device
|
|
* @pdata_len: amount of memory pointed to by @pdata
|
|
*
|
|
* Convenience function for building and registering a single
|
|
* omap_device record, which in turn builds and registers a
|
|
* platform_device record. See omap_device_build_ss() for more
|
|
* information. Returns ERR_PTR(-EINVAL) if @oh is NULL; otherwise,
|
|
* passes along the return value of omap_device_build_ss().
|
|
*/
|
|
struct platform_device __init *omap_device_build(const char *pdev_name,
|
|
int pdev_id,
|
|
struct omap_hwmod *oh,
|
|
void *pdata, int pdata_len)
|
|
{
|
|
struct omap_hwmod *ohs[] = { oh };
|
|
|
|
if (!oh)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
return omap_device_build_ss(pdev_name, pdev_id, ohs, 1, pdata,
|
|
pdata_len);
|
|
}
|
|
|
|
/**
|
|
* omap_device_build_ss - build and register an omap_device with multiple hwmods
|
|
* @pdev_name: name of the platform_device driver to use
|
|
* @pdev_id: this platform_device's connection ID
|
|
* @oh: ptr to the single omap_hwmod that backs this omap_device
|
|
* @pdata: platform_data ptr to associate with the platform_device
|
|
* @pdata_len: amount of memory pointed to by @pdata
|
|
*
|
|
* Convenience function for building and registering an omap_device
|
|
* subsystem record. Subsystem records consist of multiple
|
|
* omap_hwmods. This function in turn builds and registers a
|
|
* platform_device record. Returns an ERR_PTR() on error, or passes
|
|
* along the return value of omap_device_register().
|
|
*/
|
|
struct platform_device __init *omap_device_build_ss(const char *pdev_name,
|
|
int pdev_id,
|
|
struct omap_hwmod **ohs,
|
|
int oh_cnt, void *pdata,
|
|
int pdata_len)
|
|
{
|
|
int ret = -ENOMEM;
|
|
struct platform_device *pdev;
|
|
struct omap_device *od;
|
|
|
|
if (!ohs || oh_cnt == 0 || !pdev_name)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
if (!pdata && pdata_len > 0)
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
pdev = platform_device_alloc(pdev_name, pdev_id);
|
|
if (!pdev) {
|
|
ret = -ENOMEM;
|
|
goto odbs_exit;
|
|
}
|
|
|
|
/* Set the dev_name early to allow dev_xxx in omap_device_alloc */
|
|
if (pdev->id != -1)
|
|
dev_set_name(&pdev->dev, "%s.%d", pdev->name, pdev->id);
|
|
else
|
|
dev_set_name(&pdev->dev, "%s", pdev->name);
|
|
|
|
od = omap_device_alloc(pdev, ohs, oh_cnt);
|
|
if (IS_ERR(od))
|
|
goto odbs_exit1;
|
|
|
|
ret = platform_device_add_data(pdev, pdata, pdata_len);
|
|
if (ret)
|
|
goto odbs_exit2;
|
|
|
|
ret = omap_device_register(pdev);
|
|
if (ret)
|
|
goto odbs_exit2;
|
|
|
|
return pdev;
|
|
|
|
odbs_exit2:
|
|
omap_device_delete(od);
|
|
odbs_exit1:
|
|
platform_device_put(pdev);
|
|
odbs_exit:
|
|
|
|
pr_err("omap_device: %s: build failed (%d)\n", pdev_name, ret);
|
|
|
|
return ERR_PTR(ret);
|
|
}
|
|
|
|
#ifdef CONFIG_PM
|
|
static int _od_runtime_suspend(struct device *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
int ret;
|
|
|
|
ret = pm_generic_runtime_suspend(dev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return omap_device_idle(pdev);
|
|
}
|
|
|
|
static int _od_runtime_resume(struct device *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
int ret;
|
|
|
|
ret = omap_device_enable(pdev);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return pm_generic_runtime_resume(dev);
|
|
}
|
|
|
|
static int _od_fail_runtime_suspend(struct device *dev)
|
|
{
|
|
dev_warn(dev, "%s: FIXME: missing hwmod/omap_dev info\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
static int _od_fail_runtime_resume(struct device *dev)
|
|
{
|
|
dev_warn(dev, "%s: FIXME: missing hwmod/omap_dev info\n", __func__);
|
|
return -ENODEV;
|
|
}
|
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_SUSPEND
|
|
static int _od_suspend_noirq(struct device *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
struct omap_device *od = to_omap_device(pdev);
|
|
int ret;
|
|
|
|
/* Don't attempt late suspend on a driver that is not bound */
|
|
if (od->_driver_status != BUS_NOTIFY_BOUND_DRIVER)
|
|
return 0;
|
|
|
|
ret = pm_generic_suspend_noirq(dev);
|
|
|
|
if (!ret && !pm_runtime_status_suspended(dev)) {
|
|
if (pm_generic_runtime_suspend(dev) == 0) {
|
|
pm_runtime_set_suspended(dev);
|
|
omap_device_idle(pdev);
|
|
od->flags |= OMAP_DEVICE_SUSPENDED;
|
|
}
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int _od_resume_noirq(struct device *dev)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
struct omap_device *od = to_omap_device(pdev);
|
|
|
|
if (od->flags & OMAP_DEVICE_SUSPENDED) {
|
|
od->flags &= ~OMAP_DEVICE_SUSPENDED;
|
|
omap_device_enable(pdev);
|
|
/*
|
|
* XXX: we run before core runtime pm has resumed itself. At
|
|
* this point in time, we just restore the runtime pm state and
|
|
* considering symmetric operations in resume, we donot expect
|
|
* to fail. If we failed, something changed in core runtime_pm
|
|
* framework OR some device driver messed things up, hence, WARN
|
|
*/
|
|
WARN(pm_runtime_set_active(dev),
|
|
"Could not set %s runtime state active\n", dev_name(dev));
|
|
pm_generic_runtime_resume(dev);
|
|
}
|
|
|
|
return pm_generic_resume_noirq(dev);
|
|
}
|
|
#else
|
|
#define _od_suspend_noirq NULL
|
|
#define _od_resume_noirq NULL
|
|
#endif
|
|
|
|
struct dev_pm_domain omap_device_fail_pm_domain = {
|
|
.ops = {
|
|
SET_RUNTIME_PM_OPS(_od_fail_runtime_suspend,
|
|
_od_fail_runtime_resume, NULL)
|
|
}
|
|
};
|
|
|
|
struct dev_pm_domain omap_device_pm_domain = {
|
|
.ops = {
|
|
SET_RUNTIME_PM_OPS(_od_runtime_suspend, _od_runtime_resume,
|
|
NULL)
|
|
USE_PLATFORM_PM_SLEEP_OPS
|
|
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(_od_suspend_noirq,
|
|
_od_resume_noirq)
|
|
}
|
|
};
|
|
|
|
/**
|
|
* omap_device_register - register an omap_device with one omap_hwmod
|
|
* @od: struct omap_device * to register
|
|
*
|
|
* Register the omap_device structure. This currently just calls
|
|
* platform_device_register() on the underlying platform_device.
|
|
* Returns the return value of platform_device_register().
|
|
*/
|
|
int omap_device_register(struct platform_device *pdev)
|
|
{
|
|
pr_debug("omap_device: %s: registering\n", pdev->name);
|
|
|
|
pdev->dev.pm_domain = &omap_device_pm_domain;
|
|
return platform_device_add(pdev);
|
|
}
|
|
|
|
|
|
/* Public functions for use by device drivers through struct platform_data */
|
|
|
|
/**
|
|
* omap_device_enable - fully activate an omap_device
|
|
* @od: struct omap_device * to activate
|
|
*
|
|
* Do whatever is necessary for the hwmods underlying omap_device @od
|
|
* to be accessible and ready to operate. This generally involves
|
|
* enabling clocks, setting SYSCONFIG registers; and in the future may
|
|
* involve remuxing pins. Device drivers should call this function
|
|
* indirectly via pm_runtime_get*(). Returns -EINVAL if called when
|
|
* the omap_device is already enabled, or passes along the return
|
|
* value of _omap_device_enable_hwmods().
|
|
*/
|
|
int omap_device_enable(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct omap_device *od;
|
|
|
|
od = to_omap_device(pdev);
|
|
|
|
if (od->_state == OMAP_DEVICE_STATE_ENABLED) {
|
|
dev_warn(&pdev->dev,
|
|
"omap_device: %s() called from invalid state %d\n",
|
|
__func__, od->_state);
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = _omap_device_enable_hwmods(od);
|
|
|
|
if (ret == 0)
|
|
od->_state = OMAP_DEVICE_STATE_ENABLED;
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* omap_device_idle - idle an omap_device
|
|
* @od: struct omap_device * to idle
|
|
*
|
|
* Idle omap_device @od. Device drivers call this function indirectly
|
|
* via pm_runtime_put*(). Returns -EINVAL if the omap_device is not
|
|
* currently enabled, or passes along the return value of
|
|
* _omap_device_idle_hwmods().
|
|
*/
|
|
int omap_device_idle(struct platform_device *pdev)
|
|
{
|
|
int ret;
|
|
struct omap_device *od;
|
|
|
|
od = to_omap_device(pdev);
|
|
|
|
if (od->_state != OMAP_DEVICE_STATE_ENABLED) {
|
|
dev_warn(&pdev->dev,
|
|
"omap_device: %s() called from invalid state %d\n",
|
|
__func__, od->_state);
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = _omap_device_idle_hwmods(od);
|
|
|
|
if (ret == 0)
|
|
od->_state = OMAP_DEVICE_STATE_IDLE;
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* omap_device_assert_hardreset - set a device's hardreset line
|
|
* @pdev: struct platform_device * to reset
|
|
* @name: const char * name of the reset line
|
|
*
|
|
* Set the hardreset line identified by @name on the IP blocks
|
|
* associated with the hwmods backing the platform_device @pdev. All
|
|
* of the hwmods associated with @pdev must have the same hardreset
|
|
* line linked to them for this to work. Passes along the return value
|
|
* of omap_hwmod_assert_hardreset() in the event of any failure, or
|
|
* returns 0 upon success.
|
|
*/
|
|
int omap_device_assert_hardreset(struct platform_device *pdev, const char *name)
|
|
{
|
|
struct omap_device *od = to_omap_device(pdev);
|
|
int ret = 0;
|
|
int i;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++) {
|
|
ret = omap_hwmod_assert_hardreset(od->hwmods[i], name);
|
|
if (ret)
|
|
break;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* omap_device_deassert_hardreset - release a device's hardreset line
|
|
* @pdev: struct platform_device * to reset
|
|
* @name: const char * name of the reset line
|
|
*
|
|
* Release the hardreset line identified by @name on the IP blocks
|
|
* associated with the hwmods backing the platform_device @pdev. All
|
|
* of the hwmods associated with @pdev must have the same hardreset
|
|
* line linked to them for this to work. Passes along the return
|
|
* value of omap_hwmod_deassert_hardreset() in the event of any
|
|
* failure, or returns 0 upon success.
|
|
*/
|
|
int omap_device_deassert_hardreset(struct platform_device *pdev,
|
|
const char *name)
|
|
{
|
|
struct omap_device *od = to_omap_device(pdev);
|
|
int ret = 0;
|
|
int i;
|
|
|
|
for (i = 0; i < od->hwmods_cnt; i++) {
|
|
ret = omap_hwmod_deassert_hardreset(od->hwmods[i], name);
|
|
if (ret)
|
|
break;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
/**
|
|
* omap_device_get_by_hwmod_name() - convert a hwmod name to
|
|
* device pointer.
|
|
* @oh_name: name of the hwmod device
|
|
*
|
|
* Returns back a struct device * pointer associated with a hwmod
|
|
* device represented by a hwmod_name
|
|
*/
|
|
struct device *omap_device_get_by_hwmod_name(const char *oh_name)
|
|
{
|
|
struct omap_hwmod *oh;
|
|
|
|
if (!oh_name) {
|
|
WARN(1, "%s: no hwmod name!\n", __func__);
|
|
return ERR_PTR(-EINVAL);
|
|
}
|
|
|
|
oh = omap_hwmod_lookup(oh_name);
|
|
if (!oh) {
|
|
WARN(1, "%s: no hwmod for %s\n", __func__,
|
|
oh_name);
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
if (!oh->od) {
|
|
WARN(1, "%s: no omap_device for %s\n", __func__,
|
|
oh_name);
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
|
|
return &oh->od->pdev->dev;
|
|
}
|
|
|
|
static struct notifier_block platform_nb = {
|
|
.notifier_call = _omap_device_notifier_call,
|
|
};
|
|
|
|
static int __init omap_device_init(void)
|
|
{
|
|
bus_register_notifier(&platform_bus_type, &platform_nb);
|
|
return 0;
|
|
}
|
|
omap_core_initcall(omap_device_init);
|
|
|
|
/**
|
|
* omap_device_late_idle - idle devices without drivers
|
|
* @dev: struct device * associated with omap_device
|
|
* @data: unused
|
|
*
|
|
* Check the driver bound status of this device, and idle it
|
|
* if there is no driver attached.
|
|
*/
|
|
static int __init omap_device_late_idle(struct device *dev, void *data)
|
|
{
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
struct omap_device *od = to_omap_device(pdev);
|
|
int i;
|
|
|
|
if (!od)
|
|
return 0;
|
|
|
|
/*
|
|
* If omap_device state is enabled, but has no driver bound,
|
|
* idle it.
|
|
*/
|
|
|
|
/*
|
|
* Some devices (like memory controllers) are always kept
|
|
* enabled, and should not be idled even with no drivers.
|
|
*/
|
|
for (i = 0; i < od->hwmods_cnt; i++)
|
|
if (od->hwmods[i]->flags & HWMOD_INIT_NO_IDLE)
|
|
return 0;
|
|
|
|
if (od->_driver_status != BUS_NOTIFY_BOUND_DRIVER &&
|
|
od->_driver_status != BUS_NOTIFY_BIND_DRIVER) {
|
|
if (od->_state == OMAP_DEVICE_STATE_ENABLED) {
|
|
dev_warn(dev, "%s: enabled but no driver. Idling\n",
|
|
__func__);
|
|
omap_device_idle(pdev);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __init omap_device_late_init(void)
|
|
{
|
|
bus_for_each_dev(&platform_bus_type, NULL, NULL, omap_device_late_idle);
|
|
|
|
WARN(!of_have_populated_dt(),
|
|
"legacy booting deprecated, please update to boot with .dts\n");
|
|
|
|
return 0;
|
|
}
|
|
omap_late_initcall_sync(omap_device_late_init);
|