alistair23-linux/drivers/i2c
Luotao Fu ad0194e8d6 i2c-pnx: fix setting start/stop condition
The start/stop condtions are set in different places repetedly in the i2c-pnx
driver.  Beside in i2c_pnx_start and i2c_pnx_stop the start/stop bit are also
set during the transfer of a i2c message in the master_xmit/rcv calls. This is
wrong since we can't set the start/stop condition during the transaction of a
single message any way. As a matter of fact, the driver will sometimes set both
the start and the stop bits at one time. This can be easily reproduced by
sending a simple read request like e.g
struct i2c_msg msgs[] = {
{ addr, 0, 1, buf },
{ addr, I2C_M_RD, offset, buf }
};
While processing the first message the i2c_pnx_master_xmit will set both the
start_bit and the stop_bit, which will eventually confuse the slave.

Fixed by remove setting start/stop condition from the transmit routines.

Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
2010-03-07 22:10:09 +00:00
..
algos i2c-algo-pca: Drop duplicate variable 2010-03-02 12:23:47 +01:00
busses i2c-pnx: fix setting start/stop condition 2010-03-07 22:10:09 +00:00
chips i2c/chips: Move ds1682 to drivers/misc 2009-12-06 17:06:16 +01:00
i2c-boardinfo.c i2c: Use rwsem instead of mutex for board info 2009-06-19 16:58:20 +02:00
i2c-core.c i2c: Document the message size limit 2010-03-02 12:23:49 +01:00
i2c-core.h i2c: Use rwsem instead of mutex for board info 2009-06-19 16:58:20 +02:00
i2c-dev.c i2c: Remove big kernel lock from i2cdev_open 2009-12-06 17:06:26 +01:00
i2c-smbus.c i2c: Add SMBus alert support 2010-03-02 12:23:42 +01:00
Kconfig i2c: Separate Kconfig option for i2c-smbus 2010-03-02 12:23:43 +01:00
Makefile i2c: Separate Kconfig option for i2c-smbus 2010-03-02 12:23:43 +01:00