bd724318b6
It looks that GuC log functionality is not fully functional yet and
causes issues when enabled by auto(-1) modparam on debug builds.
For example, but not limited to:
[ 30.062893] ======================================================
[ 30.062894] WARNING: possible circular locking dependency detected
[ 30.062895] 4.15.0-rc8-CI-CI_DRM_3648+ #1 Tainted: G U
[ 30.062896] ------------------------------------------------------
[ 30.062897] debugfs_test/1268 is trying to acquire lock:
[ 30.062898] (&dev->struct_mutex){+.+.}, at: [<00000000e4213449>] i915_mutex_lock_interruptible+0x47/0x130 [i915]
[ 30.062921]
but task is already holding lock:
[ 30.062921] (&mm->mmap_sem){++++}, at: [<00000000dd7adc93>] __do_page_fault+0x106/0x560
[ 30.062924]
which lock already depends on the new lock.
References: 0ed8795353 ("drm/i915/guc: Redefine guc_log_level modparam values")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104693
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104694
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104695
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Saarinen <jani.saarinen@intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
Cc: Marta Lofstedt <marta.lofstedt@intel.com>
Cc: Michal Winiarski <michal.winiarski@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180119124926.29844-1-michal.wajdeczko@intel.com
Reviewed-by: Michal Winiarski <michal.winiarski@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
86 lines
2.9 KiB
C
86 lines
2.9 KiB
C
/*
|
|
* Copyright © 2015 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#ifndef _I915_PARAMS_H_
|
|
#define _I915_PARAMS_H_
|
|
|
|
#include <linux/bitops.h>
|
|
#include <linux/cache.h> /* for __read_mostly */
|
|
|
|
struct drm_printer;
|
|
|
|
#define ENABLE_GUC_SUBMISSION BIT(0)
|
|
#define ENABLE_GUC_LOAD_HUC BIT(1)
|
|
|
|
#define I915_PARAMS_FOR_EACH(param) \
|
|
param(char *, vbt_firmware, NULL) \
|
|
param(int, modeset, -1) \
|
|
param(int, panel_ignore_lid, 1) \
|
|
param(int, lvds_channel_mode, 0) \
|
|
param(int, panel_use_ssc, -1) \
|
|
param(int, vbt_sdvo_panel_type, -1) \
|
|
param(int, enable_dc, -1) \
|
|
param(int, enable_fbc, -1) \
|
|
param(int, enable_ppgtt, -1) \
|
|
param(int, enable_psr, -1) \
|
|
param(int, disable_power_well, -1) \
|
|
param(int, enable_ips, 1) \
|
|
param(int, invert_brightness, 0) \
|
|
param(int, enable_guc, 0) \
|
|
param(int, guc_log_level, 0) \
|
|
param(char *, guc_firmware_path, NULL) \
|
|
param(char *, huc_firmware_path, NULL) \
|
|
param(int, mmio_debug, 0) \
|
|
param(int, edp_vswing, 0) \
|
|
param(int, reset, 2) \
|
|
param(unsigned int, inject_load_failure, 0) \
|
|
/* leave bools at the end to not create holes */ \
|
|
param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
|
|
param(bool, enable_cmd_parser, true) \
|
|
param(bool, enable_hangcheck, true) \
|
|
param(bool, fastboot, false) \
|
|
param(bool, prefault_disable, false) \
|
|
param(bool, load_detect_test, false) \
|
|
param(bool, force_reset_modeset_test, false) \
|
|
param(bool, error_capture, true) \
|
|
param(bool, disable_display, false) \
|
|
param(bool, verbose_state_checks, true) \
|
|
param(bool, nuclear_pageflip, false) \
|
|
param(bool, enable_dp_mst, true) \
|
|
param(bool, enable_dpcd_backlight, false) \
|
|
param(bool, enable_gvt, false)
|
|
|
|
#define MEMBER(T, member, ...) T member;
|
|
struct i915_params {
|
|
I915_PARAMS_FOR_EACH(MEMBER);
|
|
};
|
|
#undef MEMBER
|
|
|
|
extern struct i915_params i915_modparams __read_mostly;
|
|
|
|
void i915_params_dump(const struct i915_params *params, struct drm_printer *p);
|
|
|
|
#endif
|
|
|