Eric Biggers 29c2d3e91e fscrypt: remove kernel-internal constants from UAPI header ... commit 3ceb6543e9 upstream. There isn't really any valid reason to use __FSCRYPT_MODE_MAX or FSCRYPT_POLICY_FLAGS_VALID in a userspace program. These constants are only meant to be used by the kernel internally, and they are defined in the UAPI header next to the mode numbers and flags only so that kernel developers don't forget to update them when adding new modes or flags. In https://lkml.kernel.org/r/20201005074133.1958633-2-satyat@google.com there was an example of someone wanting to use __FSCRYPT_MODE_MAX in a user program, and it was wrong because the program would have broken if __FSCRYPT_MODE_MAX were ever increased. So having this definition available is harmful. FSCRYPT_POLICY_FLAGS_VALID has the same problem. So, remove these definitions from the UAPI header. Replace FSCRYPT_POLICY_FLAGS_VALID with just listing the valid flags explicitly in the one kernel function that needs it. Move __FSCRYPT_MODE_MAX to fscrypt_private.h, remove the double underscores (which were only present to discourage use by userspace), and add a BUILD_BUG_ON() and comments to (hopefully) ensure it is kept in sync. Keep the old name FS_POLICY_FLAGS_VALID, since it's been around for longer and there's a greater chance that removing it would break source compatibility with some program. Indeed, mtd-utils is using it in an #ifdef, and removing it would introduce compiler warnings (about FS_POLICY_FLAGS_PAD_* being redefined) into the mtd-utils build. However, reduce its value to 0x07 so that it only includes the flags with old names (the ones present before Linux 5.4), and try to make it clear that it's now "frozen" and no new flags should be added to it. Fixes: 2336d0deb2 ("fscrypt: use FSCRYPT_ prefix for uapi constants") Cc: <stable@vger.kernel.org> # v5.4+ Link: https://lore.kernel.org/r/20201024005132.495952-1-ebiggers@kernel.org Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-01-06 14:48:35 +01:00
..
asm-generic	mm: introduce MADV_PAGEOUT	2019-09-25 17:51:41 -07:00
drm	drm/amdgpu: return tcc_disabled_mask to userspace	2019-10-02 12:58:33 -05:00
linux	fscrypt: remove kernel-internal constants from UAPI header	2021-01-06 14:48:35 +01:00
misc	habanalabs: stop using the acronym KMD	2019-09-05 14:55:27 +03:00
mtd	mtd: abi: do not use C++ style comments in uapi header	2019-07-07 20:31:29 +02:00
rdma	rdma: Remove nes ABI header	2020-01-17 19:48:39 +01:00
scsi	scsi: use __u{8,16,32,64} instead of uint{8,16,32,64}_t in uapi headers	2019-08-12 22:19:27 -04:00
sound	ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT	2020-12-02 08:49:57 +01:00
video	…
xen	xen/gntdev: Add initial support for dma-buf UAPI	2018-07-26 23:05:14 -04:00
Kbuild	kbuild: re-implement Makefile.headersinst without recursion	2019-06-15 19:57:02 +09:00