Yinghai Lu afe3e4d11b PCI/PME: Restore pcie_pme_driver.remove ... In addition to making PME non-modular, d7def20400 ("PCI/PME: Make explicitly non-modular") removed the pcie_pme_driver .remove() method, pcie_pme_remove(). pcie_pme_remove() freed the PME IRQ that was requested in pci_pme_probe(). The fact that we don't free the IRQ after d7def20400 causes the following crash when removing a PCIe port device via /sys: ------------[ cut here ]------------ kernel BUG at drivers/pci/msi.c:370! invalid opcode: 0000 [#1] SMP Modules linked in: CPU: 1 PID: 14509 Comm: sh Tainted: G W 4.8.0-rc1-yh-00012-gd29438d RIP: 0010:[<ffffffff9758bbf5>] free_msi_irqs+0x65/0x190 ... Call Trace: [<ffffffff9758cda4>] pci_disable_msi+0x34/0x40 [<ffffffff97583817>] cleanup_service_irqs+0x27/0x30 [<ffffffff97583e9a>] pcie_port_device_remove+0x2a/0x40 [<ffffffff97584250>] pcie_portdrv_remove+0x40/0x50 [<ffffffff97576d7b>] pci_device_remove+0x4b/0xc0 [<ffffffff9785ebe6>] __device_release_driver+0xb6/0x150 [<ffffffff9785eca5>] device_release_driver+0x25/0x40 [<ffffffff975702e4>] pci_stop_bus_device+0x74/0xa0 [<ffffffff975704ea>] pci_stop_and_remove_bus_device_locked+0x1a/0x30 [<ffffffff97578810>] remove_store+0x50/0x70 [<ffffffff9785a378>] dev_attr_store+0x18/0x30 [<ffffffff97260b64>] sysfs_kf_write+0x44/0x60 [<ffffffff9725feae>] kernfs_fop_write+0x10e/0x190 [<ffffffff971e13f8>] __vfs_write+0x28/0x110 [<ffffffff970b0fa4>] ? percpu_down_read+0x44/0x80 [<ffffffff971e53a7>] ? __sb_start_write+0xa7/0xe0 [<ffffffff971e53a7>] ? __sb_start_write+0xa7/0xe0 [<ffffffff971e1f04>] vfs_write+0xc4/0x180 [<ffffffff971e3089>] SyS_write+0x49/0xa0 [<ffffffff97001a46>] do_syscall_64+0xa6/0x1b0 [<ffffffff9819201e>] entry_SYSCALL64_slow_path+0x25/0x25 ... RIP [<ffffffff9758bbf5>] free_msi_irqs+0x65/0x190 RSP <ffff89ad3085bc48> ---[ end trace f4505e1dac5b95d3 ]--- Segmentation fault Restore pcie_pme_remove(). [bhelgaas: changelog] Fixes: d7def20400 ("PCI/PME: Make explicitly non-modular") Signed-off-by: Yinghai Lu <yinghai@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> CC: stable@vger.kernel.org # v4.9+		2017-02-15 09:39:32 -06:00
..
aer	pci-v4.10-changes	2016-12-15 12:46:48 -08:00
aspm.c	PCI/ASPM: Handle PCI-to-PCIe bridges as roots of PCIe hierarchies	2017-01-27 15:00:45 -06:00
Kconfig	PCI: Add Precision Time Measurement (PTM) support	2016-08-15 13:44:08 -05:00
Makefile	PCI: Add Precision Time Measurement (PTM) support	2016-08-15 13:44:08 -05:00
pcie-dpc.c	PCI: Make DPC explicitly non-modular	2016-08-24 16:52:24 -05:00
pme.c	PCI/PME: Restore pcie_pme_driver.remove	2017-02-15 09:39:32 -06:00
portdrv.h	Merge branches 'pci/dpc', 'pci/resource' and 'pci/thunderbolt' into next	2016-05-03 11:49:21 -05:00
portdrv_acpi.c	Merge branches 'pci/dpc', 'pci/resource' and 'pci/thunderbolt' into next	2016-05-03 11:49:21 -05:00
portdrv_bus.c	PCI: Fix whitespace, capitalization, and spelling errors	2013-11-14 11:28:18 -07:00
portdrv_core.c	PCI: Remove service driver load/unload messages	2016-12-12 10:05:24 -06:00
portdrv_pci.c	PCI: Consolidate conditions to allow runtime PM on PCIe ports	2016-11-17 18:46:22 -06:00
ptm.c	PCI: Add PTM clock granularity information	2016-08-25 08:32:34 -05:00