1
0
Fork 0
alistair23-linux/drivers/bcma
Rafał Miłecki 361de091a4 bcma: fix buffer size caused crash in bcma_core_mips_print_irq()
Used buffer wasn't big enough to hold whole strings. Example output of
this function is:
[    0.180892] bcma: bus0: core 0x0800, irq: 2(S)* 3  4  5  6  D  I
[    0.180948] bcma: bus0: core 0x0812, irq: 2(S)  3* 4  5  6  D  I
[    0.180998] bcma: bus0: core 0x082d, irq: 2(S)  3  4* 5  6  D  I
[    0.181046] bcma: bus0: core 0x082c, irq: 2(S)  3  4  5  6  D  I*
which means we need to store up to 24 chars.

Fixes: 758f7e0606 ("bcma: Use bcma_debug and not pr_cont in MIPS driver")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2018-05-12 11:36:59 +03:00
..
Kconfig bcma: Prevent build of PCI host features in module 2018-03-13 18:47:47 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
README
TODO
bcma_private.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
core.c bcma: update core (en|dis)abling functions 2013-06-17 14:38:53 -04:00
driver_chipcommon.c Revert "bcma: init serial console directly from ChipCommon code" 2017-01-17 14:23:44 +02:00
driver_chipcommon_b.c bcma: define ChipCommon B MII registers 2016-07-19 21:13:10 +03:00
driver_chipcommon_nflash.c Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless 2013-02-14 14:23:33 -05:00
driver_chipcommon_pflash.c bcma: move parallel flash support to separated file 2016-03-07 14:41:08 +02:00
driver_chipcommon_pmu.c bcma: Replace mdelay with usleep_range in bcma_pmu_resources_init 2018-02-27 15:52:13 +02:00
driver_chipcommon_sflash.c mtd: bcm47xxsflash: use ioremap_cache() instead of KSEG0ADDR() 2016-04-04 00:07:57 -07:00
driver_gmac_cmn.c Drivers: bcma: remove __dev* attributes. 2013-01-03 15:57:15 -08:00
driver_gpio.c gpio: Move irqdomain into struct gpio_irq_chip 2017-11-08 14:06:21 +01:00
driver_mips.c bcma: fix buffer size caused crash in bcma_core_mips_print_irq() 2018-05-12 11:36:59 +03:00
driver_pci.c bcma: move PCI IRQ control function to host specific code 2015-03-13 16:25:50 +02:00
driver_pci_host.c bcma: add missing includes 2015-03-03 15:26:38 +02:00
driver_pcie2.c bcma: Adjust block comment 2017-12-07 15:33:02 +02:00
host_pci.c bcma: add HP Stream Notebook 2018-02-28 16:37:22 +02:00
host_soc.c bcma: use standard bus scanning during early register 2015-01-23 21:47:55 +02:00
main.c bcma: fill core OF info independently of bus type 2017-03-20 19:12:01 +02:00
scan.c bcma: support chipsets with PMU and GCI cores (devices) 2016-02-06 13:34:51 +02:00
scan.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sprom.c bcma: detect SPROM revision 11 2015-01-29 10:49:28 +02:00

README

Broadcom introduced new bus as replacement for older SSB. It is based on AMBA,
however from programming point of view there is nothing AMBA specific we use.

Standard AMBA drivers are platform specific, have hardcoded addresses and use
AMBA standard fields like CID and PID.

In case of Broadcom's cards every device consists of:
1) Broadcom specific AMBA device. It is put on AMBA bus, but can not be treated
   as standard AMBA device. Reading it's CID or PID can cause machine lockup.
2) AMBA standard devices called ports or wrappers. They have CIDs (AMBA_CID)
   and PIDs (0x103BB369), but we do not use that info for anything. One of that
   devices is used for managing Broadcom specific core.

Addresses of AMBA devices are not hardcoded in driver and have to be read from
EPROM.

In this situation we decided to introduce separated bus. It can contain up to
16 devices identified by Broadcom specific fields: manufacturer, id, revision
and class.