1
0
Fork 0
alistair23-linux/drivers/media/radio/wl128x
Geert Uytterhoeven 4360fa22ad drivers: misc: ti-st: Use int instead of fuzzy char for callback status
On mips and parisc:

    drivers/bluetooth/btwilink.c: In function 'ti_st_open':
    drivers/bluetooth/btwilink.c:174:21: warning: overflow in implicit constant conversion [-Woverflow]
       hst->reg_status = -EINPROGRESS;

    drivers/nfc/nfcwilink.c: In function 'nfcwilink_open':
    drivers/nfc/nfcwilink.c:396:31: warning: overflow in implicit constant conversion [-Woverflow]
      drv->st_register_cb_status = -EINPROGRESS;

There are actually two issues:
  1. Whether "char" is signed or unsigned depends on the architecture.
     As the completion callback data is used to pass a (negative) error
     code, it should always be signed.
  2. EINPROGRESS is 150 on mips, 245 on parisc.
     Hence -EINPROGRESS doesn't fit in a signed 8-bit number.

Change the callback status from "char" to "int" to fix these.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
2016-07-17 19:59:26 +02:00
..
Kconfig [media] wl128x: Allow compile test of GPIO consumers if !GPIOLIB 2015-05-30 11:45:40 -03:00
Makefile [media] drivers:media:radio: wl128x: Kconfig & Makefile for wl128x driver 2011-03-21 20:32:36 -03:00
fmdrv.h [media] wl128x: fix int type for streg_cbdata 2015-04-30 13:40:05 -03:00
fmdrv_common.c drivers: misc: ti-st: Use int instead of fuzzy char for callback status 2016-07-17 19:59:26 +02:00
fmdrv_common.h [media] wl128x: fmdrv_common: fix signedness bugs 2011-12-30 17:00:56 -02:00
fmdrv_rx.c [media] media: radio: wl128x: fmdrv_rx.c: Remove unused function 2015-01-27 09:56:20 -02:00
fmdrv_rx.h [media] media: radio: wl128x: fmdrv_rx.c: Remove unused function 2015-01-27 09:56:20 -02:00
fmdrv_tx.c [media] wl128x: fix sparse warnings 2014-09-03 09:39:15 -03:00
fmdrv_tx.h [media] wl128x: fmdrv_tx: fix signedness bugs 2011-12-30 17:01:52 -02:00
fmdrv_v4l2.c [media] wl128x: embed video_device 2015-04-02 23:35:52 -03:00
fmdrv_v4l2.h [media] drivers:media:radio: wl128x: FM Driver V4L2 sources 2011-03-21 20:32:35 -03:00