04cc3c8a80
As per the TODO file, this patch removes the gratuitous debug infrastructure. As an extra incentive for removing this code, the debugfs files are not cleaned up properly. For example, if register_netdev() fails in slic_entry_probe() then all debugfs files get left behind, even after the driver module is unloaded. Touching these files quickly leads to an oops. Signed-off-by: David Matlack <dmatlack@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
38 lines
1.3 KiB
Plaintext
38 lines
1.3 KiB
Plaintext
TODO:
|
|
- move firmware loading to request_firmware()
|
|
- remove direct memory access of structures
|
|
- any remaining sparse and checkpatch.pl warnings
|
|
|
|
- use net_device_ops
|
|
- use dev->stats rather than adapter->stats
|
|
- don't cast netdev_priv it is already void
|
|
- GET RID OF MACROS
|
|
- work on all architectures
|
|
- without CONFIG_X86_64 confusion
|
|
- do 64 bit correctly
|
|
- don't depend on order of union
|
|
- get rid of ASSERT(), use BUG() instead but only where necessary
|
|
looks like most aren't really useful
|
|
- no new SIOCDEVPRIVATE ioctl allowed
|
|
- don't use module_param for configuring interrupt mitigation
|
|
use ethtool instead
|
|
- reorder code to elminate use of forward declarations
|
|
- don't keep private linked list of drivers.
|
|
- use PCI_DEVICE()
|
|
- do ethtool correctly using ethtool_ops
|
|
- NAPI?
|
|
- wasted overhead of extra stats
|
|
- state variables for things that are
|
|
easily available and shouldn't be kept in card structure, cardnum, ...
|
|
slotnumber, events, ...
|
|
- get rid of slic_spinlock wrapper
|
|
- volatile == bad design => bad code
|
|
- locking too fine grained, not designed just throw more locks
|
|
at problem
|
|
|
|
Please send patches to:
|
|
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
and Cc: Lior Dotan <liodot@gmail.com> and Christopher Harrer
|
|
<charrer@alacritech.com> as well as they are also able to test out any
|
|
changes.
|