54d8fe4425
The NCR5380_local_declare and NCR5380_setup macros exist to define and initialize a particular local variable, to provide the address of the chip registers needed for the driver's implementation of its NCR5380_read/write register access macros. In cumana_1 and macscsi, these macros generate pointless code like this, struct Scsi_Host *_instance; _instance = instance; In pas16, the use of NCR5380_read/write in pas16_hw_detect() requires that the io_port local variable has been defined and initialized, but the NCR5380_local_declare and NCR5380_setup macros can't be used for that purpose because the Scsi_Host struct has not yet been instantiated. Moreover, these macros were removed from atari_NCR5380.c long ago and now they constitute yet another discrepancy between the two core driver forks. Remove these "optimizations". Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Reviewed-by: Hannes Reinecke <hare@suse.com> Tested-by: Ondrej Zary <linux@rainbow-software.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
45 lines
1,010 B
C
45 lines
1,010 B
C
/*
|
|
* DTC controller, taken from T128 driver by...
|
|
* Copyright 1993, Drew Eckhardt
|
|
* Visionary Computing
|
|
* (Unix and Linux consulting and custom programming)
|
|
* drew@colorado.edu
|
|
* +1 (303) 440-4894
|
|
*/
|
|
|
|
#ifndef DTC3280_H
|
|
#define DTC3280_H
|
|
|
|
#ifndef CMD_PER_LUN
|
|
#define CMD_PER_LUN 2
|
|
#endif
|
|
|
|
#ifndef CAN_QUEUE
|
|
#define CAN_QUEUE 32
|
|
#endif
|
|
|
|
#define NCR5380_implementation_fields \
|
|
void __iomem *base
|
|
|
|
#define DTC_address(reg) \
|
|
(((struct NCR5380_hostdata *)shost_priv(instance))->base + DTC_5380_OFFSET + reg)
|
|
|
|
#define NCR5380_read(reg) (readb(DTC_address(reg)))
|
|
#define NCR5380_write(reg, value) (writeb(value, DTC_address(reg)))
|
|
|
|
#define NCR5380_intr dtc_intr
|
|
#define NCR5380_queue_command dtc_queue_command
|
|
#define NCR5380_abort dtc_abort
|
|
#define NCR5380_bus_reset dtc_bus_reset
|
|
#define NCR5380_info dtc_info
|
|
#define NCR5380_show_info dtc_show_info
|
|
#define NCR5380_write_info dtc_write_info
|
|
|
|
/* 15 12 11 10
|
|
1001 1100 0000 0000 */
|
|
|
|
#define DTC_IRQS 0x9c00
|
|
|
|
|
|
#endif /* DTC3280_H */
|