1
0
Fork 0
alistair23-linux/drivers/net/ethernet/8390
Finn Thain bb9e5c5bcd mac8390: Fix mmio access size probe
The bug that Stan reported is as follows. After a restart, a 16-bit NIC
may be incorrectly identified as a 32-bit NIC and stop working.

mac8390 slot.E: Memory length resource not found, probing
mac8390 slot.E: Farallon EtherMac II-C (type farallon)
mac8390 slot.E: MAC 00:00:c5:30:c2:99, IRQ 61, 32 KB shared memory at 0xfeed0000, 32-bit access.

The bug never arises after a cold start and only intermittently after a
warm start. (I didn't investigate why the bug is intermittent.)

It turns out that memcpy_toio() is deprecated and memcmp_withio() also
has issues. Replacing these calls with mmio accessors fixes the problem.

Reported-and-tested-by: Stan Johnson <userm57@yahoo.com>
Fixes: 2964db0f59 ("m68k: Mac DP8390 update")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-18 16:56:57 -07:00
..
8390.c net: deprecate eth_change_mtu, remove usage 2016-10-13 09:36:57 -04:00
8390.h 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature 2013-12-11 17:21:02 -05:00
8390p.c net: deprecate eth_change_mtu, remove usage 2016-10-13 09:36:57 -04:00
Kconfig net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k) 2018-04-19 16:11:11 -04:00
Makefile net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k) 2018-04-19 16:11:11 -04:00
apne.c ethernet: Use octal not symbolic permissions 2018-03-26 12:07:49 -04:00
ax88796.c net: ethernet: Use phy_set_max_speed() to limit advertised speed 2018-09-12 20:24:20 -07:00
axnet_cs.c 8390: axnet_cs: Mark expected switch fall-through 2018-08-07 17:54:19 -07:00
etherh.c 8390/etherh: convert to ethtool_{get, set}_link_ksettings 2018-08-29 19:46:10 -07:00
hydra.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
lib8390.c ethernet: Use octal not symbolic permissions 2018-03-26 12:07:49 -04:00
mac8390.c mac8390: Fix mmio access size probe 2019-03-18 16:56:57 -07:00
mcf8390.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
ne.c net: 8390: ne: Fix accidentally removed RBTX4927 support 2018-05-16 14:38:54 -04:00
ne2k-pci.c ethernet: Use octal not symbolic permissions 2018-03-26 12:07:49 -04:00
pcnet_cs.c net: 8390: fix potential NULL pointer dereferences 2019-03-12 14:49:49 -07:00
smc-ultra.c ethernet: Use octal not symbolic permissions 2018-03-26 12:07:49 -04:00
stnic.c ethernet: Use octal not symbolic permissions 2018-03-26 12:07:49 -04:00
wd.c ethernet: Use octal not symbolic permissions 2018-03-26 12:07:49 -04:00
xsurf100.c net-next: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k) 2018-04-19 16:11:11 -04:00
zorro8390.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00