![John W. Linville](/assets/img/avatar_default.png)
Problem description by Daniel Drake <dsd@gentoo.org>: "This sequence of events causes loss of connectivity: <plug in> <associate as normal in managed mode> ifconfig eth7 down iwconfig eth7 mode monitor ifconfig eth7 up ifconfig eth7 down iwconfig eth7 mode managed <associate as normal> At this point you are associated but TX does not work. This is because the eth7 hard_start_xmit is still ieee80211_monitor_start_xmit." The problem is caused by ieee80211_if_set_type checking for a non-zero hard_start_xmit pointer value in order to avoid changing that value for master devices. The fix is to make that check more explicitly linked to master devices rather than simply checking if the value has been previously set. CC: Daniel Drake <dsd@gentoo.org> Acked-by: Michael Wu <flamingice@sourmilk.net> Signed-off-by: John W. Linville <linville@tuxdriver.com>
302 lines
7.8 KiB
C
302 lines
7.8 KiB
C
/*
|
|
* Copyright 2002-2005, Instant802 Networks, Inc.
|
|
* Copyright 2005-2006, Devicescape Software, Inc.
|
|
* Copyright (c) 2006 Jiri Benc <jbenc@suse.cz>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
#include <linux/kernel.h>
|
|
#include <linux/if_arp.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/rtnetlink.h>
|
|
#include <net/mac80211.h>
|
|
#include "ieee80211_i.h"
|
|
#include "sta_info.h"
|
|
#include "debugfs_netdev.h"
|
|
|
|
void ieee80211_if_sdata_init(struct ieee80211_sub_if_data *sdata)
|
|
{
|
|
int i;
|
|
|
|
/* Default values for sub-interface parameters */
|
|
sdata->drop_unencrypted = 0;
|
|
sdata->eapol = 1;
|
|
for (i = 0; i < IEEE80211_FRAGMENT_MAX; i++)
|
|
skb_queue_head_init(&sdata->fragments[i].skb_list);
|
|
|
|
INIT_LIST_HEAD(&sdata->key_list);
|
|
}
|
|
|
|
static void ieee80211_if_sdata_deinit(struct ieee80211_sub_if_data *sdata)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < IEEE80211_FRAGMENT_MAX; i++) {
|
|
__skb_queue_purge(&sdata->fragments[i].skb_list);
|
|
}
|
|
}
|
|
|
|
/* Must be called with rtnl lock held. */
|
|
int ieee80211_if_add(struct net_device *dev, const char *name,
|
|
struct net_device **new_dev, int type)
|
|
{
|
|
struct net_device *ndev;
|
|
struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
|
|
struct ieee80211_sub_if_data *sdata = NULL;
|
|
int ret;
|
|
|
|
ASSERT_RTNL();
|
|
ndev = alloc_netdev(sizeof(struct ieee80211_sub_if_data),
|
|
name, ieee80211_if_setup);
|
|
if (!ndev)
|
|
return -ENOMEM;
|
|
|
|
ret = dev_alloc_name(ndev, ndev->name);
|
|
if (ret < 0)
|
|
goto fail;
|
|
|
|
memcpy(ndev->dev_addr, local->hw.wiphy->perm_addr, ETH_ALEN);
|
|
ndev->base_addr = dev->base_addr;
|
|
ndev->irq = dev->irq;
|
|
ndev->mem_start = dev->mem_start;
|
|
ndev->mem_end = dev->mem_end;
|
|
SET_NETDEV_DEV(ndev, wiphy_dev(local->hw.wiphy));
|
|
|
|
sdata = IEEE80211_DEV_TO_SUB_IF(ndev);
|
|
ndev->ieee80211_ptr = &sdata->wdev;
|
|
sdata->wdev.wiphy = local->hw.wiphy;
|
|
sdata->type = IEEE80211_IF_TYPE_AP;
|
|
sdata->dev = ndev;
|
|
sdata->local = local;
|
|
ieee80211_if_sdata_init(sdata);
|
|
|
|
ret = register_netdevice(ndev);
|
|
if (ret)
|
|
goto fail;
|
|
|
|
ieee80211_debugfs_add_netdev(sdata);
|
|
ieee80211_if_set_type(ndev, type);
|
|
|
|
/* we're under RTNL so all this is fine */
|
|
if (unlikely(local->reg_state == IEEE80211_DEV_UNREGISTERED)) {
|
|
__ieee80211_if_del(local, sdata);
|
|
return -ENODEV;
|
|
}
|
|
list_add_tail_rcu(&sdata->list, &local->interfaces);
|
|
|
|
if (new_dev)
|
|
*new_dev = ndev;
|
|
|
|
return 0;
|
|
|
|
fail:
|
|
free_netdev(ndev);
|
|
return ret;
|
|
}
|
|
|
|
void ieee80211_if_set_type(struct net_device *dev, int type)
|
|
{
|
|
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
|
|
int oldtype = sdata->type;
|
|
|
|
/*
|
|
* We need to call this function on the master interface
|
|
* which already has a hard_start_xmit routine assigned
|
|
* which must not be changed.
|
|
*/
|
|
if (dev != sdata->local->mdev)
|
|
dev->hard_start_xmit = ieee80211_subif_start_xmit;
|
|
|
|
/*
|
|
* Called even when register_netdevice fails, it would
|
|
* oops if assigned before initialising the rest.
|
|
*/
|
|
dev->uninit = ieee80211_if_reinit;
|
|
|
|
/* most have no BSS pointer */
|
|
sdata->bss = NULL;
|
|
sdata->type = type;
|
|
|
|
switch (type) {
|
|
case IEEE80211_IF_TYPE_WDS:
|
|
/* nothing special */
|
|
break;
|
|
case IEEE80211_IF_TYPE_VLAN:
|
|
sdata->u.vlan.ap = NULL;
|
|
break;
|
|
case IEEE80211_IF_TYPE_AP:
|
|
sdata->u.ap.dtim_period = 2;
|
|
sdata->u.ap.force_unicast_rateidx = -1;
|
|
sdata->u.ap.max_ratectrl_rateidx = -1;
|
|
skb_queue_head_init(&sdata->u.ap.ps_bc_buf);
|
|
sdata->bss = &sdata->u.ap;
|
|
INIT_LIST_HEAD(&sdata->u.ap.vlans);
|
|
break;
|
|
case IEEE80211_IF_TYPE_STA:
|
|
case IEEE80211_IF_TYPE_IBSS: {
|
|
struct ieee80211_sub_if_data *msdata;
|
|
struct ieee80211_if_sta *ifsta;
|
|
|
|
ifsta = &sdata->u.sta;
|
|
INIT_WORK(&ifsta->work, ieee80211_sta_work);
|
|
setup_timer(&ifsta->timer, ieee80211_sta_timer,
|
|
(unsigned long) sdata);
|
|
skb_queue_head_init(&ifsta->skb_queue);
|
|
|
|
ifsta->capab = WLAN_CAPABILITY_ESS;
|
|
ifsta->auth_algs = IEEE80211_AUTH_ALG_OPEN |
|
|
IEEE80211_AUTH_ALG_SHARED_KEY;
|
|
ifsta->flags |= IEEE80211_STA_CREATE_IBSS |
|
|
IEEE80211_STA_WMM_ENABLED |
|
|
IEEE80211_STA_AUTO_BSSID_SEL |
|
|
IEEE80211_STA_AUTO_CHANNEL_SEL;
|
|
|
|
msdata = IEEE80211_DEV_TO_SUB_IF(sdata->local->mdev);
|
|
sdata->bss = &msdata->u.ap;
|
|
break;
|
|
}
|
|
case IEEE80211_IF_TYPE_MNTR:
|
|
dev->type = ARPHRD_IEEE80211_RADIOTAP;
|
|
dev->hard_start_xmit = ieee80211_monitor_start_xmit;
|
|
break;
|
|
default:
|
|
printk(KERN_WARNING "%s: %s: Unknown interface type 0x%x",
|
|
dev->name, __FUNCTION__, type);
|
|
}
|
|
ieee80211_debugfs_change_if_type(sdata, oldtype);
|
|
}
|
|
|
|
/* Must be called with rtnl lock held. */
|
|
void ieee80211_if_reinit(struct net_device *dev)
|
|
{
|
|
struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
|
|
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
|
|
struct sta_info *sta;
|
|
struct sk_buff *skb;
|
|
|
|
ASSERT_RTNL();
|
|
|
|
ieee80211_free_keys(sdata);
|
|
|
|
ieee80211_if_sdata_deinit(sdata);
|
|
|
|
switch (sdata->type) {
|
|
case IEEE80211_IF_TYPE_INVALID:
|
|
/* cannot happen */
|
|
WARN_ON(1);
|
|
break;
|
|
case IEEE80211_IF_TYPE_AP: {
|
|
/* Remove all virtual interfaces that use this BSS
|
|
* as their sdata->bss */
|
|
struct ieee80211_sub_if_data *tsdata, *n;
|
|
|
|
list_for_each_entry_safe(tsdata, n, &local->interfaces, list) {
|
|
if (tsdata != sdata && tsdata->bss == &sdata->u.ap) {
|
|
printk(KERN_DEBUG "%s: removing virtual "
|
|
"interface %s because its BSS interface"
|
|
" is being removed\n",
|
|
sdata->dev->name, tsdata->dev->name);
|
|
list_del_rcu(&tsdata->list);
|
|
/*
|
|
* We have lots of time and can afford
|
|
* to sync for each interface
|
|
*/
|
|
synchronize_rcu();
|
|
__ieee80211_if_del(local, tsdata);
|
|
}
|
|
}
|
|
|
|
kfree(sdata->u.ap.beacon_head);
|
|
kfree(sdata->u.ap.beacon_tail);
|
|
|
|
while ((skb = skb_dequeue(&sdata->u.ap.ps_bc_buf))) {
|
|
local->total_ps_buffered--;
|
|
dev_kfree_skb(skb);
|
|
}
|
|
|
|
break;
|
|
}
|
|
case IEEE80211_IF_TYPE_WDS:
|
|
sta = sta_info_get(local, sdata->u.wds.remote_addr);
|
|
if (sta) {
|
|
sta_info_free(sta);
|
|
sta_info_put(sta);
|
|
} else {
|
|
#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
|
|
printk(KERN_DEBUG "%s: Someone had deleted my STA "
|
|
"entry for the WDS link\n", dev->name);
|
|
#endif /* CONFIG_MAC80211_VERBOSE_DEBUG */
|
|
}
|
|
break;
|
|
case IEEE80211_IF_TYPE_STA:
|
|
case IEEE80211_IF_TYPE_IBSS:
|
|
kfree(sdata->u.sta.extra_ie);
|
|
sdata->u.sta.extra_ie = NULL;
|
|
kfree(sdata->u.sta.assocreq_ies);
|
|
sdata->u.sta.assocreq_ies = NULL;
|
|
kfree(sdata->u.sta.assocresp_ies);
|
|
sdata->u.sta.assocresp_ies = NULL;
|
|
if (sdata->u.sta.probe_resp) {
|
|
dev_kfree_skb(sdata->u.sta.probe_resp);
|
|
sdata->u.sta.probe_resp = NULL;
|
|
}
|
|
|
|
break;
|
|
case IEEE80211_IF_TYPE_MNTR:
|
|
dev->type = ARPHRD_ETHER;
|
|
break;
|
|
case IEEE80211_IF_TYPE_VLAN:
|
|
sdata->u.vlan.ap = NULL;
|
|
break;
|
|
}
|
|
|
|
/* remove all STAs that are bound to this virtual interface */
|
|
sta_info_flush(local, dev);
|
|
|
|
memset(&sdata->u, 0, sizeof(sdata->u));
|
|
ieee80211_if_sdata_init(sdata);
|
|
}
|
|
|
|
/* Must be called with rtnl lock held. */
|
|
void __ieee80211_if_del(struct ieee80211_local *local,
|
|
struct ieee80211_sub_if_data *sdata)
|
|
{
|
|
struct net_device *dev = sdata->dev;
|
|
|
|
ieee80211_debugfs_remove_netdev(sdata);
|
|
unregister_netdevice(dev);
|
|
/* Except master interface, the net_device will be freed by
|
|
* net_device->destructor (i. e. ieee80211_if_free). */
|
|
}
|
|
|
|
/* Must be called with rtnl lock held. */
|
|
int ieee80211_if_remove(struct net_device *dev, const char *name, int id)
|
|
{
|
|
struct ieee80211_local *local = wdev_priv(dev->ieee80211_ptr);
|
|
struct ieee80211_sub_if_data *sdata, *n;
|
|
|
|
ASSERT_RTNL();
|
|
|
|
list_for_each_entry_safe(sdata, n, &local->interfaces, list) {
|
|
if ((sdata->type == id || id == -1) &&
|
|
strcmp(name, sdata->dev->name) == 0 &&
|
|
sdata->dev != local->mdev) {
|
|
list_del_rcu(&sdata->list);
|
|
synchronize_rcu();
|
|
__ieee80211_if_del(local, sdata);
|
|
return 0;
|
|
}
|
|
}
|
|
return -ENODEV;
|
|
}
|
|
|
|
void ieee80211_if_free(struct net_device *dev)
|
|
{
|
|
struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
|
|
|
|
ieee80211_if_sdata_deinit(sdata);
|
|
free_netdev(dev);
|
|
}
|