![Russell King](/assets/img/avatar_default.png)
This reverts commit 4dd1837d75
.
Moving the exports for assembly code into the assembly files breaks
KSYM trimming, but also breaks modversions.
While fixing the KSYM trimming is trivial, fixing modversions brings
us to a technically worse position that we had prior to the above
change:
- We end up with the prototype definitions divorsed from everything
else, which means that adding or removing assembly level ksyms
become more fragile:
* if adding a new assembly ksyms export, a missed prototype in
asm-prototypes.h results in a successful build if no module in
the selected configuration makes use of the symbol.
* when removing a ksyms export, asm-prototypes.h will get forgotten,
with armksyms.c, you'll get a build error if you forget to touch
the file.
- We end up with the same amount of include files and prototypes,
they're just in a header file instead of a .c file with their
exports.
As for lines of code, we don't get much of a size reduction:
(original commit)
47 files changed, 131 insertions(+), 208 deletions(-)
(fix for ksyms trimming)
7 files changed, 18 insertions(+), 5 deletions(-)
(two fixes for modversions)
1 file changed, 34 insertions(+)
3 files changed, 7 insertions(+), 2 deletions(-)
which results in a net total of only 25 lines deleted.
As there does not seem to be much benefit from this change of approach,
revert the change.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
34 lines
696 B
ArmAsm
34 lines
696 B
ArmAsm
/*
|
|
* linux/arch/arm/lib/csumipv6.S
|
|
*
|
|
* Copyright (C) 1995-1998 Russell King
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
#include <linux/linkage.h>
|
|
#include <asm/assembler.h>
|
|
|
|
.text
|
|
|
|
ENTRY(__csum_ipv6_magic)
|
|
str lr, [sp, #-4]!
|
|
adds ip, r2, r3
|
|
ldmia r1, {r1 - r3, lr}
|
|
adcs ip, ip, r1
|
|
adcs ip, ip, r2
|
|
adcs ip, ip, r3
|
|
adcs ip, ip, lr
|
|
ldmia r0, {r0 - r3}
|
|
adcs r0, ip, r0
|
|
adcs r0, r0, r1
|
|
adcs r0, r0, r2
|
|
ldr r2, [sp, #4]
|
|
adcs r0, r0, r3
|
|
adcs r0, r0, r2
|
|
adcs r0, r0, #0
|
|
ldmfd sp!, {pc}
|
|
ENDPROC(__csum_ipv6_magic)
|
|
|