![]() A number of extern struct declarations in p80211types.h were causing checkpatch warnings: "extern prototypes should be avoided in .h files" and "function definition argument 'xxxxxx' should also have an identifier name". This appears to be a result of using a macro to form the declarations and checkpatch consequently misinterpreting the declarations as function prototypes. On checking, the declarations have no corresponding definition in the driver and are not used, so they are removed along with the macro used to construct them, which is not needed elsewhere. After this change, checkpatch reports that p80211types.h has no obvious issues. Signed-off-by: Tim Collier <osdevtc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
---|---|---|
.. | ||
cfg80211.c | ||
hfa384x.h | ||
hfa384x_usb.c | ||
Kconfig | ||
Makefile | ||
p80211conv.c | ||
p80211conv.h | ||
p80211hdr.h | ||
p80211ioctl.h | ||
p80211metadef.h | ||
p80211metastruct.h | ||
p80211mgmt.h | ||
p80211msg.h | ||
p80211netdev.c | ||
p80211netdev.h | ||
p80211req.c | ||
p80211req.h | ||
p80211types.h | ||
p80211wep.c | ||
prism2fw.c | ||
prism2mgmt.c | ||
prism2mgmt.h | ||
prism2mib.c | ||
prism2sta.c | ||
prism2usb.c | ||
README |
TODO: - checkpatch.pl cleanups - sparse warnings - move to use the in-kernel wireless stack Please send any patches or complaints about this driver to Greg Kroah-Hartman <greg@kroah.com> and don't bother the upstream wireless kernel developers about it, they want nothing to do with it.