![Azhar Shaikh](/assets/img/avatar_default.png)
Commit5e572cab92
("tpm: Enable CLKRUN protocol for Braswell systems") disabled CLKRUN protocol during TPM transactions and re-enabled once the transaction is completed. But there were still some corner cases observed where, reading of TPM header failed for savestate command while going to suspend, which resulted in suspend failure. To fix this issue keep the CLKRUN protocol disabled for the entire duration of a single TPM command and not disabling and re-enabling again for every TPM transaction. For the other TPM accesses outside TPM command flow, add a higher level of disabling and re-enabling the CLKRUN protocol, instead of doing for every TPM transaction. Fixes:5e572cab92
("tpm: Enable CLKRUN protocol for Braswell systems") Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
101 lines
3 KiB
C
101 lines
3 KiB
C
/*
|
|
* Copyright (C) 2004,2007,2008 IBM Corporation
|
|
*
|
|
* Authors:
|
|
* Leendert van Doorn <leendert@watson.ibm.com>
|
|
* Dave Safford <safford@watson.ibm.com>
|
|
* Reiner Sailer <sailer@watson.ibm.com>
|
|
* Kylene Hall <kjhall@us.ibm.com>
|
|
* Debora Velarde <dvelarde@us.ibm.com>
|
|
*
|
|
* Maintained by: <tpmdd_devel@lists.sourceforge.net>
|
|
*
|
|
* Device driver for TCG/TCPA TPM (trusted platform module).
|
|
* Specifications at www.trustedcomputinggroup.org
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation, version 2 of the
|
|
* License.
|
|
*
|
|
*/
|
|
#ifndef __LINUX_TPM_H__
|
|
#define __LINUX_TPM_H__
|
|
|
|
#define TPM_DIGEST_SIZE 20 /* Max TPM v1.2 PCR size */
|
|
|
|
struct tpm_chip;
|
|
struct trusted_key_payload;
|
|
struct trusted_key_options;
|
|
|
|
enum TPM_OPS_FLAGS {
|
|
TPM_OPS_AUTO_STARTUP = BIT(0),
|
|
};
|
|
|
|
struct tpm_class_ops {
|
|
unsigned int flags;
|
|
const u8 req_complete_mask;
|
|
const u8 req_complete_val;
|
|
bool (*req_canceled)(struct tpm_chip *chip, u8 status);
|
|
int (*recv) (struct tpm_chip *chip, u8 *buf, size_t len);
|
|
int (*send) (struct tpm_chip *chip, u8 *buf, size_t len);
|
|
void (*cancel) (struct tpm_chip *chip);
|
|
u8 (*status) (struct tpm_chip *chip);
|
|
bool (*update_timeouts)(struct tpm_chip *chip,
|
|
unsigned long *timeout_cap);
|
|
int (*request_locality)(struct tpm_chip *chip, int loc);
|
|
void (*relinquish_locality)(struct tpm_chip *chip, int loc);
|
|
void (*clk_enable)(struct tpm_chip *chip, bool value);
|
|
};
|
|
|
|
#if defined(CONFIG_TCG_TPM) || defined(CONFIG_TCG_TPM_MODULE)
|
|
|
|
extern int tpm_is_tpm2(struct tpm_chip *chip);
|
|
extern int tpm_pcr_read(struct tpm_chip *chip, int pcr_idx, u8 *res_buf);
|
|
extern int tpm_pcr_extend(struct tpm_chip *chip, int pcr_idx, const u8 *hash);
|
|
extern int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen);
|
|
extern int tpm_get_random(struct tpm_chip *chip, u8 *data, size_t max);
|
|
extern int tpm_seal_trusted(struct tpm_chip *chip,
|
|
struct trusted_key_payload *payload,
|
|
struct trusted_key_options *options);
|
|
extern int tpm_unseal_trusted(struct tpm_chip *chip,
|
|
struct trusted_key_payload *payload,
|
|
struct trusted_key_options *options);
|
|
#else
|
|
static inline int tpm_is_tpm2(struct tpm_chip *chip)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int tpm_pcr_read(struct tpm_chip *chip, int pcr_idx, u8 *res_buf)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int tpm_pcr_extend(struct tpm_chip *chip, int pcr_idx,
|
|
const u8 *hash)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int tpm_get_random(struct tpm_chip *chip, u8 *data, size_t max)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline int tpm_seal_trusted(struct tpm_chip *chip,
|
|
struct trusted_key_payload *payload,
|
|
struct trusted_key_options *options)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int tpm_unseal_trusted(struct tpm_chip *chip,
|
|
struct trusted_key_payload *payload,
|
|
struct trusted_key_options *options)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
#endif
|