1
0
Fork 0
alistair23-linux/drivers/leds/trigger
Martin Schiller b6b7636ac4 leds: trigger: netdev: fix handling on interface rename
[ Upstream commit 5f820ed523 ]

The NETDEV_CHANGENAME code is not "unneeded" like it is stated in commit
4cb6560514 ("leds: trigger: netdev: fix refcnt leak on interface
rename").

The event was accidentally misinterpreted equivalent to
NETDEV_UNREGISTER, but should be equivalent to NETDEV_REGISTER.

This was the case in the original code from the openwrt project.

Otherwise, you are unable to set netdev led triggers for (non-existent)
netdevices, which has to be renamed. This is the case, for example, for
ppp interfaces in openwrt.

Fixes: 06f502f57d ("leds: trigger: Introduce a NETDEV trigger")
Fixes: 4cb6560514 ("leds: trigger: netdev: fix refcnt leak on interface rename")
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-04 19:17:05 +01:00
..
Kconfig LED updates for 5.3-rc1 2019-07-09 08:59:39 -07:00
Makefile leds: trigger: Introduce audio mute LED trigger 2018-11-28 12:28:30 +01:00
ledtrig-activity.c Merge branch 'timers/vdso' into timers/core 2019-07-03 10:50:21 +02:00
ledtrig-audio.c leds: trigger: Introduce audio mute LED trigger 2018-11-28 12:28:30 +01:00
ledtrig-backlight.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-camera.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-cpu.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-default-on.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-disk.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-gpio.c leds: trigger: gpio: GPIO 0 is valid 2019-09-01 13:33:30 +02:00
ledtrig-heartbeat.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-mtd.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-netdev.c leds: trigger: netdev: fix handling on interface rename 2020-01-04 19:17:05 +01:00
ledtrig-oneshot.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-panic.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-pattern.c leds: trigger: pattern: Add pattern initialization from Device Tree 2019-01-16 22:08:47 +01:00
ledtrig-timer.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ledtrig-transient.c docs: leds: convert to ReST 2019-06-28 20:57:31 +02:00