redonkable
/
alistair23-linux
1
0
Fork 0
Code Releases Activity
alistair23-linux/drivers/staging/rts5208
History
Joe Perches 8ee775f92c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 
Macros with hidden flow control are bad form as the code path
taken can be unexpected for the reader.

Expand these in-place and remove the macros.

Done with coccinelle script:

@@
expression chip;
expression arg1;
expression arg2;
expression arg3;
@@

-	RTSX_WRITE_REG(chip, arg1, arg2, arg3);
+	retval = rtsx_write_register(chip, arg1, arg2, arg3);
+	if (retval) {
+		rtsx_trace(chip);
+		return retval;
+	}

@@
expression chip;
expression arg1;
expression arg2;
@@

-	RTSX_READ_REG(chip, arg1, arg2);
+	retval = rtsx_read_register(chip, arg1, arg2);
+	if (retval) {
+		rtsx_trace(chip);
+		return retval;
+	}

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
 		2015-03-26 13:17:05 +01:00
..
Kconfig Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option 2014-08-16 12:23:13 -07:00
Makefile staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
TODO
…
general.c staging: rts5208: add new line after declarations 2014-09-23 13:22:25 -07:00
general.h
…
ms.c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
ms.h staging: rts5208: Convert variable from int to bool and propagate the change to function parameters 2015-03-06 17:25:01 -08:00
rtsx.c staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
rtsx.h staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
rtsx_card.c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
rtsx_card.h staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
rtsx_chip.c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
rtsx_chip.h staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
rtsx_scsi.c staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
rtsx_scsi.h Staging: rts5208: Replace custom macro with dev_dbg 2014-07-30 17:22:18 -07:00
rtsx_sys.h
…
rtsx_transport.c staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
rtsx_transport.h staging, rts5208, LLVMLinux: Change extern inline to static inline 2014-10-29 16:28:17 -07:00
sd.c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
sd.h staging: rts5208: Convert variable from int to bool and propagate the change to function parameters 2015-03-06 17:25:01 -08:00
spi.c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
spi.h
…
trace.c staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
trace.h staging: rts5208: Remove TRACE_RET and TRACE_GOTO macros 2015-03-26 13:16:19 +01:00
xd.c staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros 2015-03-26 13:17:05 +01:00
xd.h
…