Martin Wilck c64d2e1598 scsi: core: Fix VPD LUN ID designator priorities ... [ Upstream commit 2e4209b380 ] The current implementation of scsi_vpd_lun_id() uses the designator length as an implicit measure of priority. This works most of the time, but not always. For example, some Hitachi storage arrays return this in VPD 0x83: VPD INQUIRY: Device Identification page Designation descriptor number 1, descriptor length: 24 designator_type: T10 vendor identification, code_set: ASCII associated with the Addressed logical unit vendor id: HITACHI vendor specific: 5030C3502025 Designation descriptor number 2, descriptor length: 6 designator_type: vendor specific [0x0], code_set: Binary associated with the Target port vendor specific: 08 03 Designation descriptor number 3, descriptor length: 20 designator_type: NAA, code_set: Binary associated with the Addressed logical unit NAA 6, IEEE Company_id: 0x60e8 Vendor Specific Identifier: 0x7c35000 Vendor Specific Identifier Extension: 0x30c35000002025 [0x60060e8007c350000030c35000002025] The current code would use the first descriptor because it's longer than the NAA descriptor. But this is wrong, the kernel is supposed to prefer NAA descriptors over T10 vendor ID. Designator length should only be used to compare designators of the same type. This patch addresses the issue by separating designator priority and length. Link: https://lore.kernel.org/r/20201029170846.14786-1-mwilck@suse.com Fixes: 9983bed390 ("scsi: Add scsi_vpd_lun_id()") Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Martin Wilck <mwilck@suse.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-12-30 11:51:08 +01:00
..
accessibility	…
acpi	ACPI: button: Add DMI quirk for Medion Akoya E2228T	2020-11-24 13:29:00 +01:00
amba	…
android	binder: Remove bogus warning on failed same-process transaction	2020-10-29 09:57:37 +01:00
ata	ata: sata_nv: Fix retrieving of active qcs	2020-11-05 11:43:12 +01:00
atm	atm: nicstar: Unmap DMA on send error	2020-11-24 13:28:55 +01:00
auxdisplay	…
base	PM: runtime: Resume the device earlier in __device_release_driver()	2020-11-10 12:37:34 +01:00
bcma	…
block	nbd: fix a block_device refcount leak in nbd_release	2020-11-18 19:20:27 +01:00
bluetooth	Bluetooth: hci_h5: fix memory leak in h5_close	2020-12-30 11:51:05 +01:00
bus	bus: ti-sysc: Fix bogus resetdone warning on enable for cpsw	2020-12-02 08:49:49 +01:00
cdrom	…
char	virtio: virtio_console: fix DMA memory allocation for rproc serial	2020-11-18 19:20:29 +01:00
clk	clk: renesas: r9a06g032: Drop __packed for portability	2020-12-30 11:50:53 +01:00
clocksource	clocksource/drivers/timer-gx6605s: Fixup counter reload	2020-10-07 08:01:25 +02:00
connector	…
counter	…
cpufreq	acpi-cpufreq: Honor _PSD table setting on new AMD CPUs	2020-11-05 11:43:25 +01:00
cpuidle	cpuidle: Fixup IRQ state	2020-09-09 19:12:21 +02:00
crypto	crypto: qat - fix status check in qat_hal_put_rel_rd_xfer()	2020-12-30 11:51:07 +01:00
dax	dax: Fix alloc_dax_region() compile warning	2020-10-01 13:17:15 +02:00
dca	…
devfreq	PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out	2020-10-01 13:17:14 +02:00
dio	…
dma	dmaengine: pl330: _prep_dma_memcpy: Fix wrong burst size	2020-12-02 08:49:48 +01:00
dma-buf	dmabuf: fix NULL pointer dereference in dma_buf_release()	2020-10-01 13:18:24 +02:00
edac	EDAC/ti: Fix handling of platform_get_irq() error	2020-10-29 09:57:29 +01:00
eisa	…
extcon	extcon: ptn5150: Fix usage of atomic GPIO with sleeping GPIO chips	2020-11-05 11:43:24 +01:00
firewire	…
firmware	efi: EFI_EARLYCON should depend on EFI	2020-12-02 08:49:53 +01:00
fpga	fpga: dfl: fix bug in port reset handshake	2020-07-29 10:18:31 +02:00
fsi	…
gnss	…
gpio	gpio: eic-sprd: break loop when getting NULL device resource	2020-12-30 11:50:55 +01:00
gpu	drm/msm/dsi_pll_10nm: restore VCO rate during restore_state	2020-12-30 11:51:04 +01:00
greybus	…
hid	HID: i2c-hid: add Vero K147 to descriptor override	2020-12-30 11:51:00 +01:00
hsi	…
hv	Drivers: hv: vmbus: Allow cleanup of VMBUS_CONNECT_CPU if disconnected	2020-11-24 13:29:23 +01:00
hwmon	hwmon: (pwm-fan) Fix RPM calculation	2020-11-24 13:29:01 +01:00
hwspinlock	…
hwtracing	coresight: etb10: Fix possible NULL ptr dereference in etb_enable_perf()	2020-12-30 11:50:59 +01:00
i2c	Revert "i2c: i2c-qcom-geni: Fix DMA transfer race"	2020-12-30 11:51:01 +01:00
i3c	i3c: master: Fix error return in cdns_i3c_master_probe()	2020-10-29 09:57:51 +01:00
ide	…
idle	…
iio	iio: adc: mediatek: fix unset field	2020-11-24 13:29:21 +01:00
infiniband	RDMa/mthca: Work around -Wenum-conversion warning	2020-12-30 11:51:07 +01:00
input	Input: i8042 - add Acer laptops to the i8042 reset list	2020-12-16 10:56:57 +01:00
interconnect	interconnect: qcom: qcs404: Remove GPU and display RPM IDs	2020-12-16 10:56:56 +01:00
iommu	iommu/amd: Set DTE[IntTabLen] to represent 512 IRTEs	2020-12-11 13:23:31 +01:00
ipack	…
irqchip	irqchip/gic-v3-its: Unconditionally save/restore the ITS state on suspend	2020-12-16 10:56:56 +01:00
isdn	…
leds	leds: bcm6328, bcm6358: use devres LED registering function	2020-11-05 11:43:24 +01:00
lightnvm	lightnvm: fix out-of-bounds write to array devices->info[]	2020-10-29 09:58:00 +01:00
macintosh	macintosh/via-macii: Access autopoll_devs when inside lock	2020-08-19 08:16:15 +02:00
mailbox	mailbox: avoid timer start from callback	2020-10-29 09:57:53 +01:00
mcb	…
md	md: fix a warning caused by a race between concurrent md_ioctl()s	2020-12-30 11:51:00 +01:00
media	media: v4l2-fwnode: Return -EINVAL for invalid bus-type	2020-12-30 11:51:08 +01:00
memory	memory: emif: Remove bogus debugfs error handling	2020-11-05 11:43:21 +01:00
memstick	memstick: Skip allocating card when removing host	2020-10-07 08:01:25 +02:00
message	scsi: mptfusion: Fix null pointer dereferences in mptscsih_remove()	2020-11-05 11:43:25 +01:00
mfd	mfd: sprd: Add wakeup capability for PMIC IRQ	2020-11-18 19:20:26 +01:00
misc	habanalabs: put devices before driver removal	2020-12-30 11:50:56 +01:00
mmc	mmc: block: Fixup condition for CMD13 polling for RPMB requests	2020-12-16 10:56:58 +01:00
mtd	mtd: spi-nor: Don't copy self-pointing struct around	2020-11-10 12:37:28 +01:00
mux	…
net	mwifiex: fix mwifiex_shutdown_sw() causing sw reset failure	2020-12-30 11:51:06 +01:00
nfc	nfc: s3fwrn5: use signed integer for parsing GPIO numbers	2020-12-02 08:49:52 +01:00
ntb	NTB: hw: amd: fix an issue about leak system resources	2020-10-29 09:58:00 +01:00
nubus	…
nvdimm	libnvdimm/security: ensure sysfs poll thread woke up and fetch updated attr	2020-08-21 13:05:35 +02:00
nvme	nvme: free sq/cq dbbuf pointers when dbbuf set fails	2020-12-02 08:49:48 +01:00
nvmem	nvmem: core: fix possibly memleak when use nvmem_cell_info_to_nvmem_cell()	2020-10-29 09:57:42 +01:00
of	of/address: Fix of_node memory leak in of_dma_is_coherent	2020-11-18 19:20:28 +01:00
opp	opp: Reduce the size of critical section in _opp_table_kref_release()	2020-11-18 19:20:21 +01:00
oprofile	…
parisc	parisc: mask out enable and reserved bits from sba imask	2020-08-19 08:16:26 +02:00
parport	…
pci	PCI: qcom: Make sure PCIe is reset before init for rev 2.1.0	2020-11-18 19:20:16 +01:00
pcmcia	…
perf	drivers/perf: thunderx2_pmu: Fix memory resource error handling	2020-10-29 09:57:30 +01:00
phy	phy: tegra: xusb: Fix dangling pointer on probe failure	2020-12-02 08:49:50 +01:00
pinctrl	pinctrl: aspeed: Fix GPIO requests on pass-through banks	2020-12-30 11:50:54 +01:00
platform	platform/x86: touchscreen_dmi: Add info for the Irbis TW118 tablet	2020-12-16 10:56:57 +01:00
pnp	…
power	power: supply: test_power: add missing newlines when printing parameters by sysfs	2020-11-05 11:43:19 +01:00
powercap	powercap: restrict energy meter to root access	2020-11-10 21:13:20 +01:00
pps	…
ps3	…
ptp	…
pwm	pwm: img: Fix null pointer access in probe	2020-10-29 09:57:54 +01:00
rapidio	rapidio: fix the missed put_device() for rio_mport_add_riodev	2020-10-29 09:57:53 +01:00
ras	…
regulator	regulator: workaround self-referent regulators	2020-11-24 13:29:22 +01:00
remoteproc	remoteproc: qcom_q6v5_mss: Validate modem blob firmware size before load	2020-08-21 13:05:29 +02:00
reset	…
rpmsg	rpmsg: glink: Use complete_all for open states	2020-11-05 11:43:20 +01:00
rtc	rtc: pcf2127: fix pcf2127_nvmem_read/write() returns	2020-12-30 11:51:02 +01:00
s390	s390/qeth: fix tear down of async TX buffers	2020-12-02 08:49:51 +01:00
sbus	…
scsi	scsi: core: Fix VPD LUN ID designator priorities	2020-12-30 11:51:08 +01:00
sfi	…
sh	…
siox	…
slimbus	slimbus: qcom-ngd-ctrl: disable ngd in qmi server down callback	2020-10-29 09:57:42 +01:00
soc	soc: qcom: geni: More properly switch to DMA mode	2020-12-30 11:51:01 +01:00
soundwire	soundwire: bus: disable pm_runtime in sdw_slave_delete	2020-10-01 13:17:36 +02:00
spi	spi: sprd: fix reference leak in sprd_spi_remove	2020-12-30 11:51:07 +01:00
spmi	…
ssb	…
staging	staging: gasket: interrupt: fix the missed eventfd_ctx_put() in gasket_interrupt.c	2020-12-30 11:51:07 +01:00
target	scsi: target: iscsi: Fix cmd abort fabric stop race	2020-12-02 08:49:49 +01:00
tc	…
tee	optee: add writeback to valid memory type	2020-12-02 08:49:53 +01:00
thermal	thermal: rcar_thermal: Handle probe error gracefully	2020-10-01 13:17:44 +02:00
thunderbolt	thunderbolt: Fix use-after-free in remove_unplugged_switch()	2020-12-11 13:23:29 +01:00
tty	serial_core: Check for port state when tty is in error state	2020-12-30 11:51:00 +01:00
uio	uio: Fix use-after-free in uio_unregister_device()	2020-11-18 19:20:29 +01:00
usb	usb: chipidea: ci_hdrc_imx: Pass DISABLE_DEVICE_STREAMING flag to imx6ul	2020-12-30 11:50:58 +01:00
vfio	vfio/pci: Bypass IGD init in case of -ENODEV	2020-11-18 19:20:25 +01:00
vhost	vhost scsi: fix cmd completion race	2020-12-02 08:49:48 +01:00
video	video: hyperv_fb: Fix the cache type when mapping the VRAM	2020-12-02 08:49:51 +01:00
virt	drivers/virt/fsl_hypervisor: Fix error handling path	2020-10-29 09:57:38 +01:00
virtio	virtio_ring: Avoid loop when vq is broken in virtqueue_poll	2020-08-26 10:40:57 +02:00
visorbus	…
vlynq	…
vme	…
w1	w1: mxc_w1: Fix timeout resolution problem leading to bus error	2020-11-05 11:43:25 +01:00
watchdog	drivers: watchdog: rdc321x_wdt: Fix race condition bugs	2020-11-05 11:43:20 +01:00
xen	xen/events: block rogue events for some time	2020-11-05 11:43:12 +01:00
zorro	…
Kconfig	…
Makefile	…