1
0
Fork 0
alistair23-linux/drivers/net/wireless/realtek/rtlwifi/rtl8821ae
Larry Finger c713fb071e rtlwifi: rtl8821ae: Fix connection lost problem correctly
There has been a coding error in rtl8821ae since it was first introduced,
namely that an 8-bit register was read using a 16-bit read in
_rtl8821ae_dbi_read(). This error was fixed with commit 40b368af4b
("rtlwifi: Fix alignment issues"); however, this change led to
instability in the connection. To restore stability, this change
was reverted in commit b8b8b16352 ("rtlwifi: rtl8821ae: Fix connection
lost problem").

Unfortunately, the unaligned access causes machine checks in ARM
architecture, and we were finally forced to find the actual cause of the
problem on x86 platforms. Following a suggestion from Pkshih
<pkshih@realtek.com>, it was found that increasing the ASPM L1
latency from 0 to 7 fixed the instability. This parameter was varied to
see if a smaller value would work; however, it appears that 7 is the
safest value. A new symbol is defined for this quantity, thus it can be
easily changed if necessary.

Fixes: b8b8b16352 ("rtlwifi: rtl8821ae: Fix connection lost problem")
Cc: Stable <stable@vger.kernel.org> # 4.14+
Fix-suggested-by: Pkshih <pkshih@realtek.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Tested-by: James Cameron <quozl@laptop.org>  # x86_64 OLPC NL3
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
2018-02-07 15:38:37 +02:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
def.h
dm.c rtlwifi: Add bw_update parameter for RA mask update. 2017-10-13 12:43:41 +03:00
dm.h
fw.c rtlwifi: rtl8821ae: fix spelling mistake: "faill" -> "failed" 2017-08-24 12:56:05 +03:00
fw.h rtlwifi: Add btcoex record_pwr_mode 2017-06-21 18:28:05 +03:00
hw.c rtlwifi: rtl8821ae: Fix connection lost problem correctly 2018-02-07 15:38:37 +02:00
hw.h rtlwifi: Convert individual interrupt results to struct 2017-12-07 15:13:32 +02:00
led.c rtlwifi: Move items out of rtl_pci_priv and rtl_usb_priv 2017-02-08 17:24:42 +02:00
led.h
phy.c rtlwifi: make a couple arrays larger 2017-08-24 12:53:50 +03:00
phy.h rtlwifi: use s8 instead of char 2016-06-29 18:48:15 +03:00
pwrseq.c
pwrseq.h
reg.h rtlwifi: fix REG_USTIME_TSF register definition 2017-06-21 18:23:43 +03:00
rf.c rtlwifi: rtl8821ae: Remove all instances of DBG_EMERG 2016-12-30 15:54:20 +02:00
rf.h
sw.c rtlwifi: Add module parameter ASPM 2017-10-13 12:43:42 +03:00
sw.h
table.c wireless: use ARRAY_SIZE 2017-12-08 15:19:46 +02:00
table.h rtlwifi: Update 8812ae new phy parameters and its parser. 2017-03-20 19:10:15 +02:00
trx.c rtlwifi: rtl8192ee: Make driver support 64bits DMA. 2017-10-13 12:43:38 +03:00
trx.h rtlwifi: rtl8192ee: Make driver support 64bits DMA. 2017-10-13 12:43:38 +03:00