Stephen Boyd 9b4f327c07 platform/chrome: cros_ec_spi: Don't overwrite spi::mode ... [ Upstream commit 74639cbf51 ] There isn't any need to overwrite the mode here in the driver with what has been detected by the firmware, such as DT or ACPI. In fact, if we use the SPI CS gpio descriptor feature we will overwrite the mode with SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle when the device is probed when it shouldn't change, confusing the driver and making it fail to probe. Drop the assignment and let the spi core take care of it. Fixes: a17d94f0b6 ("mfd: Add ChromeOS EC SPI driver") Cc: Simon Glass <sjg@chromium.org> Cc: Gwendal Grignou <gwendal@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Alexandru M Stan <amstan@chromium.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Link: https://lore.kernel.org/r/20201204193540.3047030-2-swboyd@chromium.org Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-12-30 11:51:23 +01:00
..
chrome	platform/chrome: cros_ec_spi: Don't overwrite spi::mode	2020-12-30 11:51:23 +01:00
goldfish	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
mellanox	platform/mellanox: fix potential deadlock in the tmfifo driver	2020-01-17 19:48:42 +01:00
mips	MIPS: Loongson: Fix return value of loongson_hwmon_init	2020-01-17 19:48:55 +01:00
olpc	Platform: OLPC: Fix memleak in olpc_ec_probe	2020-10-14 10:32:58 +02:00
x86	platform/x86: mlx-platform: Fix item counter assignment for MSN2700, MSN24xx systems	2020-12-30 11:51:21 +01:00
Kconfig	platform-drivers-x86 for v5.3-1	2019-07-14 16:51:47 -07:00
Makefile	Platform: OLPC: Add XO-1.75 EC driver	2019-05-20 17:27:08 +03:00